Deleting a string redirects to main component page instead of the next string

[burner1024]

Describe the issue

Not sure if it's intended behaviour or a bug/oversight.
After deleting a string, you're redirected to the component language page, instead of the next string.

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

In process of translation, delete a string. You're redirected to the main translation page.

Expected behavior

I'd expect to be redirected to the next string/unit. (As if I've translated/saved the previous, deleted string).

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

• Weblate: 4.9
• Django: 3.2.9
• siphashc: 2.1
• translate-toolkit: 3.5.1
• lxml: 4.6.4
• Pillow: 8.4.0
• bleach: 4.1.0
• python-dateutil: 2.8.2
• social-auth-core: 4.1.0
• social-auth-app-django: 5.0.0
• django-crispy-forms: 1.13.0
• oauthlib: 3.1.1
• django-compressor: 2.4.1
• djangorestframework: 3.12.4
• django-filter: 21.1
• django-appconf: 1.0.5
• user-agents: 2.2.0
• filelock: 3.3.2
• setuptools: 58.5.3
• jellyfish: 0.8.9
• openpyxl: 3.0.9
• celery: 5.2.0
• kombu: 5.2.1
• translation-finder: 2.10
• weblate-language-data: 2021.5
• html2text: 2020.1.16
• pycairo: 1.16.2
• pygobject: 3.38.0
• diff-match-patch: 20200713
• requests: 2.26.0
• django-redis: 5.0.0
• hiredis: 2.0.0
• sentry_sdk: 1.4.3
• Cython: 0.29.24
• misaka: 2.1.1
• GitPython: 3.1.24
• borgbackup: 1.1.17
• pyparsing: 3.0.5
• pyahocorasick: 1.4.2
• python-redis-lock: 3.7.0
• Python: 3.9.2
• Git: 2.30.2
• psycopg2: 2.9.1
• psycopg2-binary: 2.9.1
• phply: 1.2.5
• chardet: 4.0.0
• ruamel.yaml: 0.17.17
• tesserocr: 2.5.2
• akismet: 1.1
• boto3: 1.20.2
• zeep: 4.1.0
• aeidon: 1.10.1
• iniparse: 0.5
• mysqlclient: 2.0.3
• Mercurial: 5.9.3
• git-svn: 2.30.2
• git-review: 2.1.0
• Redis server: 6.2.4
• PostgreSQL server: 13.3
• Database backends: django.db.backends.postgresql
• Cache backends: default:RedisCache, avatar:FileBasedCache
• Email setup: django.core.mail.backends.smtp.EmailBackend: 127.0.0.1
• OS encoding: filesystem=utf-8, default=utf-8
• Celery: redis://cache:6379/1, redis://cache:6379/1, regular
• Platform: Linux 5.11.0-38-generic (x86_64)

Weblate deploy checks

SystemCheckError: System check identified some issues:

CRITICALS:
?: (weblate.E003) Cannot send e-mail ([Errno 111] Connection refused), please check EMAIL_* settings.
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/install.html#out-mail
?: (weblate.E012) The server e-mail address should be changed from its default value
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/install.html#production-email
?: (weblate.E013) The "From" e-mail address should be changed from its default value
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/install.html#production-email
?: (weblate.E027) The path /app/data/secret is owned by a different user, check your DATA_DIR settings.
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/install.html#file-permissions

ERRORS:
?: (weblate.E011) E-mail addresses for site admins is misconfigured
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/install.html#production-admins

WARNINGS:
?: (security.W004) You have not set a value for the SECURE_HSTS_SECONDS setting. If your entire site is served only over SSL, you may want to consider setting a value and enabling HTTP Strict Transport Security. Be sure to read the documentation first; enabling HSTS carelessly can cause serious, irreversible problems.
?: (security.W008) Your SECURE_SSL_REDIRECT setting is not set to True. Unless your site should be available over both SSL and non-SSL connections, you may want to either set this setting True or configure a load balancer or reverse-proxy server to redirect all connections to HTTPS.
?: (security.W012) SESSION_COOKIE_SECURE is not set to True. Using a secure-only session cookie makes it more difficult for network traffic sniffers to hijack user sessions.
?: (security.W018) You should not have DEBUG set to True in deployment.

INFOS:
?: (weblate.I021) Error collection is not set up, it is highly recommended for production use
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/install.html#collecting-errors
?: (weblate.I028) Backups are not configured, it is highly recommended for production use
	HINT: https://docs.weblate.org/en/weblate-4.9/admin/backup.html

System check identified 11 issues (1 silenced).

Additional context

No response

[nijel]

This is currently intentional, but it makes sense to change it to go to the next string.

[burner1024]

It's is actually more or less the same with adding: the added string becomes last and browser is redirected to it. So if you add a variant from Tools menu, translation flow is interrupted, you have to go back to the original string manually.
It might make more sense to stay on the same string after adding a variant for it.

[github-actions]

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

[AdityaBoghara]

Hi @nijel,

I’d like to work on this issue as my first contribution to Weblate. I reviewed the discussion and understand that after deleting a string, the expected behavior is to redirect to the next string or unit instead of the main component language page.

I’ll look into the delete string flow, check how Weblate determines the next unit after saving or translating, and try to reuse that behavior for the delete action. I’ll also add or update tests if needed.

Could you please assign this issue to me?

Thank you!

[nijel]

You're welcome to submit a pull request for the issue, no assignment is needed.