remove unused forms

Summary: - `ExternalForm` and `ExtType` are not sent to eqWAlizer anymore and can be deleted

Reviewed By: VLanvin

Differential Revision: D60387724

fbshipit-source-id: 9fafabc80f6ee148ac9f9a189cf848272c0b351f

Author: ilya-klyuchnikov

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/Pipeline.scala

@@ -24,7 +24,7 @@ object Pipeline {
   def checkForms(moduleName: String, options: Options = noOptions): List[InternalForm] = {
     import scala.collection.mutable.ListBuffer
 
-    val forms = Forms.load(moduleName).collect { case f: InternalForm => f }
+    val forms = Forms.load(moduleName)
     val module = forms.collectFirst { case Module(m) => m }.get
     val erlFile = forms.collectFirst { case File(f, _) => f }.get
     val noCheckFuns = forms.collect { case f: EqwalizerNowarnFunction => (f.id, f.pos) }.toMap

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/ast/ExternalTypes.scala

@@ -7,7 +7,6 @@
 package com.whatsapp.eqwalizer.ast
 
 import com.whatsapp.eqwalizer.ast.Exprs.{Clause, Expr}
-import com.whatsapp.eqwalizer.ast.ExternalTypes._
 import com.whatsapp.eqwalizer.ast.InvalidDiagnostics.Invalid
 import com.whatsapp.eqwalizer.ast.Types._
 import com.whatsapp.eqwalizer.tc.TcDiagnostics.{BehaviourError, TypeError}
@@ -19,37 +18,20 @@ import scala.collection.immutable.TreeSeqMap
 
 object Forms {
 
-  case class Module(name: String)(val pos: Pos) extends ExternalForm with InternalForm
-  case class CompileExportAll()(val pos: Pos) extends ExternalForm
-  case class Export(funs: List[Id])(val pos: Pos) extends ExternalForm with InternalForm
-  case class Import(module: String, funs: List[Id])(val pos: Pos) extends ExternalForm with InternalForm
-  case class ExportType(types: List[Id])(val pos: Pos) extends ExternalForm with InternalForm
-  case class FunDecl(id: Id, clauses: List[Clause])(val pos: Pos) extends ExternalForm with InternalForm
-  case class File(file: String, start: Int)(val pos: Pos) extends ExternalForm with InternalForm
+  case class Module(name: String)(val pos: Pos) extends InternalForm
+  case class Export(funs: List[Id])(val pos: Pos) extends InternalForm
+  case class Import(module: String, funs: List[Id])(val pos: Pos) extends InternalForm
+  case class ExportType(types: List[Id])(val pos: Pos) extends InternalForm
+  case class FunDecl(id: Id, clauses: List[Clause])(val pos: Pos) extends InternalForm
+  case class File(file: String, start: Int)(val pos: Pos) extends InternalForm
   case class Fixme(comment: TextRange, suppression: TextRange, isIgnore: Boolean)
-  case class ElpMetadata(fixmes: List[Fixme])(val pos: Pos) extends ExternalForm with InternalForm
-  case class Behaviour(name: String)(val pos: Pos) extends ExternalForm with InternalForm
-  case class EqwalizerNowarnFunction(id: Id)(val pos: Pos) extends ExternalForm with InternalForm
-  case class EqwalizerUnlimitedRefinement(id: Id)(val pos: Pos) extends ExternalForm with InternalForm
-
-  /** used for analyses only, should not affect the behavior of the type checker
-   */
-  case class TypingAttribute(names: List[String])(val pos: Pos) extends ExternalForm
+  case class ElpMetadata(fixmes: List[Fixme])(val pos: Pos) extends InternalForm
+  case class Behaviour(name: String)(val pos: Pos) extends InternalForm
+  case class EqwalizerNowarnFunction(id: Id)(val pos: Pos) extends InternalForm
+  case class EqwalizerUnlimitedRefinement(id: Id)(val pos: Pos) extends InternalForm
 
   sealed trait Form
 
-  sealed trait ExternalForm extends Form { val pos: Pos }
-  case class ExternalTypeDecl(id: Id, params: List[String], body: ExtType, file: Option[String])(val pos: Pos)
-      extends ExternalForm
-  case class ExternalOpaqueDecl(id: Id, params: List[String], body: ExtType, file: Option[String])(val pos: Pos)
-      extends ExternalForm
-  case class ExternalFunSpec(id: Id, types: List[ConstrainedFunType])(val pos: Pos) extends ExternalForm
-  case class ExternalCallback(id: Id, types: List[ConstrainedFunType])(val pos: Pos) extends ExternalForm
-  case class ExternalOptionalCallbacks(ids: List[Id])(val pos: Pos) extends ExternalForm
-  case class ExternalRecDecl(name: String, fields: List[ExternalRecField], file: Option[String])(val pos: Pos)
-      extends ExternalForm
-  case class ExternalRecField(name: String, tp: Option[ExtType], defaultValue: Option[Expr])
-
   sealed trait InternalForm extends Form { val pos: Pos }
   case class FunSpec(id: Id, ty: FunType)(val pos: Pos) extends InternalForm
   case class OverloadedFunSpec(id: Id, tys: List[FunType])(val pos: Pos) extends InternalForm
@@ -81,12 +63,12 @@ object Forms {
   case class FuncDecl(id: Id, errors: List[TypeError])(val pos: Pos) extends InternalForm
   case class MisBehaviour(te: BehaviourError)(val pos: Pos) extends InternalForm
 
-  def load(module: String): List[ExternalForm] = {
+  def load(module: String): List[InternalForm] = {
     val bytes = Ipc.getAstBytes(module, Ipc.ConvertedForms).get
-    readFromArray[List[ExternalForm]](bytes)
+    readFromArray[List[InternalForm]](bytes)
   }
 
-  implicit val codec: JsonValueCodec[List[ExternalForm]] = JsonCodecMaker.make(
+  implicit val codec: JsonValueCodec[List[InternalForm]] = JsonCodecMaker.make(
     CodecMakerConfig.withAllowRecursiveTypes(true).withDiscriminatorFieldName(None).withFieldNameMapper {
       case "pos"                     => "location"
       case "mod"                     => "module"