clean up: overloadedSpecDomainCheck is always on

Summary:
- as title
- moving overloaded_specs_union.erl from options to check test project
- regenerating snapshot outputs, which triggers a few more type errors

Reviewed By: michalmuskala, TD5

Differential Revision: D65595959

fbshipit-source-id: 2570d414973cd52be6c79d58a2f3186dd71c0dae

Author: ilya-klyuchnikov

crates/elp/src/bin/main.rs

@@ -1744,7 +1744,6 @@ mod tests {
                 fault_tolerance: Some(true),
                 clause_coverage: Some(true),
                 report_bad_maps: Some(true),
-                overloaded_spec_domain_check: Some(true),
                 report_dynamic_lambdas: Some(true),
                 ..EqwalizerConfig::default_test()
             },

crates/elp/src/resources/test/eqwalizer_tests/check/custom.pretty

@@ -1771,6 +1771,23 @@ Context expected type: #{c := atom()}
 
 See https://fb.me/eqwalizer_errors#incompatible_types
 
+error: incompatible_types
+     ┌─ check/src/custom.erl:1916:23
+     │
+1916 │     custom_overloaded(X).
+     │                       ^
+     │                       │
+     │                       X.
+Expression has type:   term()
+Context expected type: atom() | binary()
+
+See https://fb.me/eqwalizer_errors#incompatible_types
+     │                       
+
+  term() is not compatible with atom() | binary()
+  because
+  term() is not compatible with atom()
+
 error: incompatible_types
      ┌─ check/src/custom.erl:1939:5
      │
@@ -2278,4 +2295,4 @@ See https://fb.me/eqwalizer_errors#incompatible_types
   at tuple index 1:
   {'ok', atom()} is not compatible with {'error', term()}
 
-159 ERRORS
+160 ERRORS

crates/elp/src/resources/test/eqwalizer_tests/check/overloaded.pretty

@@ -8,6 +8,40 @@ Context expected type: atom()
 
 See https://fb.me/eqwalizer_errors#incompatible_types
 
+error: incompatible_types
+    ┌─ check/src/overloaded.erl:117:15
+    │
+117 │     Res = bar(F),
+    │               ^
+    │               │
+    │               F.
+Expression has type:   fun(('a') -> 'z')
+Context expected type: fun(('a') -> 'b') | fun(('a') -> 'c')
+
+See https://fb.me/eqwalizer_errors#incompatible_types
+    │               
+
+  fun(('a') -> 'z') is not compatible with fun(('a') -> 'b') | fun(('a') -> 'c')
+  because
+  fun(('a') -> 'z') is not compatible with fun(('a') -> 'b')
+  because
+  'z' is not compatible with 'b'
+
+error: incompatible_types
+    ┌─ check/src/overloaded.erl:126:15
+    │
+126 │     Res = bar({fun(a) -> a end}),
+    │               ^^^^^^^^^^^^^^^^^
+    │               │
+    │               {fun}.
+Expression has type:   {fun((dynamic()) -> dynamic())}
+Context expected type: fun(('a') -> 'b') | fun(('a') -> 'c')
+
+See https://fb.me/eqwalizer_errors#incompatible_types
+    │               
+
+expected union does not contain any tuple type of size 1
+
 error: incompatible_types
     ┌─ check/src/overloaded.erl:141:5
     │
@@ -82,6 +116,23 @@ error: reference_to_invalid_type
 
 See https://fb.me/eqwalizer_errors#reference_to_invalid_type
 
+error: incompatible_types
+    ┌─ check/src/overloaded.erl:269:14
+    │
+269 │     _ = swap(""),
+    │              ^^
+    │              │
+    │              string_lit.
+Expression has type:   []
+Context expected type: atom() | binary()
+
+See https://fb.me/eqwalizer_errors#incompatible_types
+    │              
+
+  [] is not compatible with atom() | binary()
+  because
+  [] is not compatible with atom()
+
 error: incompatible_types
     ┌─ check/src/overloaded.erl:290:5
     │
@@ -102,4 +153,4 @@ Context expected type: 'a'
 
 See https://fb.me/eqwalizer_errors#incompatible_types
 
-10 ERRORS
+13 ERRORS

crates/elp/src/resources/test/eqwalizer_tests/options/overloaded_specs_union.pretty renamed to crates/elp/src/resources/test/eqwalizer_tests/check/overloaded_specs_union.pretty

@@ -1,5 +1,5 @@
 error: incompatible_types
-   ┌─ options/src/overloaded_specs_union.erl:16:29
+   ┌─ check/src/overloaded_specs_union.erl:16:29
    │
 16 │ use_over_neg_1(Arg) -> over(Arg).
    │                             ^^^
@@ -16,7 +16,7 @@ See https://fb.me/eqwalizer_errors#incompatible_types
   pid() is not compatible with atom()
 
 error: incompatible_types
-   ┌─ options/src/overloaded_specs_union.erl:19:29
+   ┌─ check/src/overloaded_specs_union.erl:19:29
    │
 19 │ use_over_neg_2(Arg) -> over(Arg).
    │                             ^^^

crates/elp/src/resources/test/eqwalizer_tests/check_gradual/gradual_overloaded.pretty

@@ -49,4 +49,14 @@ Context expected type: number()
 
 See https://fb.me/eqwalizer_errors#incompatible_types
 
-5 ERRORS
+error: incompatible_types
+    ┌─ check_gradual/src/gradual_overloaded.erl:128:19
+    │
+128 │         fun(I) -> I + 1 end,
+    │                   ^ I.
+Expression has type:   #r{}
+Context expected type: number()
+
+See https://fb.me/eqwalizer_errors#incompatible_types
+
+6 ERRORS

crates/eqwalizer/src/lib.rs

@@ -69,7 +69,6 @@ pub struct EqwalizerConfig {
     pub occurrence_typing: Option<bool>,
     pub clause_coverage: Option<bool>,
     pub report_bad_maps: Option<bool>,
-    pub overloaded_spec_domain_check: Option<bool>,
     pub overloaded_spec_dynamic_result: Option<bool>,
     pub report_dynamic_lambdas: Option<bool>,
 }
@@ -83,8 +82,6 @@ impl EqwalizerConfig {
             .map(|cfg| cmd.env("EQWALIZER_CLAUSE_COVERAGE", cfg.to_string()));
         self.report_bad_maps
             .map(|cfg| cmd.env("EQWALIZER_REPORT_BAD_MAPS", cfg.to_string()));
-        self.overloaded_spec_domain_check
-            .map(|cfg| cmd.env("EQWALIZER_OVERLOADED_SPEC_DOMAIN_CHECK", cfg.to_string()));
         self.overloaded_spec_dynamic_result
             .map(|cfg| cmd.env("EQWALIZER_OVERLOADED_SPEC_DYNAMIC_RESULT", cfg.to_string()));
         self.report_dynamic_lambdas
@@ -97,7 +94,6 @@ impl EqwalizerConfig {
             occurrence_typing: Some(true),
             clause_coverage: Some(false),
             report_bad_maps: Some(false),
-            overloaded_spec_domain_check: Some(false),
             overloaded_spec_dynamic_result: Some(false),
             report_dynamic_lambdas: Some(false),
         }

test_projects/eqwalizer_tests/check/src/overloaded.erl

@@ -112,17 +112,17 @@ test_bar3(F) ->
     Res = bar(F),
     Res.
 
--spec test_bar4(fun((a) -> z)) -> z.
-test_bar4(F) ->
+-spec test_bar4_neg(fun((a) -> z)) -> z.
+test_bar4_neg(F) ->
     Res = bar(F),
     Res.
 
 -spec inner_bar({fun((a) -> b)}) -> b;
     ({fun((a) -> c)}) -> c.
 inner_bar(_) -> throw(err).
 
--spec test_inner_bar() -> b.
-test_inner_bar() ->
+-spec test_inner_bar_neg() -> b.
+test_inner_bar_neg() ->
     Res = bar({fun(a) -> a end}),
     Res.
 

test_projects/eqwalizer_tests/options/src/overloaded_specs_union.erl renamed to test_projects/eqwalizer_tests/check/src/overloaded_specs_union.erl

@@ -121,10 +121,9 @@ rec_each3_neg(Rec) ->
         Rec
     ).
 
-% optimistically assuming dynamic()
--spec rec_each4
+-spec rec_each4_neg
     (#r{} | [#r{}]) -> atom().
-rec_each4(Rec) ->
+rec_each4_neg(Rec) ->
     rec_each(
         fun(I) -> I + 1 end,
         Rec