Skip to content

CSV Upload "Succeeds" when no result UUID's are valid and nothing is uploaded #739

@SRGDamia1

Description

@SRGDamia1

In a file with a malformed result UUID header, no valid result UUID's are found. But a successful upload message is still returned because not-valid UUIDs are simply ignored:

for sensor in sensors:
uuid = str(sensor.result_uuid)
if uuid not in results_mapping["results"]:
# TODO - consider revised approach where we loop over column in CSV and not all sensors
# this would allow us to return warning that result uuid is not recognized.
continue

This is very confusing to the user when a success message appears but no data is uploaded. A warning message should appear for each column that doesn't have a valid UUID and a failure message should appear if no data at all is accepted.

In the file screenshot below which triggered the problem, the colon is missing in the Result UUID: header.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions