-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
In a file with a malformed result UUID header, no valid result UUID's are found. But a successful upload message is still returned because not-valid UUIDs are simply ignored:
monitor-my-watershed/src/dataloaderservices/views.py
Lines 352 to 357 in fff01cd
| for sensor in sensors: | |
| uuid = str(sensor.result_uuid) | |
| if uuid not in results_mapping["results"]: | |
| # TODO - consider revised approach where we loop over column in CSV and not all sensors | |
| # this would allow us to return warning that result uuid is not recognized. | |
| continue |
This is very confusing to the user when a success message appears but no data is uploaded. A warning message should appear for each column that doesn't have a valid UUID and a failure message should appear if no data at all is accepted.
In the file screenshot below which triggered the problem, the colon is missing in the Result UUID: header.
Metadata
Metadata
Assignees
Labels
No labels
