Merge pull request #16 from Wikia/PLATFORM-10862-fix-dpl-blank-page

adpaste · web-flow · commit 09becf1e369f · 2025-03-25T10:56:14.000+01:00
Fix Heading's attribute setters (hlistattr, hitemattr may be null)
diff --git a/includes/Heading/Heading.php b/includes/Heading/Heading.php
@@ -131,19 +131,19 @@ public function getParameters() {
 	/**
 	 * Set extra list attributes.
 	 *
-	 * @param string $attributes
+	 * @param ?string $attributes
 	 */
 	public function setListAttributes( $attributes ) {
-		$this->listAttributes = Sanitizer::fixTagAttributes( $attributes, 'ul' );
+		$this->listAttributes = Sanitizer::fixTagAttributes( $attributes ?: '', 'ul' );
 	}
 
 	/**
 	 * Set extra item attributes.
 	 *
-	 * @param string $attributes
+	 * @param ?string $attributes
 	 */
 	public function setItemAttributes( $attributes ) {
-		$this->itemAttributes = Sanitizer::fixTagAttributes( $attributes, 'li' );
+		$this->itemAttributes = Sanitizer::fixTagAttributes( $attributes ?: '', 'li' );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -131,19 +131,19 @@ public function getParameters() {`
`131`	`131`	`/**`
`132`	`132`	`* Set extra list attributes.`
`133`	`133`	`*`
`134`		`- * @param string $attributes`
	`134`	`+ * @param ?string $attributes`
`135`	`135`	`*/`
`136`	`136`	`public function setListAttributes( $attributes ) {`
`137`		`- $this->listAttributes = Sanitizer::fixTagAttributes( $attributes, 'ul' );`
	`137`	`+ $this->listAttributes = Sanitizer::fixTagAttributes( $attributes ?: '', 'ul' );`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`/**`
`141`	`141`	`* Set extra item attributes.`
`142`	`142`	`*`
`143`		`- * @param string $attributes`
	`143`	`+ * @param ?string $attributes`
`144`	`144`	`*/`
`145`	`145`	`public function setItemAttributes( $attributes ) {`
`146`		`- $this->itemAttributes = Sanitizer::fixTagAttributes( $attributes, 'li' );`
	`146`	`+ $this->itemAttributes = Sanitizer::fixTagAttributes( $attributes ?: '', 'li' );`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`/**`