Skip to content

Commit ce3c7a2

Browse files
Merge pull request #1094 from WildGums/GitHubSync/20260911-142106
GitHubSync update
2 parents 21ffe05 + 5c117aa commit ce3c7a2

2 files changed

Lines changed: 22 additions & 21 deletions

File tree

.github/workflows/build.yml

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches:
66
- develop
7-
- master
87
workflow_dispatch:
98
inputs:
109
deploy:
@@ -28,7 +27,6 @@ jobs:
2827
AzureCodeSignClientSecret: ''
2928
AzureCodeSignTenantId: ''
3029
AzureCodeSignVaultName: ''
31-
CodeSignCertificateSubjectName: ''
3230
NuGetRepositoryUrl: ''
3331
NuGetUser: ''
3432
SonarOrganization: ''
@@ -163,7 +161,6 @@ jobs:
163161
@{ VariableName = 'AzureCodeSignTenantId'; MaskValue = $true }
164162
@{ VariableName = 'AzureCodeSignClientId'; MaskValue = $true }
165163
@{ VariableName = 'AzureCodeSignClientSecret'; MaskValue = $true }
166-
@{ VariableName = 'CodeSignCertificateSubjectName'; MaskValue = $false }
167164
@{ VariableName = 'NuGetRepositoryUrl'; MaskValue = $false }
168165
@{ VariableName = 'NuGetUser'; MaskValue = $true }
169166
@{ VariableName = 'SonarOrganization'; MaskValue = $false }
@@ -200,11 +197,11 @@ jobs:
200197
with:
201198
target: 'BuildAndTest'
202199
arguments: |
203-
IsCiBuild: "true"
204-
SonarOrganization: "${{ env.SonarOrganization }}"
205-
SonarUrl: "${{ env.SonarUrl }}"
206-
SonarProject: "${{ github.repository_owner }}_${{ github.event.repository.name }}"
207-
SonarToken: "${{ env.SonarToken }}"
200+
IsCiBuild: true
201+
SonarOrganization: ${{ env.SonarOrganization }}
202+
SonarUrl: ${{ env.SonarUrl }}
203+
SonarProject: ${{ github.repository_owner }}_${{ github.event.repository.name }}
204+
SonarToken: ${{ env.SonarToken }}
208205
209206
# Build & deploy
210207
- name: Build and deploy via Cake
@@ -214,16 +211,15 @@ jobs:
214211
with:
215212
target: 'BuildAndDeploy'
216213
arguments: |
217-
AzureCodeSignCertificateName: "${{ env.AzureCodeSignCertificateName }}"
218-
AzureCodeSignClientId: "${{ env.AzureCodeSignClientId }}"
219-
AzureCodeSignClientSecret: "${{ env.AzureCodeSignClientSecret }}"
220-
AzureCodeSignTenantId: "${{ env.AzureCodeSignTenantId }}"
221-
AzureCodeSignVaultName: "${{ env.AzureCodeSignVaultName }}"
222-
CodeSignCertificateSubjectName: "${{ env.CodeSignCertificateSubjectName }}"
223-
IsCiBuild: "false"
224-
NuGetRepositoryUrl: "${{ env.NuGetRepositoryUrl }}"
225-
NuGetRepositoryApiKey: "${{steps.nuget-login.outputs.NUGET_API_KEY}}"
226-
SonarOrganization: "${{ env.SonarOrganization }}"
227-
SonarUrl: "${{ env.SonarUrl }}"
228-
SonarProject: "${{ github.repository_owner }}_${{ github.event.repository.name }}"
229-
SonarToken: "${{ env.SonarToken }}"
214+
AzureCodeSignCertificateName: ${{ env.AzureCodeSignCertificateName }}
215+
AzureCodeSignClientId: ${{ env.AzureCodeSignClientId }}
216+
AzureCodeSignClientSecret: ${{ env.AzureCodeSignClientSecret }}
217+
AzureCodeSignTenantId: ${{ env.AzureCodeSignTenantId }}
218+
AzureCodeSignVaultName: ${{ env.AzureCodeSignVaultName }}
219+
IsCiBuild: false
220+
NuGetRepositoryUrl: ${{ env.NuGetRepositoryUrl }}
221+
NuGetRepositoryApiKey: ${{ steps.nuget-login.outputs.NUGET_API_KEY }}
222+
SonarOrganization: ${{ env.SonarOrganization }}
223+
SonarUrl: ${{ env.SonarUrl }}
224+
SonarProject: ${{ github.repository_owner }}_${{ github.event.repository.name }}
225+
SonarToken: ${{ env.SonarToken }}

src/Directory.Build.shared.implicit.props

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@
1818
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
1919
</PropertyGroup>
2020

21+
<!-- NuGet package restore lock files -->
22+
<PropertyGroup Label="RepositoryTemplate.Implicit.Configuration.NuGet.LockFiles">
23+
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
24+
</PropertyGroup>
25+
2126
<!-- Workaround for binding redirects in non exe assemblies, see https://github.com/Microsoft/msbuild/issues/1310#issuecomment-309596435 -->
2227
<Target Name="ForceGenerationOfBindingRedirects"
2328
AfterTargets="ResolveAssemblyReferences"

0 commit comments

Comments
 (0)