Release Version Auto-Bump #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkirkl for visibility |
holmbergius
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Looks good to me. Asking @tsubramanian to also review as our DevOps/MLOps wizard.
naknomum
reviewed
Jan 14, 2025
| @@ -19,6 +19,15 @@ jobs: | |||
| distribution: 'zulu' | |||
| java-version: 8 | |||
|
|
|||
| - name: Relase | |||
There was a problem hiding this comment.
is this a typo? likely doesnt matter but thought i should mention. @Rodhlann
There was a problem hiding this comment.
It definitely is! Thanks for the heads up
|
Are we talking about the Zulu distribution of Java? If so, many folks use
Zulu OpenJDK in git build because Oracle previously spread news caused
confusion in developer forums about the cancellation of their free JDK
license, I am not sure about the state now. I use Zulu based Java build as
it is completely free for production use and 100% compatible with Oracle
JDK.
…On Tue, Jan 14, 2025 at 6:59 PM Tim Pepper ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/release-maven-publish.yml
<#948 (comment)>:
> @@ -19,6 +19,15 @@ jobs:
distribution: 'zulu'
java-version: 8
+ - name: Relase
It definitely is! Thanks for the heads up
—
Reply to this email directly, view it on GitHub
<#948 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA46NWBZDSI2DRHVTVG4KMT2KWQG3AVCNFSM6AAAAABTZBFIE6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJRGI3TQNZUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It looks like this is the distro the job is already using, and I'd missed that! Just updated, I believe it should be correct now |
|
testing through live release of the PR, but opening issue until testing confirmed (determined in meeting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config for auto-incrementing project version on release, following suggested https://github.com/qcastel/github-actions-maven-release setup
PR fixes #594
Changes: