You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CLAUDE.md
+56-17Lines changed: 56 additions & 17 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,26 +23,65 @@ When asked to push code, follow this full workflow:
23
23
0. ensure that you are on a branch that is specific to this change i.e feat/new-feature or fix/bug-fix or docs/update-readme or chore/update-dependencies, or test/new-test, etc
24
24
1. Push the branch to the remote (`git push -u origin <branch>`)
25
25
2. Create a PR using `gh pr create`. Ensure that you are adhering to the PR template. **Do NOT include "Generated with Claude Code" or any AI attribution in PR descriptions.**
26
-
3. Wait for Gemini to review the PR (poll with `gh pr checks` and `gh api repos/{owner}/{repo}/pulls/{number}/reviews` until a review appears)
27
-
4. Once a review exists, pull down the review comments: `gh api repos/{owner}/{repo}/pulls/{number}/comments` and `gh api repos/{owner}/{repo}/pulls/{number}/reviews`
28
-
5. Address every review comment — fix the code, re-run the quality gates (tests, lint, tsc). Resolve the comment appropriately and post that on the PR directly.
29
-
6. Push the fixes
30
-
7. Report what was changed in response to the review
26
+
3. Wait for GitHub Actions CI to start. Poll with `gh pr checks {number}` (or `gh pr checks` from the PR's branch) until all four jobs (`typecheck`, `test`, `lint`, `android-build`) report a status. If any fail, fix and re-push before reading reviewer comments.
27
+
4. Once CI is green, wait for Gemini to post (`gh api repos/{owner}/{repo}/pulls/{number}/comments` + `.../reviews`).
28
+
5. Address every Gemini review comment — fix the code, or reply on the thread explaining why it's fine. Resolve the conversation either way.
29
+
6. Push the fixes; pre-commit gates re-run. Comment `/gemini review` to re-trigger Gemini.
30
+
7. Loop until CI is green and Gemini has nothing blocking.
31
+
8. Report what was changed in response to the review.
31
32
32
33
## CI Review Loop
33
34
34
-
The repo has three automated reviewers on every PR. After pushing, loop until all are green:
35
+
After pushing, loop until everything below is green or addressed.
35
36
36
-
| Reviewer | What it checks | How to address |
37
-
|---|---|---|
38
-
|**Gemini Bot**| Code quality, style, logic issues | Read comments via `gh api`, fix code or reply explaining why it's fine, then comment `/gemini review` to trigger a fresh pass |
39
-
|**Codecov**| Test coverage thresholds | Add missing tests, ensure new code is covered. Check the Codecov report for uncovered lines |
40
-
|**SonarCloud**| Security hotspots, code smells, duplications, bugs | Fix flagged issues — especially security hotspots and duplications. Resolve quality gate failures before merging |
37
+
### GitHub Actions CI (merge-blocking)
38
+
39
+
The `CI` workflow runs four jobs on every push and PR targeting `main` or `wildlife-reid`:
40
+
41
+
| Job | What it checks |
42
+
|---|---|
43
+
|`typecheck`|`tsc --noEmit`|
44
+
|`test`| Jest unit + integration tests with coverage |
File substantive findings to `kb/wildlife-reid-mobile/outputs/reports/`.
80
+
81
+
### Human review (final gate)
82
+
83
+
Final approval required before merging into `wildlife-reid` or `main`.
84
+
85
+
### Not currently installed
86
+
87
+
Codecov and SonarCloud are referenced in some upstream docs but are **not** wired up on this fork. If reinstated later, document them here. CodeQL (free, one-click at `Settings → Code security`) is a reasonable alternative if SAST is desired.
0 commit comments