Skip to content

[Bug] Identical structures spawning closer to each other than their minimum separations. #9

@Easyidle123

Description

@Easyidle123

Legacy4J Version

1.8.7 (Legacy World Sizes v0.0.1)

Mod Loader Version

Fabric Loader 0.18.4

Bug/Glitch Occurrence Context

Loading a medium-sized world (or any limited world) and locating a biome-dependent structure.

Crash Report

No response

What happened wrong?

Two or three of the same of desert temples, jungle temples, or pillager outposts get clumped together very regularly, more often than not in my testing. It seems to be the structure generation is not respecting the minimum separation value. These structures can spawn in adjacent chunks, so even though the mod reduces the separation value, that new value is likely still not respected. I've seen adjacent woodland mansions rarely as well. Best guess I have for the culprit from looking at the code is the spiral structure placement attempts.

Structures did generate adjacent to each other in Legacy Console Edition, but I feel this is still a bug as from my testing it's the vast majority of cases, and also breaks vanilla functionality with no way to disable it. If you use any world gen datapacks, the issue generally worsens as well. Some suggestions:

  • Some kind of fallback separation value under which a structure won't spawn (maybe half of what you make the shrunken ones)
  • A tweak that makes this case rarer without removing it, such as trying to continue down the spiral until it can find a value that achieves the separation, then giving up and spawning it anyway
  • A config to make the spiral structure search respect min separation value.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions