fix: preserve child creation context and portable coverage queries

Author: stefan-ernst

frontend/src/lib/dialogs/CreateModal.svelte

@@ -63,6 +63,7 @@
     compactMode = false,
     initialType = 'work-item',
     initialWorkspaceId = null,
+    initialParentContext = null,
     skipNavigate = false,
     onclose = null,
     oncreated = null
@@ -375,6 +376,15 @@
     }
   });
 
+  $effect(() => {
+    if (isOpen && initialParentContext) {
+      untrack(() => workItemFormStore.setParentItem(
+        initialParentContext.parent,
+        initialParentContext.allowedItemTypes,
+      ));
+    }
+  });
+
   // Force work-item type when compact mode is enabled
   $effect(() => {
     if (compactMode && selectedType !== 'work-item') {
@@ -509,7 +519,7 @@
           <ChevronRight size={14} style="color: var(--ds-text-subtle);" />
         {/if}
 
-        <span class="font-medium" style="color: var(--ds-text);">
+        <span data-testid="create-modal-heading" class="font-medium" style="color: var(--ds-text);">
           {#if workItemFormStore.parentItem}
             {t('createModal.newChildItem')}
           {:else}

frontend/src/lib/features/items/ItemDetail.svelte

@@ -1180,48 +1180,24 @@ import NativeSelect from '../../components/NativeSelect.svelte';
     loadRecurrence();
   }
 
-  // Sub-issue creation function
   function startCreateSubIssue() {
     if (itemDetailStore.availableSubIssueTypes.length === 0) {
       showError(t('items.noSubIssueTypes'), t('items.cannotCreateChildItems'));
       return;
     }
 
-    // Set up for sub-issue creation and open the global create modal
-
-    // First, trigger loading the CreateModal component
-    window.dispatchEvent(new CustomEvent('show-create-modal'));
-
-    // Small delay to let the modal load, then configure it
-    setTimeout(() => {
-      // Set the type first
-      window.dispatchEvent(new CustomEvent('set-create-type', {
-        detail: { type: 'work-item' }
-      }));
-
-      // Set the parent
-      window.dispatchEvent(new CustomEvent('set-create-parent', {
-        detail: {
-          parentId: itemDetailStore.item.id,
-          parentTitle: itemDetailStore.item.title,
-          availableItemTypes: itemDetailStore.availableSubIssueTypes
-        }
-      }));
-
-      // Open the modal (this will load workspaces)
-      window.dispatchEvent(new CustomEvent('open-create-modal'));
-
-      // After modal is open and workspaces are loaded, set the workspace
-      setTimeout(() => {
-        window.dispatchEvent(new CustomEvent('set-create-workspace', {
-          detail: {
-            workspaceId: workspaceId,
-            workspaceName: itemDetailStore.workspace?.name
-          }
-        }));
-      }, 200);
-    }, 150);
+    window.dispatchEvent(new CustomEvent('show-create-modal', {
+      detail: {
+        type: 'work-item',
+        workspaceId,
+        parentContext: {
+          parent: { id: itemDetailStore.item.id, title: itemDetailStore.item.title },
+          allowedItemTypes: itemDetailStore.availableSubIssueTypes,
+        },
+      },
+    }));
   }
+
 </script>
 
 {#snippet contentSnippet()}

frontend/src/lib/features/items/ItemDetailDescription.svelte

@@ -211,6 +211,7 @@
     {/if}
     {#if availableSubIssueTypes.length > 0}
       <button
+        data-testid="item-create-child"
         class="action-btn inline-flex items-center gap-1.5 px-2 py-1.5 rounded text-xs transition-all"
         style="color: var(--ds-text-subtle);"
         onclick={() => oncreateSubIssue?.()}

frontend/src/lib/pages/MainApp.svelte

@@ -52,6 +52,7 @@
   let createModalInitialType = $state('work-item');
   let createModalSkipNavigate = $state(false);
   let createModalWorkspaceId = $state(null);
+  let createModalParentContext = $state(null);
   let showEmailVerificationBanner = $state(false);
   let mobileWorkspaceNavOpen = $state(false);
 
@@ -146,6 +147,7 @@
     createModalInitialType = 'work-item';
     createModalSkipNavigate = false;
     createModalWorkspaceId = null;
+    createModalParentContext = null;
   }
 
   function closeAllSidebarSurfaces() {
@@ -156,6 +158,7 @@
     createModalInitialType = 'work-item';
     createModalSkipNavigate = false;
     createModalWorkspaceId = null;
+    createModalParentContext = null;
   }
 
   function activateSidebarSurface(surface) {
@@ -192,6 +195,7 @@
   function showCreateDropdown() {
     closeAllSidebarSurfaces();
     createModalWorkspaceId = null;
+    createModalParentContext = null;
     const currentWorkspaceId = $currentRoute.params?.id;
     if (currentWorkspaceId && CREATE_MODAL_WORKSPACE_VIEWS.has($currentRoute.view)) {
       createModalWorkspaceId = Number.parseInt(currentWorkspaceId, 10);
@@ -204,6 +208,7 @@
     closeAllSidebarSurfaces();
     if (detail.type) createModalInitialType = detail.type;
     createModalSkipNavigate = detail.skipNavigate || false;
+    createModalParentContext = detail.parentContext ?? null;
     createModalWorkspaceId = detail.workspaceId
       ? Number.parseInt(String(detail.workspaceId), 10)
       : null;
@@ -404,6 +409,7 @@
   bind:showChatPanel
   {createModalInitialType}
   {createModalWorkspaceId}
+  {createModalParentContext}
   {createModalSkipNavigate}
   onclosecreate={closeCreateModal}
   onclosecommand={closeCommandPalette}

frontend/src/lib/pages/MainAppOverlays.svelte

@@ -17,6 +17,7 @@
     showChatPanel = $bindable(false),
     createModalInitialType = 'work-item',
     createModalWorkspaceId = null,
+    createModalParentContext = null,
     createModalSkipNavigate = false,
     onclosecreate,
     onclosecommand = () => {},
@@ -115,6 +116,7 @@
     bind:isOpen={showCreateModal}
     initialType={createModalInitialType}
     initialWorkspaceId={createModalWorkspaceId}
+    initialParentContext={createModalParentContext}
     skipNavigate={createModalSkipNavigate}
     onclose={onclosecreate}
   />

internal/repository/test_coverage_repository.go

@@ -268,19 +268,9 @@ func (r *TestCoverageRepository) CountRequirements(params RequirementListParams)
 		return 0, nil
 	}
 
-	whereClause, havingClause, args := buildRequirementFilters(params)
+	whereClause, args := buildRequirementFilters(params)
 
-	query := `
-		SELECT COUNT(*) FROM (
-			SELECT
-				i.id,
-				(` + coverageLinkedCountSubquery + `) as linked_count
-			FROM items i
-			` + whereClause + `
-			GROUP BY i.id
-			` + havingClause + `
-		) sub
-	`
+	query := `SELECT COUNT(*) FROM items i ` + whereClause
 
 	var total int
 	if err := r.db.QueryRow(query, args...).Scan(&total); err != nil {
@@ -295,7 +285,7 @@ func (r *TestCoverageRepository) ListRequirements(params RequirementListParams)
 		return []models.RequirementCoverageItem{}, nil
 	}
 
-	whereClause, havingClause, args := buildRequirementFilters(params)
+	whereClause, args := buildRequirementFilters(params)
 	args = append(args, params.Limit, params.Offset)
 
 	query := `
@@ -316,8 +306,6 @@ func (r *TestCoverageRepository) ListRequirements(params RequirementListParams)
 		JOIN item_types it ON i.item_type_id = it.id
 		LEFT JOIN statuses s ON i.status_id = s.id
 		` + whereClause + `
-		GROUP BY i.id
-		` + havingClause + `
 		ORDER BY i.created_at DESC
 		LIMIT ? OFFSET ?
 	`
@@ -413,7 +401,7 @@ func coverageWhereArgs(workspaceID int, typeIDs []int) (placeholders string, arg
 	return strings.Join(slots, ","), args
 }
 
-func buildRequirementFilters(params RequirementListParams) (where, having string, args []any) {
+func buildRequirementFilters(params RequirementListParams) (where string, args []any) {
 	placeholders, filterArgs := coverageWhereArgs(params.WorkspaceID, params.TypeIDs)
 	args = filterArgs
 	where = "WHERE i.workspace_id = ? AND i.item_type_id IN (" + placeholders + ")"
@@ -425,9 +413,9 @@ func buildRequirementFilters(params RequirementListParams) (where, having string
 
 	switch params.CoveredFilter {
 	case "true":
-		having = " HAVING linked_count > 0"
+		where += " AND (" + coverageLinkedCountSubquery + ") > 0"
 	case "false":
-		having = " HAVING linked_count = 0"
+		where += " AND (" + coverageLinkedCountSubquery + ") = 0"
 	}
-	return where, having, args
+	return where, args
 }