Full on linting work, everything reworked

Author: Stefan Ernst

.golangci.yml

@@ -22,11 +22,16 @@ linters:
   settings:
     errcheck:
       check-type-assertions: true
-      check-blank: true
+      check-blank: false
       exclude-functions:
         - (io.Closer).Close
         - (*os.File).Close
         - (net.Conn).Close
+        - (*database/sql.DB).Close
+        - (*database/sql.Tx).Rollback
+        - (*database/sql.Rows).Close
+        - (*database/sql.Result).LastInsertId
+        - (*database/sql.Result).RowsAffected
 
     govet:
       enable-all: true

cmd/ws/client.go

@@ -51,7 +51,7 @@ func (e *APIError) Error() string {
 }
 
 // doRequest executes an HTTP request with authentication
-func (c *Client) doRequest(method, path string, body interface{}, result interface{}) error {
+func (c *Client) doRequest(method, path string, body, result interface{}) error {
 	var bodyReader io.Reader
 	if body != nil {
 		jsonBody, err := json.Marshal(body)
@@ -75,7 +75,7 @@ func (c *Client) doRequest(method, path string, body interface{}, result interfa
 	if err != nil {
 		return fmt.Errorf("request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	respBody, err := io.ReadAll(resp.Body)
 	if err != nil {
@@ -105,12 +105,12 @@ func (c *Client) GET(path string, result interface{}) error {
 }
 
 // POST performs a POST request
-func (c *Client) POST(path string, body interface{}, result interface{}) error {
+func (c *Client) POST(path string, body, result interface{}) error {
 	return c.doRequest("POST", path, body, result)
 }
 
 // PUT performs a PUT request
-func (c *Client) PUT(path string, body interface{}, result interface{}) error {
+func (c *Client) PUT(path string, body, result interface{}) error {
 	return c.doRequest("PUT", path, body, result)
 }
 

cmd/ws/config.go

@@ -10,10 +10,10 @@ import (
 
 // Config represents the CLI configuration
 type Config struct {
-	Server        ServerConfig        `toml:"server"`
-	Defaults      DefaultsConfig      `toml:"defaults"`
-	Cache         CacheConfig         `toml:"cache"`
-	StatusAliases map[string]string   `toml:"status_aliases"`
+	Server        ServerConfig      `toml:"server"`
+	Defaults      DefaultsConfig    `toml:"defaults"`
+	Cache         CacheConfig       `toml:"cache"`
+	StatusAliases map[string]string `toml:"status_aliases"`
 }
 
 type ServerConfig struct {
@@ -107,27 +107,19 @@ func getGlobalConfigPath() string {
 	return filepath.Join(home, ".config", "ws", "config.toml")
 }
 
-func getGlobalCachePath() string {
-	home, err := os.UserHomeDir()
-	if err != nil {
-		return ""
-	}
-	return filepath.Join(home, ".cache", "ws")
-}
-
 func saveGlobalConfig(config Config) error {
 	path := getGlobalConfigPath()
 	dir := filepath.Dir(path)
 
-	if err := os.MkdirAll(dir, 0755); err != nil {
+	if err := os.MkdirAll(dir, 0o750); err != nil {
 		return fmt.Errorf("failed to create config directory: %w", err)
 	}
 
 	f, err := os.Create(path)
 	if err != nil {
 		return fmt.Errorf("failed to create config file: %w", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	encoder := toml.NewEncoder(f)
 	return encoder.Encode(config)
@@ -138,7 +130,7 @@ func saveProjectConfig(config Config, path string) error {
 	if err != nil {
 		return fmt.Errorf("failed to create config file: %w", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	encoder := toml.NewEncoder(f)
 	return encoder.Encode(config)

cmd/ws/config_cmd.go

@@ -40,7 +40,7 @@ Examples:
 		// Check if config already exists
 		if _, err := os.Stat(configPath); err == nil {
 			fmt.Printf("Config already exists at %s. Overwrite? [y/N]: ", configPath)
-			input, _ := reader.ReadString('\n')
+			input, _ := reader.ReadString('\n') //nolint:errcheck // interactive user input
 			input = strings.TrimSpace(strings.ToLower(input))
 			if input != "y" && input != "yes" {
 				fmt.Println("Aborted.")
@@ -50,17 +50,17 @@ Examples:
 
 		// Prompt for server URL
 		fmt.Print("Windshift server URL (e.g., https://windshift.example.com): ")
-		serverURL, _ := reader.ReadString('\n')
+		serverURL, _ = reader.ReadString('\n') //nolint:errcheck // interactive user input
 		serverURL = strings.TrimSpace(serverURL)
 
 		// Prompt for token
 		fmt.Print("API token (crw_...): ")
-		token, _ := reader.ReadString('\n')
+		token, _ = reader.ReadString('\n') //nolint:errcheck // interactive user input
 		token = strings.TrimSpace(token)
 
 		// Prompt for default workspace (optional)
 		fmt.Print("Default workspace key (optional, press Enter to skip): ")
-		workspaceKey, _ := reader.ReadString('\n')
+		workspaceKey, _ = reader.ReadString('\n') //nolint:errcheck // interactive user input
 		workspaceKey = strings.TrimSpace(workspaceKey)
 
 		newConfig := Config{

cmd/ws/init.go

@@ -83,7 +83,7 @@ Examples:
 		// Generate WINDSHIFT.md
 		content := generateWindshiftMD(workspace, statuses, itemTypes, transitions)
 
-		if err := os.WriteFile("WINDSHIFT.md", []byte(content), 0644); err != nil {
+		if err := os.WriteFile("WINDSHIFT.md", []byte(content), 0o600); err != nil {
 			return fmt.Errorf("failed to write WINDSHIFT.md: %w", err)
 		}
 		fmt.Println("Created WINDSHIFT.md")
@@ -304,7 +304,7 @@ func updateAgentsFile(filename string) {
 	// Append Windshift section
 	addition := "\n\n## Windshift Integration\n\nSee [WINDSHIFT.md](./WINDSHIFT.md) for task management commands.\n"
 
-	if err := os.WriteFile(filename, append(content, []byte(addition)...), 0644); err != nil {
+	if err := os.WriteFile(filename, append(content, []byte(addition)...), 0o600); err != nil {
 		fmt.Printf("Warning: Could not update %s: %s\n", filename, err)
 		return
 	}

cmd/ws/models.go

@@ -38,10 +38,10 @@ type User struct {
 }
 
 type UserSummary struct {
-	ID       int    `json:"id"`
-	Name     string `json:"name,omitempty"`
-	Email    string `json:"email,omitempty"`
-	Avatar   string `json:"avatar,omitempty"`
+	ID     int    `json:"id"`
+	Name   string `json:"name,omitempty"`
+	Email  string `json:"email,omitempty"`
+	Avatar string `json:"avatar,omitempty"`
 }
 
 // ============================================