fix: align item creation with API v2 contract

Author: stefan-ernst

frontend/src/lib/dialogs/CreateModal.svelte

@@ -229,10 +229,6 @@
         }
 
         let result = await api.items.create(formData);
-        if (formData.label_ids?.length > 0) {
-          const labels = await api.labels.setForItem(result.id, formData.label_ids);
-          result = { ...result, labels: labels || [] };
-        }
         const originalDescription = formData.description || '';
         const updatedDescription = await uploadPendingDescriptionImages(result.id, originalDescription);
         if (updatedDescription !== originalDescription) {

frontend/src/lib/features/collections/CollectionMap.svelte

@@ -417,13 +417,11 @@
     }
 
     try {
-      // Create the item
       const newItem = await api.items.create({
         workspace_id: state.workspaceId,
         item_type_id: state.itemTypeId,
         title: state.title.trim(),
         description: '',
-        priority: 'medium',
         parent_id: parentId
       });
 
@@ -768,6 +766,7 @@
                   <!-- Add Card button when there are existing items -->
                   {#if !quickAddState[backboneItem.id]?.show && childItemsByParent[backboneItem.id]?.length > 0 && canAddChildren(backboneItem.id)}
                     <button
+                      data-testid="map-add-card-{backboneItem.id}"
                       onclick={() => initQuickAdd(backboneItem.id)}
                       class="w-full flex items-center gap-2 px-3 py-2 text-sm font-medium rounded border-2 border-dashed transition-colors "
                       style="border-color: var(--ctx-border, var(--ds-border)); background-color: transparent; color: var(--ds-text-subtle);"
@@ -789,6 +788,7 @@
                   {#if !quickAddState[backboneItem.id]?.show && (!childItemsByParent[backboneItem.id] || childItemsByParent[backboneItem.id].length === 0)}
                     {#if canAddChildren(backboneItem.id)}
                       <button
+                        data-testid="map-add-card-{backboneItem.id}"
                         onclick={() => initQuickAdd(backboneItem.id)}
                         class="w-full flex items-center gap-2 px-3 py-2 text-sm font-medium rounded border-2 border-dashed transition-colors"
                         style="border-color: var(--ctx-border, var(--ds-border)); background-color: transparent; color: var(--ds-text-subtle);"

frontend/src/lib/features/collections/QuickAddForm.svelte

@@ -131,6 +131,7 @@
   <div class={compact ? 'p-3 pb-2' : ''}>
     <Textarea
       value={formState.title}
+      data-testid={`quick-add-title-${parentId}`}
       data-quick-add-parent={parentId}
       oninput={(e) => onUpdateField(parentId, 'title', e.currentTarget.value)}
       onkeydown={handleKeydown}

frontend/src/lib/mobile/MobileCreateDialog.svelte

@@ -596,6 +596,7 @@
           priority_id: priorityId || null,
           assignee_id: assigneeId || null,
           milestone_ids: Array.isArray(milestoneIds) ? milestoneIds : [],
+          label_ids: selectedLabelIds(),
           iteration_id: iterationId || null,
           project_id: projectId || null,
           due_date: dateInputToISOString(dueDate),
@@ -618,9 +619,6 @@
       if (!isPersonal && !validateConfiguredFields()) return;
 
       const result = await api.items.create(createPayload());
-      if (!isPersonal && selectedLabelIds().length > 0) {
-        await api.labels.setForItem(result.id, selectedLabelIds());
-      }
       if (isPersonal) {
         // The newly created personal task lives in this tab's list - let the
         // active Personal view refresh itself. BroadcastChannel excludes the

internal/restapi/v2/items.go

@@ -45,6 +45,7 @@ type itemCreateRequest struct {
 	EstimateMinutes   *int           `json:"estimate_minutes"`
 	CustomFieldValues map[string]any `json:"custom_field_values"`
 	MilestoneIDs      []int          `json:"milestone_ids"`
+	LabelIDs          []int          `json:"label_ids"`
 }
 
 type itemPatchRequest struct {
@@ -131,7 +132,7 @@ func registerItemRoutes(builder *routeBuilder, app *services.ItemApplicationServ
 			AssigneeID: input.AssigneeID, ParentID: input.ParentID,
 			RelatedWorkItemID: input.RelatedWorkItemID, StoryPoints: input.StoryPoints,
 			EstimateMinutes: input.EstimateMinutes, CustomFieldValues: input.CustomFieldValues,
-			MilestoneIDs: input.MilestoneIDs,
+			MilestoneIDs: input.MilestoneIDs, LabelIDs: input.LabelIDs,
 		})
 		return result, itemError(err)
 	})

internal/services/item_creation.go

@@ -57,6 +57,14 @@ func (c *itemCreation) validateAssignments() error {
 	if err := validation.ValidatePlanningAssignments(c.db, params.WorkspaceID, params.MilestoneIDs, params.IterationID); err != nil {
 		return err
 	}
+	labels := repository.NewLabelRepository(c.db)
+	for _, labelID := range params.LabelIDs {
+		if _, err := labels.GetByID(labelID); errors.Is(err, repository.ErrNotFound) {
+			return &validation.ValidationError{Field: "label_ids", Message: fmt.Sprintf("Label %d not found", labelID)}
+		} else if err != nil {
+			return fmt.Errorf("validate label %d: %w", labelID, err)
+		}
+	}
 	if params.ValidatingUserID > 0 && params.AssigneeID != nil {
 		actionable, err := c.assigneeCanAct()
 		if err != nil {
@@ -275,6 +283,11 @@ func (c *itemCreation) extendTransaction(tx database.Tx, itemID int) error {
 			return fmt.Errorf("failed to attach milestone %d to new item: %w", milestoneID, err)
 		}
 	}
+	if len(c.params.LabelIDs) > 0 {
+		if err := repository.NewLabelRepository(c.db).ReplaceItemLabelsTx(c.ctx, tx, itemID, c.params.LabelIDs); err != nil {
+			return err
+		}
+	}
 	if c.params.AfterCreate != nil {
 		return c.params.AfterCreate(c.ctx, tx, itemID)
 	}

internal/services/item_creation_service.go

@@ -45,6 +45,7 @@ type ItemCreateInput struct {
 	EstimateMinutes   *int
 	CustomFieldValues map[string]any
 	MilestoneIDs      []int
+	LabelIDs          []int
 }
 
 // ItemCreateResult contains the committed item and mandatory-template detail
@@ -156,6 +157,7 @@ func (s *ItemCreationService) create(
 		IsTask:                input.IsTask,
 		ParentID:              input.ParentID,
 		MilestoneIDs:          input.MilestoneIDs,
+		LabelIDs:              input.LabelIDs,
 		IterationID:           input.IterationID,
 		ProjectID:             input.ProjectID,
 		InheritProject:        input.InheritProject,

internal/services/items.go

@@ -93,6 +93,7 @@ type ItemCreationParams struct {
 	IsTask                  bool
 	ParentID                *int
 	MilestoneIDs            []int
+	LabelIDs                []int
 	IterationID             *int
 	ProjectID               *int
 	InheritProject          bool