Trying to fix golang ci errors

Author: Stefan Ernst

.golangci.yml

@@ -1,92 +1,100 @@
+version: "2"
+
 run:
   timeout: 5m
   tests: false
 
 linters:
   enable:
     - errcheck       # Check for unchecked errors
-    - gosimple       # Simplify code
     - govet          # Report suspicious constructs
     - ineffassign    # Detect ineffective assignments
-    - staticcheck    # Go static analysis
+    - staticcheck    # Go static analysis (includes gosimple)
     - unused         # Find unused code
-    - gofmt          # Check formatting
     - misspell       # Fix spelling errors
-    - goimports      # Manage imports
     - gocritic       # Opinionated linter
     - gosec          # Security checks
     - prealloc       # Slice preallocation hints
     - unconvert      # Remove unnecessary conversions
     - unparam        # Find unused function parameters
     - nilerr         # Check for nil error returns
 
-linters-settings:
-  errcheck:
-    check-type-assertions: true
-    check-blank: true
-    exclude-functions:
-      - (io.Closer).Close
-      - (*os.File).Close
-      - (net.Conn).Close
-
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment  # Too noisy for now
-
-  staticcheck:
-    checks: ["all"]
-
-  gosec:
-    excludes:
-      - G104  # Audit errors not checked (handled by errcheck)
-      - G304  # File path provided as taint input (often intentional)
-
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - performance
-      - style
-    disabled-checks:
-      - hugeParam  # Too strict for typical structs
-      - rangeValCopy  # Often not worth micro-optimizing
-
-  misspell:
-    locale: US
-
-  goimports:
-    local-prefixes: windshift
-
-issues:
-  exclude-use-default: false
-  max-issues-per-linter: 50
-  max-same-issues: 10
-
-  exclude-rules:
-    # Ignore long lines in generated files
-    - path: _gen\.go
-      linters:
-        - lll
-
-    # Allow unused parameters in main package
-    - path: main\.go
-      linters:
-        - unparam
-
-    # Ignore magic numbers in tests
-    - path: _test\.go
-      linters:
-        - gomnd
-
-    # Allow dot imports in tests
-    - path: _test\.go
-      linters:
-        - revive
-      text: "dot-imports"
+  settings:
+    errcheck:
+      check-type-assertions: true
+      check-blank: true
+      exclude-functions:
+        - (io.Closer).Close
+        - (*os.File).Close
+        - (net.Conn).Close
+
+    govet:
+      enable-all: true
+      disable:
+        - fieldalignment  # Too noisy for now
+
+    staticcheck:
+      checks: ["all"]
+
+    gosec:
+      excludes:
+        - G104  # Audit errors not checked (handled by errcheck)
+        - G304  # File path provided as taint input (often intentional)
+
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - performance
+        - style
+      disabled-checks:
+        - hugeParam  # Too strict for typical structs
+        - rangeValCopy  # Often not worth micro-optimizing
+
+    misspell:
+      locale: US
+
+  exclusions:
+    generated: lax
+    presets: []
+    max-issues-per-linter: 50
+    max-same-issues: 10
+
+    rules:
+      # Ignore long lines in generated files
+      - path: _gen\.go
+        linters:
+          - lll
+
+      # Allow unused parameters in main package
+      - path: main\.go
+        linters:
+          - unparam
+
+      # Ignore magic numbers in tests
+      - path: _test\.go
+        linters:
+          - mnd
+
+      # Allow dot imports in tests
+      - path: _test\.go
+        linters:
+          - revive
+        text: "dot-imports"
+
+formatters:
+  enable:
+    - gofmt          # Check formatting
+    - goimports      # Manage imports
+
+  settings:
+    goimports:
+      local-prefixes: windshift
 
 output:
   formats:
-    - format: colored-line-number
-  print-issued-lines: true
-  print-linter-name: true
-  sort-results: true
+    text:
+      colors: true
+      print-issued-lines: true
+      print-linter-name: true
+  sort-order:
+    - file