Skip to content

Keep pyright strict without broad MaaFramework suppressions - #2

Closed
a16797 wants to merge 1 commit into
Windsland52:mainfrom
a16797:codex/strict-maafw-types
Closed

Keep pyright strict without broad MaaFramework suppressions#2
a16797 wants to merge 1 commit into
Windsland52:mainfrom
a16797:codex/strict-maafw-types

Conversation

@a16797

@a16797 a16797 commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • keep typeCheckingMode = strict enabled
  • remove broad pyright suppressions for reportUnknown* and reportMissingTypeArgument
  • keep only reportMissingTypeStubs = none for MaaFramework (MaaFw, imported as maa), matching MaaFramework's own Python binding pyright config
  • fix the project JSON, settings, measurement-state, and custom action type boundaries exposed by strict mode

Validation

  • uv run pyright
  • uv run ruff check
  • uv run pytest

sourcery-ai[bot]
sourcery-ai Bot reviewed Jun 30, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @a16797, your pull request is larger than the review limit of 150000 diff characters

@Windsland52 Windsland52 closed this Jul 1, 2026
@a16797 a16797 changed the title [codex] keep pyright strict with MaaFW types Keep pyright strict without broad MaaFramework suppressions Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a16797 @Windsland52