Skip to content
This repository was archived by the owner on Dec 27, 2019. It is now read-only.

Commit 972a910

Browse files
committed
allowedips: change from BUG_ON to WARN_ON
This is never going to hit anyway, and if it does, it's a development problem that will be caught with the selftests anyway. So don't make Andrew Lunn upset, and just change it to a WARN_ON. Suggested-by: Andrew Lunn <andrew@lunn.ch>
1 parent fab1010 commit 972a910

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/allowedips.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ static void node_free_rcu(struct rcu_head *rcu)
5050

5151
#define push_rcu(stack, p, len) ({ \
5252
if (rcu_access_pointer(p)) { \
53-
BUG_ON(len >= 128); \
53+
WARN_ON(len >= 128); \
5454
stack[len++] = rcu_dereference_raw(p); \
5555
} \
5656
true; \
@@ -109,7 +109,7 @@ walk_by_peer(struct allowedips_node __rcu *top, u8 bits,
109109
#define ref(p) rcu_access_pointer(p)
110110
#define deref(p) rcu_dereference_protected(*p, lockdep_is_held(lock))
111111
#define push(p) ({ \
112-
BUG_ON(len >= 128); \
112+
WARN_ON(len >= 128); \
113113
stack[len++] = p; \
114114
})
115115
static void walk_remove_by_peer(struct allowedips_node __rcu **top,

0 commit comments

Comments
 (0)