correction project

Author: WisdomQuest

bin/brain-even.js

@@ -1,4 +1,4 @@
 #!/usr/bin/env node
-import evenGame from '../src/games/cliEven.js';
+import evenGame from '../src/games/even.js';
 
 evenGame();

eslint.config.js

@@ -52,28 +52,6 @@ export default [
       'import/no-named-as-default-member': 'off',
       'no-console': 'off',
       'import/no-extraneous-dependencies': 'off',
-      // 'linebreak-style': ['error', 'windows'],
     },
   },
 ];
-
-/*
-import globals from "globals";
-
-import path from "path";
-import { fileURLToPath } from "url";
-import { FlatCompat } from "@eslint/eslintrc";
-import pluginJs from "@eslint/js";
-
-// mimic CommonJS variables -- not needed if using CommonJS
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const compat = new FlatCompat({
-baseDirectory: __dirname, recommendedConfig: pluginJs.configs.recommended
-});
-
-export default [
-  {languageOptions: { globals: globals.browser }},
-  ...compat.extends("airbnb"),
-];
-*/

src/games/calc.js

@@ -5,12 +5,12 @@ const descriptionGame = 'What is the result of the expression?';
 
 const actionGame = () => {
   const sign = ['+', '-', '*'];
-  const randomSiqn = sign[randomNumber(3)];
-  const num1 = randomNumber();
-  const num2 = randomNumber();
+  const randomSign = sign[randomNumber(0, sign.length)];
+  const num1 = randomNumber(0, 100);
+  const num2 = randomNumber(0, 100);
   let correctAnswer = '';
-  const questionMath = `${num1} ${randomSiqn} ${num2}`;
-  switch (randomSiqn) {
+  const questionMath = `${num1} ${randomSign} ${num2}`;
+  switch (randomSign) {
     case '+':
       correctAnswer = num1 + num2;
       break;
@@ -25,8 +25,6 @@ const actionGame = () => {
   return [questionMath, String(correctAnswer)];
 };
 
-const calcGame = () => {
-  roundGame(actionGame, descriptionGame);
-};
+const calcGame = () => roundGame(actionGame, descriptionGame);
 
 export default calcGame;

src/games/cliEven.js renamed to src/games/even.js

@@ -4,15 +4,13 @@ import randomNumber from '../utilRandomNumber.js';
 const descriptionGame = 'Answer "yes" if the number is even, otherwise answer "no".';
 
 const actionGame = () => {
-  const questNumber = randomNumber();
+  const questNumber = randomNumber(0, 100);
   const isEvenNum = questNumber % 2 === 0;
   const correctAnswer = isEvenNum ? 'yes' : 'no';
 
   return [questNumber, correctAnswer];
 };
 
-const evenGame = () => {
-  roundGame(actionGame, descriptionGame);
-};
+const evenGame = () => roundGame(actionGame, descriptionGame);
 
 export default evenGame;

src/games/gcd.js

@@ -3,23 +3,28 @@ import randomNumber from '../utilRandomNumber.js';
 
 const descriptionGame = 'Find the greatest common divisor of given numbers.';
 
-const actionGame = () => {
-  let num1 = randomNumber();
-  let num2 = randomNumber();
-  const questionExample = `${num1} ${num2}`;
-  while (num1 !== 0 && num2 !== 0) {
-    if (num1 > num2) {
-      num1 %= num2;
+const gcd = (num1, num2) => {
+  let number1 = num1;
+  let number2 = num2;
+  while (number1 !== 0 && number2 !== 0) {
+    if (number1 > number2) {
+      number1 %= number2;
     } else {
-      num2 %= num1;
+      number2 %= number1;
     }
   }
-  const correctAnswer = num1 + num2;
-  return [questionExample, String(correctAnswer)];
+  return number1 + number2;
 };
 
-const gcdGame = () => {
-  roundGame(actionGame, descriptionGame);
+const actionGame = () => {
+  const num1 = randomNumber(1, 100);
+  const num2 = randomNumber(1, 100);
+  const questionExample = `${num1} ${num2}`;
+  const correctAnswer = gcd(num1, num2);
+
+  return [questionExample, String(correctAnswer)];
 };
 
+const gcdGame = () => roundGame(actionGame, descriptionGame);
+
 export default gcdGame;

src/games/prime.js

@@ -3,22 +3,26 @@ import randomNumber from '../utilRandomNumber.js';
 
 const descriptionGame = 'Answer "yes" if given number is prime. Otherwise answer "no".';
 
-const actionGame = () => {
-  const questionNum = randomNumber();
+const prime = (num) => {
   let correctAnswer = 'yes';
-  for (let i = 2; i < Math.sqrt(questionNum); i += 1) {
-    if (questionNum % i === 0) {
+  for (let i = 2; i < Math.sqrt(num); i += 1) {
+    if (num % i === 0) {
       correctAnswer = 'no';
     }
   }
-  if (questionNum === 0) {
+  if (num < 2) {
     correctAnswer = 'no';
   }
-  return [questionNum, correctAnswer];
+
+  return correctAnswer;
 };
 
-const primeGame = () => {
-  roundGame(actionGame, descriptionGame);
+const actionGame = () => {
+  const questionNum = randomNumber(0, 100);
+  const correctAnswer = prime(questionNum);
+  return [questionNum, correctAnswer];
 };
 
+const primeGame = () => roundGame(actionGame, descriptionGame);
+
 export default primeGame;

src/games/progression.js

@@ -3,22 +3,28 @@ import randomNumber from '../utilRandomNumber.js';
 
 const descriptionGame = 'What number is missing in the progression?';
 
-const actionGame = () => {
-  let randomNum = randomNumber();
-  const arithmeticProgression = randomNumber(5) + 1;
-  const progression = [randomNum];
-  for (let i = 0; i < 10; i += 1) {
-    randomNum += arithmeticProgression;
-    progression.push(randomNum);
+const generateProgression = (firstNumber, step, length) => {
+  let startNum = firstNumber;
+  const progression = [startNum];
+  for (let i = 0; i < length; i += 1) {
+    startNum += step;
+    progression.push(startNum);
   }
-  const hiddenNum = randomNumber(10);
+  return progression;
+};
+
+const actionGame = () => {
+  const firstNumber = randomNumber(0, 100);
+  const step = randomNumber(0, 5) + 1;
+  const length = randomNumber(10, 20);
+  const hiddenNum = randomNumber(10, length);
+  const progression = generateProgression(firstNumber, step, length);
   const correctAnswer = progression[hiddenNum];
   progression[hiddenNum] = '..';
   const question = progression.join(' ');
   return [question, String(correctAnswer)];
 };
 
-const progressionGame = () => {
-  roundGame(actionGame, descriptionGame);
-};
+const progressionGame = () => roundGame(actionGame, descriptionGame);
+
 export default progressionGame;

src/index.js

@@ -1,13 +1,13 @@
 import readlineSync from 'readline-sync';
 
-const maxWin = 3;
+const MaxWin = 3;
 
 const roundGame = (game, description) => {
   console.log('Welcome to the Brain Games!');
   const userName = readlineSync.question('May I have your name? ');
   console.log(`Hello, ${userName}!`);
   console.log(description);
-  for (let winCount = 0; winCount < maxWin; winCount += 1) {
+  for (let winCount = 0; winCount < MaxWin; winCount += 1) {
     const [question, correctAnswer] = game();
     console.log(`Question: ${question}`);
     const answer = readlineSync.question('Your answer: ');

src/utilRandomNumber.js

@@ -1,3 +1,3 @@
-const randomNumber = (maxRandomNumber = 100) => Math.floor(Math.random() * maxRandomNumber);
+const randomNumber = (min, max) => Math.floor(Math.random() * (max - min) + min);
 
 export default randomNumber;