fix code for eslint (attempt 3)

Author: WisdomQuest

__test__/diffFiles.test.js

@@ -7,11 +7,9 @@ import genDiff from '../src/formatters/index.js';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
-const getFixturePath = (filename) =>
-  path.join(__dirname, '..', '__fixtures__', filename);
+const getFixturePath = (filename) => path.join(__dirname, '..', '__fixtures__', filename);
 
-const readFile = (filename) =>
-  fs.readFileSync(getFixturePath(filename), 'utf-8');
+const readFile = (filename) => fs.readFileSync(getFixturePath(filename), 'utf-8');
 
 const expectFormatJson = readFile('expectDiffFormatJson.txt');
 const expectFormatPlain = readFile('expectDiffFormatPlain.txt');

coverage/lcov-report/block-navigation.js

@@ -1,24 +1,25 @@
-var jumpToCode = (function init() {
+/* eslint-disable */
+
+const jumpToCode = (function init() {
   // Classes of code we would like to highlight in the file view
-  var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
+  const missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
 
   // Elements to highlight in the file listing view
-  var fileListingElements = ['td.pct.low'];
+  const fileListingElements = ['td.pct.low'];
 
   // We don't want to select elements that are direct descendants of another match
-  var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > `
+  const notSelector = `:not(${missingCoverageClasses.join('):not(')}) > `; // becomes `:not(a):not(b) > `
 
   // Selecter that finds elements on the page to which we can jump
-  var selector =
-    fileListingElements.join(', ') +
-    ', ' +
-    notSelector +
-    missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
+  const selector = `${fileListingElements.join(', ')
+  }, ${
+    notSelector
+  }${missingCoverageClasses.join(`, ${notSelector}`)}`; // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
 
   // The NodeList of matching elements
-  var missingCoverageElements = document.querySelectorAll(selector);
+  const missingCoverageElements = document.querySelectorAll(selector);
 
-  var currentIndex;
+  let currentIndex;
 
   function toggleClass(index) {
     missingCoverageElements.item(currentIndex).classList.remove('highlighted');
@@ -36,7 +37,7 @@ var jumpToCode = (function init() {
   }
 
   function goToPrevious() {
-    var nextIndex = 0;
+    let nextIndex = 0;
     if (typeof currentIndex !== 'number' || currentIndex === 0) {
       nextIndex = missingCoverageElements.length - 1;
     } else if (missingCoverageElements.length > 1) {
@@ -47,11 +48,11 @@ var jumpToCode = (function init() {
   }
 
   function goToNext() {
-    var nextIndex = 0;
+    let nextIndex = 0;
 
     if (
-      typeof currentIndex === 'number' &&
-      currentIndex < missingCoverageElements.length - 1
+      typeof currentIndex === 'number'
+      && currentIndex < missingCoverageElements.length - 1
     ) {
       nextIndex = currentIndex + 1;
     }
@@ -61,8 +62,8 @@ var jumpToCode = (function init() {
 
   return function jump(event) {
     if (
-      document.getElementById('fileSearch') === document.activeElement &&
-      document.activeElement != null
+      document.getElementById('fileSearch') === document.activeElement
+      && document.activeElement != null
     ) {
       // if we're currently focused on the search input, we don't want to navigate
       return;
@@ -80,5 +81,5 @@ var jumpToCode = (function init() {
         break;
     }
   };
-})();
+}());
 window.addEventListener('keydown', jumpToCode);

coverage/lcov-report/sorter.js

@@ -1,10 +1,11 @@
-var addSorting = (function () {
-  'use strict';
-  var cols,
-    currentSort = {
-      index: 0,
-      desc: false,
-    };
+/* eslint-disable */
+
+const addSorting = (function () {
+  let cols;
+  const currentSort = {
+    index: 0,
+    desc: false,
+  };
 
   // returns the summary table element
   function getTable() {
@@ -38,19 +39,19 @@ var addSorting = (function () {
 
   // loads the search box
   function addSearchBox() {
-    var template = document.getElementById('filterTemplate');
-    var templateClone = template.content.cloneNode(true);
+    const template = document.getElementById('filterTemplate');
+    const templateClone = template.content.cloneNode(true);
     templateClone.getElementById('fileSearch').oninput = onFilterInput;
     template.parentElement.appendChild(templateClone);
   }
 
   // loads all columns
   function loadColumns() {
-    var colNodes = getTableHeader().querySelectorAll('th'),
-      colNode,
-      cols = [],
-      col,
-      i;
+    const colNodes = getTableHeader().querySelectorAll('th');
+    let colNode;
+    const cols = [];
+    let col;
+    let i;
 
     for (i = 0; i < colNodes.length; i += 1) {
       colNode = colNodes[i];
@@ -62,20 +63,20 @@ var addSorting = (function () {
       cols.push(col);
       if (col.sortable) {
         col.defaultDescSort = col.type === 'number';
-        colNode.innerHTML = colNode.innerHTML + '<span class="sorter"></span>';
+        colNode.innerHTML += '<span class="sorter"></span>';
       }
     }
     return cols;
   }
   // attaches a data attribute to every tr element with an object
   // of data values keyed by column name
   function loadRowData(tableRow) {
-    var tableCols = tableRow.querySelectorAll('td'),
-      colNode,
-      col,
-      data = {},
-      i,
-      val;
+    const tableCols = tableRow.querySelectorAll('td');
+    let colNode;
+    let col;
+    const data = {};
+    let i;
+    let val;
     for (i = 0; i < tableCols.length; i += 1) {
       colNode = tableCols[i];
       col = cols[i];
@@ -89,26 +90,26 @@ var addSorting = (function () {
   }
   // loads all row data
   function loadData() {
-    var rows = getTableBody().querySelectorAll('tr'),
-      i;
+    const rows = getTableBody().querySelectorAll('tr');
+    let i;
 
     for (i = 0; i < rows.length; i += 1) {
       rows[i].data = loadRowData(rows[i]);
     }
   }
   // sorts the table using the data for the ith column
   function sortByIndex(index, desc) {
-    var key = cols[index].key,
-      sorter = function (a, b) {
-        a = a.data[key];
-        b = b.data[key];
-        return a < b ? -1 : a > b ? 1 : 0;
-      },
-      finalSorter = sorter,
-      tableBody = document.querySelector('.coverage-summary tbody'),
-      rowNodes = tableBody.querySelectorAll('tr'),
-      rows = [],
-      i;
+    const { key } = cols[index];
+    const sorter = function (a, b) {
+      a = a.data[key];
+      b = b.data[key];
+      return a < b ? -1 : a > b ? 1 : 0;
+    };
+    let finalSorter = sorter;
+    const tableBody = document.querySelector('.coverage-summary tbody');
+    const rowNodes = tableBody.querySelectorAll('tr');
+    const rows = [];
+    let i;
 
     if (desc) {
       finalSorter = function (a, b) {
@@ -129,8 +130,8 @@ var addSorting = (function () {
   }
   // removes sort indicators for current column being sorted
   function removeSortIndicators() {
-    var col = getNthColumn(currentSort.index),
-      cls = col.className;
+    const col = getNthColumn(currentSort.index);
+    let cls = col.className;
 
     cls = cls.replace(/ sorted$/, '').replace(/ sorted-desc$/, '');
     col.className = cls;
@@ -143,24 +144,24 @@ var addSorting = (function () {
   }
   // adds event listeners for all sorter widgets
   function enableUI() {
-    var i,
-      el,
-      ithSorter = function ithSorter(i) {
-        var col = cols[i];
+    let i;
+    let el;
+    const ithSorter = function ithSorter(i) {
+      const col = cols[i];
 
-        return function () {
-          var desc = col.defaultDescSort;
+      return function () {
+        let desc = col.defaultDescSort;
 
-          if (currentSort.index === i) {
-            desc = !currentSort.desc;
-          }
-          sortByIndex(i, desc);
-          removeSortIndicators();
-          currentSort.index = i;
-          currentSort.desc = desc;
-          addSortIndicators();
-        };
+        if (currentSort.index === i) {
+          desc = !currentSort.desc;
+        }
+        sortByIndex(i, desc);
+        removeSortIndicators();
+        currentSort.index = i;
+        currentSort.desc = desc;
+        addSortIndicators();
       };
+    };
     for (i = 0; i < cols.length; i += 1) {
       if (cols[i].sortable) {
         // add the click event handler on the th so users

eslint.config.js

@@ -1,8 +1,57 @@
 import globals from 'globals';
+
+import path from 'path';
+import { fileURLToPath } from 'url';
+import { FlatCompat } from '@eslint/eslintrc';
 import pluginJs from '@eslint/js';
+import importPlugin from 'eslint-plugin-import';
+
+// mimic CommonJS variables -- not needed if using CommonJS
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: pluginJs.configs.recommended,
+});
 
-/** @type {import('eslint').Linter.Config[]} */
 export default [
-  { languageOptions: { globals: globals.browser } },
-  pluginJs.configs.recommended,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+        ...globals.jest,
+      },
+      parserOptions: {
+        // Eslint doesn't supply ecmaVersion in `parser.js` `context.parserOptions`
+        // This is required to avoid ecmaVersion < 2015 error or 'import' / 'export' error
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+      },
+    },
+    plugins: { import: importPlugin },
+    rules: {
+      ...importPlugin.configs.recommended.rules,
+    },
+  },
+  ...compat.extends('airbnb-base'),
+  {
+    rules: {
+      'no-underscore-dangle': [
+        'error',
+        {
+          allow: ['__filename', '__dirname'],
+        },
+      ],
+      'import/extensions': [
+        'error',
+        {
+          js: 'always',
+        },
+      ],
+      'import/no-named-as-default': 'off',
+      'import/no-named-as-default-member': 'off',
+      'no-console': 'off',
+      'import/no-extraneous-dependencies': 'off',
+    },
+  },
 ];