Commit 8617ed6
authored
fix: use HolderV2() for PropertyCallbackInfo on V8 >= 12.5 (#1459)
fix: use HolderV2() for PropertyCallbackInfo on V8 >= 13
PR #1456 replaced This() with Holder() in NODE_GETTER contexts, but
Electron 41 (V8 14.6) removed both This() and Holder() from
PropertyCallbackInfo. Only HolderV2() remains (to be renamed back to
Holder() in a future V8 version per crbug.com/333672197).
Add a PROPERTY_HOLDER compat macro that uses HolderV2() on V8 >= 13
and falls back to This() on older versions. Same pattern as the
existing GET_PROTOTYPE macro.
Verified: compiles and runs on Electron 41.0.1 (V8 14.6.202).
Fixes #14581 parent 959a018 commit 8617ed6
3 files changed
+16
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
408 | 408 | | |
409 | 409 | | |
410 | 410 | | |
411 | | - | |
| 411 | + | |
412 | 412 | | |
413 | 413 | | |
414 | 414 | | |
415 | | - | |
| 415 | + | |
416 | 416 | | |
417 | 417 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
381 | | - | |
| 381 | + | |
382 | 382 | | |
383 | 383 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
14 | 27 | | |
15 | 28 | | |
16 | 29 | | |
| |||
0 commit comments