Merge pull request #23 from saorsa-labs/fix/event-driven-disconnect-detection

refactor!: replace health-check ping/pong with event-driven disconnect detection

Author: mickvandijke

Cargo.lock

@@ -6,7 +6,7 @@ members = [
 
 [package]
 name = "saorsa-transport"
-version = "0.27.0"
+version = "0.28.0"
 edition = "2024"
 rust-version = "1.88.0"
 license = "MIT OR Apache-2.0"

Cargo.toml

@@ -74,9 +74,6 @@ pub mod discovery {
 
     /// Long operation timeout
     pub const LONG_OPERATION_TIMEOUT: Duration = Duration::from_secs(10);
-
-    /// Health check interval
-    pub const HEALTH_CHECK_INTERVAL: Duration = Duration::from_secs(30);
 }
 
 /// Connection related timeouts
@@ -115,9 +112,6 @@ pub mod monitoring {
     /// Recovery timeout for failed operations
     pub const RECOVERY_TIMEOUT: Duration = Duration::from_secs(300);
 
-    /// Health check interval
-    pub const HEALTH_CHECK_INTERVAL: Duration = Duration::from_secs(30);
-
     /// Metrics retention period
     pub const RETENTION_PERIOD: Duration = Duration::from_secs(3600);
 

src/config/timeouts.rs

@@ -347,8 +347,8 @@ pub use node_event::{DisconnectReason as NodeDisconnectReason, NodeEvent, Traver
 
 /// P2P endpoint - for advanced use, prefer Node for most applications
 pub use p2p_endpoint::{
-    ConnectionHealth, ConnectionMetrics, DisconnectReason, EndpointError, EndpointStats,
-    P2pEndpoint, P2pEvent, PeerConnection, TraversalPhase,
+    ConnectionMetrics, DisconnectReason, EndpointError, EndpointStats, P2pEndpoint, P2pEvent,
+    PeerConnection, TraversalPhase,
 };
 
 /// P2P configuration with builder pattern

src/lib.rs

@@ -466,13 +466,6 @@ impl Node {
         self.inner.is_connected(addr).await
     }
 
-    /// Query the health status of a connection to a specific peer.
-    ///
-    /// Returns `None` if the peer is not connected.
-    pub async fn connection_health(&self, addr: &SocketAddr) -> Option<crate::ConnectionHealth> {
-        self.inner.connection_health(addr).await
-    }
-
     // === Messaging ===
 
     /// Send data to a peer by address