Avoid PHP Fatal when duration fields are left blank. (#3158)

dd32 · web-flow · commit e2cc6c4dacaf · 2025-05-27T15:47:44.000+10:00
If the duration fields are left blank, under PHP8 a fatal will be thrown:

&gt; E_ERROR: Uncaught TypeError: Unsupported operand types: string * int
diff --git a/wp-content/plugins/wporg-learn/inc/post-meta.php b/wp-content/plugins/wporg-learn/inc/post-meta.php
@@ -664,6 +664,7 @@ function save_workshop_meta_fields( $post_id ) {
 
 	$duration = filter_input( INPUT_POST, 'duration', FILTER_SANITIZE_NUMBER_INT, FILTER_REQUIRE_ARRAY );
 	if ( isset( $duration['h'], $duration['m'], $duration['s'] ) ) {
+		$duration = array_map( 'absint', $duration );
 		$duration = $duration['h'] * HOUR_IN_SECONDS + $duration['m'] * MINUTE_IN_SECONDS + $duration['s'];
 		update_post_meta( $post_id, 'duration', $duration );
 	}

Original file line number	Diff line number	Diff line change
`@@ -664,6 +664,7 @@ function save_workshop_meta_fields( $post_id ) {`
`664`	`664`
`665`	`665`	`$duration = filter_input( INPUT_POST, 'duration', FILTER_SANITIZE_NUMBER_INT, FILTER_REQUIRE_ARRAY );`
`666`	`666`	`if ( isset( $duration['h'], $duration['m'], $duration['s'] ) ) {`
	`667`	`+ $duration = array_map( 'absint', $duration );`
`667`	`668`	`$duration = $duration['h'] * HOUR_IN_SECONDS + $duration['m'] * MINUTE_IN_SECONDS + $duration['s'];`
`668`	`669`	`update_post_meta( $post_id, 'duration', $duration );`
`669`	`670`	`}`