Start checking callbacks for restricted functions

WordPress/AbstractFunctionRestrictionsSniff.php

@@ -68,6 +68,51 @@ abstract class WordPress_AbstractFunctionRestrictionsSniff extends WordPress_Sni
 	 */
 	protected $excluded_groups = array();
 
+	/**
+	 * List of known PHP and WP function which take a callback as an argument.
+	 *
+	 * Sorted alphabetically. Last updated on 8th March 2017.
+	 *
+	 * @since 0.11.0
+	 *
+	 * @var array <string function name> => <int callback argument position>
+	 */
+	protected $callback_functions = array(
+		'add_filter'                  => array( 2 ),
+		'add_action'                  => array( 2 ),
+		'array_diff_uassoc'           => array( -1 ), // = last argument passed.
+		'array_diff_ukey'             => array( -1 ), // = last argument passed.
+		'array_filter'                => array( 2 ),
+		'array_intersect_uassoc'      => array( -1 ), // = last argument passed.
+		'array_intersect_ukey'        => array( -1 ), // = last argument passed.
+		'array_map'                   => array( 1 ),
+		'array_reduce'                => array( 2 ),
+		'array_udiff_assoc'           => array( -1 ), // = last argument passed.
+		'array_udiff_uassoc'          => array( -1, -2 ), // = last argument passed.
+		'array_udiff'                 => array( -1 ), // = last argument passed.
+		'array_uintersect_assoc'      => array( -1 ), // = last argument passed.
+		'array_uintersect_uassoc'     => array( -1, -2 ), // = last argument passed.
+		'array_uintersect'            => array( -1 ), // = last argument passed.
+		'array_walk'                  => array( 2 ),
+		'array_walk_recursive'        => array( 2 ),
+		'call_user_func'              => array( 1 ),
+		'call_user_func_array'        => array( 1 ),
+		'forward_static_call'         => array( 1 ),
+		'forward_static_call_array'   => array( 1 ),
+		'header_register_callback'    => array( 1 ),
+		'iterator_apply'              => array( 2 ),
+		'mb_ereg_replace_callback'    => array( 2 ),
+		'ob_start'                    => array( 1 ),
+		'preg_replace_callback'       => array( 2 ),
+		'register_shutdown_function'  => array( 1 ),
+		'register_tick_function'      => array( 1 ),
+		'set_error_handler'           => array( 1 ),
+		'set_exception_handler'       => array( 1 ),
+		'uasort'                      => array( 2 ),
+		'uksort'                      => array( 2 ),
+		'usort'                       => array( 2 ),
+	);
+
 	/**
 	 * Groups of functions to restrict.
 	 *
@@ -170,7 +215,14 @@ public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
 		$this->init( $phpcsFile );
 
 		if ( true === $this->is_targetted_token( $stackPtr ) ) {
+
+			$callback_matches = $this->check_for_callback_matches( $stackPtr );
+			if ( $callback_matches ) {
+				return $callback_matches;
+			}
+
 			return $this->check_for_matches( $stackPtr );
+
 		}
 
 	} // End process().
@@ -229,7 +281,7 @@ public function is_targetted_token( $stackPtr ) {
 	 *                  normal file processing.
 	 */
 	public function check_for_matches( $stackPtr ) {
-		$token_content = strtolower( $this->tokens[ $stackPtr ]['content'] );
+		$token_content = strtolower( $this->strip_quotes( $this->tokens[ $stackPtr ]['content'] ) );
 		$skip_to       = array();
 
 		foreach ( $this->groups as $groupName => $group ) {
@@ -255,6 +307,64 @@ public function check_for_matches( $stackPtr ) {
 
 	} // End check_for_matches().
 
+	/**
+	 * Verify if the current token is one of the targetted functions as callback.
+	 *
+	 * @since 0.11.0
+	 *
+	 * @param int $stackPtr The position of the current token in the stack.
+	 *
+	 * @return int|false
+	 */
+	public function check_for_callback_matches( $stackPtr ) {
+
+		$token_content = strtolower( $this->tokens[ $stackPtr ]['content'] );
+
+		// Check if the function is used as a callback.
+		if ( ! isset( $this->callback_functions[ $token_content ] ) ) {
+			return false;
+		}
+
+		$skip_to    = array();
+		$parameters = $this->get_function_call_parameters( $stackPtr );
+		$positions  = $this->callback_functions[ $token_content ];
+
+		foreach ( $positions as $position ) {
+
+			// Calculate the last argument if the position is negative.
+			if ( $position < 0 ) {
+				$position = count( $parameters ) + 1 + $position;
+			}
+
+			if ( ! isset( $parameters[ $position ] ) ) {
+				return false;
+			}
+
+			// Only get function name not anonymous funtions.
+			$callback = $this->phpcsFile->findNext(
+				array( T_CONSTANT_ENCAPSED_STRING ),
+				$parameters[ $position ]['start'],
+				null,
+				false,
+				null,
+				true
+			);
+
+			if ( ! $callback ) {
+				return false;
+			}
+
+			$skip_to[] = $this->check_for_matches( $callback );
+		}
+
+		if ( empty( $skip_to ) || min( $skip_to ) === 0 ) {
+			return false;
+		}
+
+		return min( $skip_to );
+
+	}
+
 	/**
 	 * Process a matched token.
 	 *

WordPress/Sniffs/Functions/FunctionRestrictionsSniff.php

@@ -36,7 +36,15 @@ class WordPress_Sniffs_Functions_FunctionRestrictionsSniff extends WordPress_Abs
 	 * @return array
 	 */
 	public function getGroups() {
-		return array();
+		return array(
+			'foobar' => array(
+				'type'      => 'warning',
+				'message'   => 'Callback functions test.',
+				'functions' => array(
+					'foobar*',
+				),
+			),
+		);
 	}
 
 } // End class.

WordPress/Tests/Functions/FunctionRestrictionsUnitTest.inc

@@ -0,0 +1,36 @@
+<?php
+
+// Warnings.
+add_filter( '', 'foobar' );
+add_action( '', 'foobar' );
+call_user_func( 'foobar' );
+call_user_func_array( 'foobar' );
+forward_static_call( 'foobar' );
+forward_static_call_array( 'foobar' );
+array_diff_uassoc( '', '', 'foobar' );
+array_diff_ukey( '', '', 'foobar' );
+array_filter( '', 'foobar' );
+array_intersect_uassoc( '', 'foobar' );
+array_intersect_ukey( '', 'foobar' );
+array_map( 'foobar' );
+array_reduce( '', 'foobar' );
+array_udiff_assoc( '', 'foobar' );
+array_udiff_uassoc( '', 'foobar1', 'foobar2' );
+array_udiff( '', 'foobar' );
+array_uintersect_assoc( '', 'foobar' );
+array_uintersect_uassoc( '', 'foobar1', 'foobar2' );
+array_uintersect( '', 'foobar' );
+array_walk( '', 'foobar' );
+array_walk_recursive( '', 'foobar' );
+iterator_apply( '', 'foobar' );
+usort( '', 'foobar' );
+uasort( '', 'foobar' );
+uksort( '', 'foobar' );
+preg_replace_callback( '', 'foobar' );
+mb_ereg_replace_callback( '', 'foobar' );
+header_register_callback( 'foobar' );
+ob_start( 'foobar' );
+set_error_handler( 'foobar' );
+set_exception_handler( 'foobar' );
+register_shutdown_function( 'foobar' );
+register_tick_function( 'foobar' );

WordPress/Tests/Functions/FunctionRestrictionsUnitTest.php

@@ -0,0 +1,41 @@
+<?php
+/**
+ * Unit test class for WordPress Coding Standard.
+ *
+ * @package WPCS\WordPressCodingStandards
+ * @link    https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards
+ * @license https://opensource.org/licenses/MIT MIT
+ */
+
+/**
+ * Unit test class for the DontExtract sniff.
+ *
+ * @package WPCS\WordPressCodingStandards
+ * @since   0.10.0
+ */
+class WordPress_Tests_Functions_FunctionRestrictionsUnitTest extends AbstractSniffUnitTest {
+
+	/**
+	 * Returns the lines where errors should occur.
+	 *
+	 * @return array <int line number> => <int number of errors>
+	 */
+	public function getErrorList() {
+		return array();
+
+	}
+
+	/**
+	 * Returns the lines where warnings should occur.
+	 *
+	 * @return array <int line number> => <int number of warnings>
+	 */
+	public function getWarningList() {
+		$array     = array_fill( 4, 33, 1 );
+		$array[18] = 2;
+		$array[21] = 2;
+		return $array;
+
+	}
+
+} // End class.