Skip to content

The function rest_is_ip_address should be not issue for sanitize #2483

Open
@davidperezgar

Description

@davidperezgar

A user is reporting in Plugin Check Plugin using WPCS Sanitize check, a possible false positive with the function rest_is_ip_address.

The code shared was this:

// Generate a unique session id
function wppa_get_session_id() {
global $wppa_version;
static $session_id;

	// Found already?
	if ( $session_id ) {
		return $session_id;
	}

	// Look for a cookie
	if ( isset( $_COOKIE['wppa_session_id'] ) ) {
(30)		$t = rest_is_ip_address( wp_unslash( $_COOKIE['wppa_session_id'] ) );
		if ( $t ) {
			$session_id = $t;
			return $session_id;
		}
	}

You can see it in this support post

I believe that this function does not need to have sanitized data as is checking if it's a correct IP.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions