Skip to content

Commit 1a1d819

Browse files
committed
Address interactivity bind review feedback
1 parent 3c45243 commit 1a1d819

3 files changed

Lines changed: 2 additions & 6 deletions

File tree

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/interactivity/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"types": "build-types",
3636
"dependencies": {
3737
"@preact/signals": "^1.3.0",
38-
"preact": "10.29.1"
38+
"preact": "^10.29.1"
3939
},
4040
"devDependencies": {
4141
"@types/jest": "^29.5.14"

packages/interactivity/src/directives.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -791,10 +791,6 @@ export default () => {
791791
* present, so we can't remove it.
792792
* We follow Preact's logic: https://github.com/preactjs/preact/blob/10.29.1/src/diff/props.js#L138-L150
793793
*/
794-
if ( typeof result === 'function' ) {
795-
return;
796-
}
797-
798794
if (
799795
result !== null &&
800796
result !== undefined &&

0 commit comments

Comments
 (0)