Commit 462946b
committed
Theme: phrase the optimization in mechanism-neutral terms
In anticipation of #78678, which replaces ThemeProvider's per-instance
`<style>` element with inline custom properties on the wrapper, reword
the comments / CHANGELOG / README / PR description to describe the
optimization as "skip applying per-instance overrides" rather than
"skip emitting the `<style>` element". The savings are real in either
mechanism (no CSS string assembly + no DOM write).
Also simplify the `AcrossIframes` story:
- The previous filter cloned `<style data-wpds-theme-provider-id>`
elements from `document.head`, which is dead code (React-rendered
`<style>` is not in head) and would be doubly dead post-#78678
(the attribute is removed entirely). Drop it.
- Per-instance overrides ride into the iframe with the portalled
`<ThemeProvider>` itself (whether the mechanism is a `<style>`
child or an inline `style` prop on the wrapper). The story only
needs to clone the prebuilt token stylesheet `<link>`.1 parent 3420d6d commit 462946b
4 files changed
Lines changed: 18 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
310 | 310 | | |
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
| 316 | + | |
| 317 | + | |
320 | 318 | | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
339 | 324 | | |
340 | 325 | | |
341 | 326 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
145 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
| |||
0 commit comments