Link: Honor openInNewTab consistently

Author: mirka

packages/ui/src/link/link.tsx

@@ -20,20 +20,10 @@ export const Link = forwardRef< HTMLAnchorElement, LinkProps >( function Link(
 		openInNewTab = false,
 		render,
 		className,
-		onClick,
 		...props
 	},
 	ref
 ) {
-	const isInternalAnchor = !! props.href?.startsWith( '#' );
-
-	const handleClick = ( event: React.MouseEvent< HTMLAnchorElement > ) => {
-		if ( openInNewTab && isInternalAnchor ) {
-			event.preventDefault();
-		}
-		onClick?.( event );
-	};
-
 	const element = useRender( {
 		render,
 		defaultTagName: 'a',
@@ -49,7 +39,6 @@ export const Link = forwardRef< HTMLAnchorElement, LinkProps >( function Link(
 				openInNewTab && styles[ 'has-link-icon' ],
 				className
 			),
-			onClick: handleClick,
 			target: openInNewTab ? '_blank' : undefined,
 			children: openInNewTab ? (
 				<>

packages/ui/src/link/test/index.test.tsx

@@ -16,6 +16,24 @@ describe( 'Link', () => {
 		expect( ref.current ).toBeInstanceOf( HTMLAnchorElement );
 	} );
 
+	it( 'calls onClick when clicked', async () => {
+		const user = userEvent.setup();
+		const onClick = jest.fn(
+			( event: React.MouseEvent< HTMLAnchorElement > ) =>
+				event.preventDefault()
+		);
+
+		render(
+			<Link href="/page" onClick={ onClick }>
+				Go to page
+			</Link>
+		);
+
+		await user.click( screen.getByRole( 'link', { name: 'Go to page' } ) );
+
+		expect( onClick ).toHaveBeenCalledTimes( 1 );
+	} );
+
 	describe( 'openInNewTab', () => {
 		it( 'sets target="_blank" when true', () => {
 			render(
@@ -49,45 +67,5 @@ describe( 'Link', () => {
 				screen.getByLabelText( '(opens in a new tab)' )
 			).toBeInTheDocument();
 		} );
-
-		it( 'prevents default for internal anchor links', async () => {
-			const user = userEvent.setup();
-			const onClick = jest.fn();
-
-			render(
-				<Link href="#section" openInNewTab onClick={ onClick }>
-					Jump
-				</Link>
-			);
-
-			await user.click( screen.getByRole( 'link' ) );
-
-			expect( onClick ).toHaveBeenCalledTimes( 1 );
-			expect( onClick.mock.calls[ 0 ][ 0 ].defaultPrevented ).toBe(
-				true
-			);
-		} );
-
-		it( 'does not prevent default for external links', async () => {
-			const user = userEvent.setup();
-			const onClick = jest.fn();
-
-			render(
-				<Link
-					href="https://example.com"
-					openInNewTab
-					onClick={ onClick }
-				>
-					External
-				</Link>
-			);
-
-			await user.click( screen.getByRole( 'link' ) );
-
-			expect( onClick ).toHaveBeenCalledTimes( 1 );
-			expect( onClick.mock.calls[ 0 ][ 0 ].defaultPrevented ).toBe(
-				false
-			);
-		} );
 	} );
 } );

packages/ui/src/link/types.ts

@@ -22,8 +22,7 @@ export interface LinkProps extends Omit< ComponentProps< 'a' >, 'target' > {
 
 	/**
 	 * Whether to open the link in a new browser tab.
-	 * When true, sets `target="_blank"`, appends a visual arrow indicator,
-	 * and prevents navigation for internal anchors (`#`-prefixed hrefs).
+	 * When true, sets `target="_blank"` and appends a visual arrow indicator.
 	 *
 	 * @default false
 	 */