Private APIs: remove re-registration check #73610
Merged
+2
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @copilot. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
This makes sense to me. A core package being bundled multiple times is definitely a valid use-case that we need more and more. It does make it easier for third-parties to opt-in into these private APIs but I have two thoughts here
|
|
Size Change: -47 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
Member
Author
|
@copilot looks like that failing unit test can be removed, can you do that? |
Contributor
|
Flaky tests detected in f4bb8ed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19734941612
|
youknowriad
approved these changes
Nov 27, 2025
This was referenced Nov 27, 2025
Member
|
For context, the current state (allow re-registration in Gutenberg but do not allow it in core) has proven an issue. It hides the issue until the worst-possible moment (package updates in core). This caused:
#73555 analyzes the usage of private APIs in DataViews/DataForm. In conversations with @mirka some of them are not ready to be made public (the validation components) because they're built on older version of low-level primitives — we are working on newer versions at |
oandregal
approved these changes
Nov 27, 2025
Member
Author
|
I think we should backport this to the last GB RC, so we can sync packages in core from 22.2 onwards instead of having to wait another two weeks. |
ellatrix
added
the
Backport to Gutenberg RC
mikachan
pushed a commit
that referenced
this pull request
Nov 28, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]>
Member
|
I just cherry-picked this PR to the release/22.2 branch to get it included in the next release: 68cacfb |
mikachan
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the re-registration check from the private APIs package. This allows packages to opt-in to private APIs multiple times.
Why?
Some of our packages like data views and global styles UI are bundled in other packages multiple times, which causes the private APIs registration to complain about multiple opt-ins, except in Gutenberg itself. This means we have a behavior difference between Gutenberg and Core, which is preventing package syncs from happening because the editors crash.
First of all, the behavior should be the same for core and Gutenberg.
Secondly, the way that some modules like data views and global styles UI are being developed makes it hard to enable the re-registration check in the GB repo.
The fact that people have to go through a lot of effort to use private APIs (install private api packages, opt-in string, unlock...) should be enough to communicate that these APIs are private and there's to backwards compatibility. There's quite a few cases where people create workaround even around the re-registration, e.g. by npm package patches, which makes everything even more fragile. When packages are consumed through npm, there's also less concern because of the versioning and people should be able to use the private APIs if they really wanted to.
So I propose that we simply remove the check. 🙂
How?
Removes it.
Testing Instructions
Tests should pass.
Testing Instructions for Keyboard
Screenshots or screencast