Merge pull request #332 from WordPress/fix/returntypewillchange

Add `ReturnTypeWillChange` attributes / test PHP 8.3

Author: felixarntz

.github/workflows/php-test.yml

@@ -63,6 +63,9 @@ jobs:
           - php: '8.2'
             wordpress: 'trunk'
             experimental: true
+          - php: '8.3'
+            wordpress: 'trunk'
+            experimental: true
     env:
       WP_ENV_PHP_VERSION: ${{ matrix.php }}
       WP_ENV_CORE: ${{ matrix.wordpress == 'trunk' && 'WordPress/WordPress' || format( 'https://wordpress.org/wordpress-{0}.zip', matrix.wordpress ) }}

includes/Checker/Default_Check_Collection.php

@@ -198,6 +198,7 @@ public function getIterator(): Traversable {
 	 * @param string|int $offset Either a check slug (string) or index (integer).
 	 * @return bool True if a check exists at the given slug or index, false otherwise.
 	 */
+	#[\ReturnTypeWillChange]
 	public function offsetExists( $offset ) {
 		if ( is_string( $offset ) ) {
 			return isset( $this->checks[ $offset ] );
@@ -214,6 +215,7 @@ public function offsetExists( $offset ) {
 	 * @param string|int $offset Either a check slug (string) or index (integer).
 	 * @return Check|null Check with the given slug or index, or null if it does not exist.
 	 */
+	#[\ReturnTypeWillChange]
 	public function offsetGet( $offset ) {
 		if ( is_string( $offset ) ) {
 			if ( isset( $this->checks[ $offset ] ) ) {
@@ -239,6 +241,7 @@ public function offsetGet( $offset ) {
 	 * @param string|int $offset Either a check slug (string) or index (integer).
 	 * @param mixed      $value  Value to set.
 	 */
+	#[\ReturnTypeWillChange]
 	public function offsetSet( $offset, $value ) {
 		// Not implemented as this is a read-only collection.
 	}
@@ -252,6 +255,7 @@ public function offsetSet( $offset, $value ) {
 	 *
 	 * @param string|int $offset Either a check slug (string) or index (integer).
 	 */
+	#[\ReturnTypeWillChange]
 	public function offsetUnset( $offset ) {
 		// Not implemented as this is a read-only collection.
 	}