-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help/About: Initial pass at 6.8 About page #8575
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I've updated the "Style Book" section to show the classic theme details only on classic themes, with a link to the Style Book if the user has permission and the classic theme supports it. If the user does not have permission or the classic theme doesn't have theme.json/editor styles, text still shows, but no link appears. If the current theme is a block theme, the whole blurb is hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few notes inline, mainly covering links that always point to the 6.8 version.
It's outside the diff but if you change the display name variable to this it will ensure that plugins can't mess up the display of the version number:
list( $display_version ) = explode( '-', wp_get_wp_version() );
If you think it would be easier to set up a $display_major_version
variable to avoid future changes, I'm happy to do so and push to this PR.
Co-authored-by: Peter Wilson <[email protected]>
Is the content here just some filler text or is this what should be in the final version? |
@benniledl It's supposed to be final, there were content reviews over the last two weeks. Is the text inaccurate? |
See https://core.trac.wordpress.org/ticket/43936#comment:68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (I only reviewed the technical structure)
Is that the "Prevent vulnerabilities" section? should that whole section be removed? |
Yes, it is the "Prevent vulnerabilities" section. yes, I think it should be removed/changed. |
Committed in r60087 |
This PR introduces the new content for the 6.8 About page. This release introduces a new header image, but otherwise only minor tweaks to the layout and colors. I've also gone through and replaced a few instances of "6.7" with the dynamic
$display_version
, so we won't need to change those in the future.I've put the images in, but linked from make/core since I'm not sure they're final-final 🙂
@karmatosed I've left the "Take a load off the database" & "Prevent vulnerabilities…" sections in, reorganized slightly so things line up nicely at the default desktop size. I also grabbed the query ♾️ icon for the database section, but I can swap that out if you have a different one in mind.
Other pages:
And on RTL languages:
Trac ticket: https://core.trac.wordpress.org/ticket/63025
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.