-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add _doing_it_wrong() notices for missing script and script module dependencies
#10545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add _doing_it_wrong() notices for missing script and script module dependencies
#10545
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Let's make sure to add unit tests for these changes as well. |
|
This is looking good to me. I will plan to finish reviewing and commit by next week. |
This PR adds developer-facing _doing_it_wrong() notices when a script or script module is enqueued with dependencies that have not been registered.
Currently, WordPress silently skips printing such assets, which makes dependency issues difficult to diagnose. This change improves debugging clarity during development.
What’s changed
✅ Classic scripts (WP_Scripts)
✅ Script modules (WP_Script_Modules)
Both implementations:
Trac ticket: https://core.trac.wordpress.org/ticket/64229