Skip to content

Commit 06f6556

Browse files
authored
Merge pull request #82 from davidmarne/lint_ignores
Lint ignores
2 parents e2f0ed8 + 3def4c0 commit 06f6556

9 files changed

+33
-1
lines changed

Diff for: CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 7.4.2
2+
3+
* add lint ignores to generated files
4+
15
## 7.4.1
26

37
* fix cast issues around store changes in dart 2

Diff for: example/example.g.dart

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: lib/generator.dart

+10
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,13 @@ class BuiltReduxGenerator extends Generator {
88
@override
99
Future<String> generate(LibraryReader library, BuildStep buildStep) async {
1010
final result = new StringBuffer();
11+
var hasWrittenHeaders = false;
1112
for (final element in library.allElements) {
1213
if (_needsReduxActions(element) && element is ClassElement) {
14+
if (!hasWrittenHeaders) {
15+
hasWrittenHeaders = true;
16+
result.writeln(_lintIgnores);
17+
}
1318
log.info('Generating action classes for ${element.name}');
1419
result.writeln(_generateActions(element));
1520
}
@@ -19,6 +24,11 @@ class BuiltReduxGenerator extends Generator {
1924
}
2025
}
2126

27+
const _lintIgnores = """
28+
// ignore_for_file: avoid_classes_with_only_static_members
29+
// ignore_for_file: annotate_overrides
30+
""";
31+
2232
String _generateActions(ClassElement element) =>
2333
_generateDispatchersIfNeeded(element) + _actionNamesClassTemplate(element);
2434

Diff for: pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: built_redux
2-
version: 7.4.1
2+
version: 7.4.2
33
description:
44
A state management library written in dart that enforces immutability
55
authors:

Diff for: test/unit/action_generics_models.g.dart

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: test/unit/collection_models.g.dart

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: test/unit/inheritance_test_models.g.dart

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: test/unit/nested_models.g.dart

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: test/unit/test_counter.g.dart

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)