Merge pull request #83 from davidmarne/update_analyzer_dev

Update analyzer dev

Author: davidmarne

Diff for: .gitignore

@@ -1,3 +1,4 @@
+.dart_tool/
 .pub
 packages
 .packages

Diff for: .travis.yml

@@ -10,9 +10,7 @@ before_install:
 
 script:
   - pub run build_runner build --delete-conflicting-outputs
-  - pub run dart_dev format --check
-  - pub run dart_dev analyze
-  - pub run dart_dev test -p vm
-  - pub run dart_dev coverage --no-html
-  - bash <(curl -s https://codecov.io/bash) -f coverage/coverage.lcov
+  - dartfmt -n --set-exit-if-changed lib/
+  - dartanalyzer --fatal-warnings --fatal-infos lib/
+  - pub run build_runner test --delete-conflicting-outputs
   - pub run build_runner test --delete-conflicting-outputs -- -p chrome

Diff for: CHANGELOG.md

@@ -1,3 +1,14 @@
+
+## 7.4.3-dev
+
+* update dependency range on analyzer
+* update dependency range on test
+* fix broken test caused by dart 2's new asyc behavior
+
+## 7.4.2
+
+* add lint ignores to generated files
+
 ## 7.4.1-dev
 
 * open sourc-gen range

Diff for: README.md

@@ -40,6 +40,9 @@ Inspired by [redux][redux_git]
 
 Built using [built_value][built_value_git]
 
+## Using dart 2?
+Check out the [dart 2 dev branch](https://github.com/davidmarne/built_redux/tree/dart-2-dev), which works with the latest versions of build, build_runner, and built_value.
+
 ## Framework bindings
 
 [flutter]

Diff for: doc/basics/reducers.md

@@ -32,9 +32,9 @@ I can define a simple reducer function as follows:
 
 ```dart
 void counterReducer(App prevState, Action<dynamic> action, AppBuilder builder) {
-  if (action.name == AppActionNames.increment.name)
+  if (action.name == AppActionsNames.increment.name)
     builder.count += action.payload as int;
-  else if (action.name == AppActionNames.decrement.name)
+  else if (action.name == AppActionsNames.decrement.name)
     builder.count -= action.payload as int;
 }
 ```

Diff for: example/example.g.dart

@@ -8,8 +8,13 @@ class BuiltReduxGenerator extends Generator {
   @override
   Future<String> generate(LibraryReader library, BuildStep buildStep) async {
     final result = new StringBuffer();
+    var hasWrittenHeaders = false;
     for (final element in library.allElements) {
       if (_needsReduxActions(element) && element is ClassElement) {
+        if (!hasWrittenHeaders) {
+          hasWrittenHeaders = true;
+          result.writeln(_lintIgnores);
+        }
         log.info('Generating action classes for ${element.name}');
         result.writeln(_generateActions(element));
       }
@@ -19,6 +24,11 @@ class BuiltReduxGenerator extends Generator {
   }
 }
 
+const _lintIgnores = """
+// ignore_for_file: avoid_classes_with_only_static_members
+// ignore_for_file: annotate_overrides
+""";
+
 String _generateActions(ClassElement element) =>
     _generateDispatchersIfNeeded(element) + _actionNamesClassTemplate(element);
 

Diff for: lib/generator.dart

@@ -43,8 +43,10 @@ class Store<
       if (_state == state) return;
 
       // update the internal state and publish the change
-      _stateController.add(
-          new StoreChange<State, StateBuilder, dynamic>(state, _state, action));
+      if (!_stateController.isClosed)
+        _stateController.add(new StoreChange<State, StateBuilder, dynamic>(
+            state, _state, action));
+
       _state = state;
     };
 

Diff for: lib/src/store.dart

@@ -1,26 +1,23 @@
 name: built_redux
-version: 7.4.1-dev
+version: 7.4.3-dev
 description:
   A state management library written in dart that enforces immutability
 authors:
 - David Marne <[email protected]>
 homepage: https://github.com/davidmarne/built_redux
 dependencies:
-  analyzer: '>=0.29.0 <0.32.0'
+  analyzer: '>=0.29.0 <0.33.0'
   build: ^0.12.0
   built_collection: '>=1.0.0 <4.0.0'
   built_value: ^5.2.0
   built_value_generator: ^5.2.0
   source_gen: '>=0.7.0 <0.9.0'
-  test: ^0.12.0
+  test: '>=0.12.0 <2.0.0'
 
 dev_dependencies:
-  build_runner: ^0.8.0
+  build_runner: ^0.9.0
   build_test: ^0.10.0
-  build_web_compilers: ^0.3.6
-  dart_dev: ^1.9.2
-  dart_style: ^1.0.0
-  coverage: ^0.11.0
+  build_web_compilers: ^0.4.0
 
 environment:
-  sdk: '>=2-0-0-dev <2.0.0'
+  sdk: '>=2-0-0-dev <2.0.0'

Diff for: pubspec.yaml

@@ -131,6 +131,17 @@ void main() {
       store.actions.increment(1);
     });
 
+    test('should not publish pending events if disposed', () async {
+      store.nextState.listen(expectAsync1((Counter _) {
+        expect(store.actions, isNotNull);
+      }));
+
+      store.actions.increment(1);
+
+      // intentionally don't wait
+      store.dispose();
+    });
+
     test('awaiting dispose', () async {
       await store.dispose();
       expect(store.state, null);