Skip to content

Commit 7db04ed

Browse files
Merge pull request #984 from Workiva/batch/react_18_upgrade/over_react
Rollout React 18 to tests and example apps
2 parents f4898d9 + 30f4288 commit 7db04ed

File tree

31 files changed

+35
-63
lines changed

31 files changed

+35
-63
lines changed

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ and add an HTML element with a unique identifier where you’ll mount your OverR
8585
// OverReact component render() output will show up here.
8686
</div>
8787
88-
<script src="packages/react/react.js"></script>
89-
<script src="packages/react/react_dom.js"></script>
88+
<script src="packages/react/js/react.dev.js"></script>
9089
9190
<!-- NOTE: "index" should correspond to the
9291
name of the `.dart` file that contains your `main()` entrypoint. -->
@@ -95,8 +94,8 @@ and add an HTML element with a unique identifier where you’ll mount your OverR
9594
</html>
9695
```
9796

98-
> __Note:__ When serving your application in production, use `packages/react/react_with_react_dom_prod.js`
99-
file instead of the un-minified `react.js` / `react_dom.js` files shown in the example above.
97+
> __Note:__ When serving your application in production, use `packages/react/js/react.min.js`
98+
file instead of the un-minified `packages/react/js/react.dev.js` file shown in the example above.
10099

101100
1. Import the `over_react` and `react_dom` libraries into `index.dart`. Then [build some components](#building-custom-components) and mount / render a React tree within the HTML element you created in the previous step by calling `react_dom.render()` within the `main()` entrypoint of your Dart application.
102101

app/over_react_redux/todo_client/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dependencies:
88
color: ^3.0.0
99
memoize: ^3.0.0
1010
meta: ^1.16.0
11-
over_react: '>=4.8.4 <6.0.0'
11+
over_react: ^5.4.5
1212
json_annotation: ^4.6.0
1313
redux: '>=3.0.0 <6.0.0'
1414
redux_dev_tools: '>=0.4.0 <0.8.0'
@@ -21,7 +21,7 @@ dev_dependencies:
2121
dart_dev: ^4.0.0
2222
glob: ^2.0.0
2323
json_serializable: ^6.0.0
24-
over_react_test: '>=2.10.2 <4.0.0'
24+
over_react_test: ^3.0.2
2525
pedantic: ^1.8.0
2626
test: ^1.15.7
2727
test_html_builder: ^3.0.0

app/over_react_redux/todo_client/test/unit/_templates/react_components_test_template.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<!-- See: https://pub.dev/packages/test_html_builder -->
22
<html>
33
<head>
4-
<script src="packages/react/react_with_addons.js"></script>
5-
<script src="packages/react/react_dom.js"></script>
4+
<script src="packages/react/js/react.dev.js"></script>
65
<script src="packages/todo_client/src/test_fixtures/mock_js_objects.js"></script>
76
<script src="https://unpkg.com/@material-ui/core/umd/material-ui.development.js" crossorigin="anonymous"></script>
87

app/over_react_redux/todo_client/test/unit/_templates/react_test_template.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<!-- See: https://pub.dev/packages/test_html_builder -->
22
<html>
33
<head>
4-
<script src="packages/react/react_with_addons.js"></script>
5-
<script src="packages/react/react_dom.js"></script>
4+
<script src="packages/react/js/react.dev.js"></script>
65

76
{{testScript}}
87

app/over_react_redux/todo_client/web/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313

1414
<div id="todo-container"></div>
1515

16-
<script src="packages/react/react.js"></script>
17-
<script src="packages/react/react_dom.js"></script>
16+
<script src="packages/react/js/react.dev.js"></script>
1817
<script src="https://unpkg.com/@material-ui/core/umd/material-ui.development.js" crossorigin="anonymous"></script>
1918

2019
<!-- Serve compiled output. -->

example/boilerplate_versions/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
<body>
3434
<div id="content"></div>
3535

36-
<script src="packages/react/react.js"></script>
37-
<script src="packages/react/react_dom.js"></script>
36+
<script src="packages/react/js/react.dev.js"></script>
3837

3938
<script type="application/javascript" defer src="main.dart.js"></script>
4039
</body>

example/builder/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
<body>
3434
<div id="content"></div>
3535

36-
<script src="packages/react/react.js"></script>
37-
<script src="packages/react/react_dom.js"></script>
36+
<script src="packages/react/js/react.dev.js"></script>
3837

3938
<script type="application/javascript" defer src="main.dart.js"></script>
4039
</body>

example/context/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
<body>
3434
<div id="content"></div>
3535

36-
<script src="packages/react/react.js"></script>
37-
<script src="packages/react/react_dom.js"></script>
36+
<script src="packages/react/js/react.dev.js"></script>
3837

3938
<script type="application/javascript" defer src="main.dart.js"></script>
4039
</body>

example/error_boundary/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
<body>
3434
<div id="content"></div>
3535

36-
<script src="packages/react/react_prod.js"></script>
37-
<script src="packages/react/react_dom_prod.js"></script>
36+
<script src="packages/react/js/react.min.js"></script>
3837

3938
<script type="application/javascript" defer src="main.dart.js"></script>
4039
</body>

example/hooks/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
<body>
3434
<div id="content"></div>
3535

36-
<script src="packages/react/react.js"></script>
37-
<script src="packages/react/react_dom.js"></script>
36+
<script src="packages/react/js/react.dev.js"></script>
3837

3938
<script type="application/javascript" defer src="main.dart.js"></script>
4039
</body>

0 commit comments

Comments
 (0)