Skip to content

Commit edb6095

Browse files
qianlifengqianlifeng
committed
refactor: remove build time logging from image and list item views
1 parent 5c502f8 commit edb6095

File tree

4 files changed

+0
-81
lines changed

4 files changed

+0
-81
lines changed

‎wox.ui.flutter/wox/lib/components/wox_image_view.dart‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ class WoxImageView extends StatelessWidget {
2020

2121
@override
2222
Widget build(BuildContext context) {
23-
final Stopwatch? buildStopwatch = LoggerSwitch.enableBuildTimeLog ? (Stopwatch()..start()) : null;
2423
late final Widget content;
2524

2625
if (woxImage.imageType == WoxImageTypeEnum.WOX_IMAGE_TYPE_URL.code) {
@@ -87,11 +86,6 @@ class WoxImageView extends StatelessWidget {
8786
content = const SizedBox(width: 24, height: 24);
8887
}
8988

90-
if (buildStopwatch != null) {
91-
buildStopwatch.stop();
92-
Logger.instance.debug(const UuidV4().generate(), "flutter build metric: image view ${woxImage.imageType} - ${buildStopwatch.elapsedMicroseconds}μs");
93-
}
94-
9589
return content;
9690
}
9791
}

‎wox.ui.flutter/wox/lib/components/wox_list_item_view.dart‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,6 @@ class WoxListItemView extends StatelessWidget {
9696

9797
@override
9898
Widget build(BuildContext context) {
99-
final Stopwatch? buildStopwatch = LoggerSwitch.enableBuildTimeLog ? (Stopwatch()..start()) : null;
100-
int? checkpoint1, checkpoint2, checkpoint3;
101-
10299
if (LoggerSwitch.enablePaintLog) Logger.instance.debug(const UuidV4().generate(), "repaint: list item view ${item.title} - container");
103100

104101
final bool isResultList = listViewType == WoxListViewTypeEnum.WOX_LIST_VIEW_TYPE_RESULT.code;
@@ -118,17 +115,12 @@ class WoxListItemView extends StatelessWidget {
118115
: (isActive ? woxTheme.resultItemActiveTitleColorParsed : woxTheme.resultItemTitleColorParsed);
119116
final Color subtitleColor = isActive ? woxTheme.resultItemActiveSubTitleColorParsed : woxTheme.resultItemSubTitleColorParsed;
120117

121-
if (buildStopwatch != null) checkpoint1 = buildStopwatch.elapsedMicroseconds;
122-
123118
// Build icon widget
124119
final Widget iconWidget =
125120
item.isGroup
126121
? const SizedBox()
127122
: Padding(padding: _iconPadding, child: SizedBox(width: _iconSize, height: _iconSize, child: WoxImageView(woxImage: item.icon, width: _iconSize, height: _iconSize)));
128123

129-
int? checkpointIcon;
130-
if (buildStopwatch != null) checkpointIcon = buildStopwatch.elapsedMicroseconds;
131-
132124
// Build title/subtitle widget
133125
final Widget textWidget = Expanded(
134126
child: Column(
@@ -145,21 +137,12 @@ class WoxListItemView extends StatelessWidget {
145137
),
146138
);
147139

148-
int? checkpointText;
149-
if (buildStopwatch != null) checkpointText = buildStopwatch.elapsedMicroseconds;
150-
151140
// Build tails widget
152141
final Widget? tailsWidget = item.tails.isNotEmpty ? buildTails() : null;
153142

154-
int? checkpointTails;
155-
if (buildStopwatch != null) checkpointTails = buildStopwatch.elapsedMicroseconds;
156-
157143
// Build quick select widget
158144
final Widget? quickSelectWidget = (item.isShowQuickSelect && item.quickSelectNumber.isNotEmpty) ? buildQuickSelectNumber() : null;
159145

160-
int? checkpointQuickSelect;
161-
if (buildStopwatch != null) checkpointQuickSelect = buildStopwatch.elapsedMicroseconds;
162-
163146
Widget content = Container(
164147
decoration: BoxDecoration(color: getBackgroundColor()),
165148
padding:
@@ -174,8 +157,6 @@ class WoxListItemView extends StatelessWidget {
174157
child: Row(children: [iconWidget, textWidget, if (tailsWidget != null) tailsWidget, if (quickSelectWidget != null) quickSelectWidget]),
175158
);
176159

177-
if (buildStopwatch != null) checkpoint2 = buildStopwatch.elapsedMicroseconds;
178-
179160
if (borderRadius != BorderRadius.zero) {
180161
content = ClipRRect(borderRadius: borderRadius, child: content);
181162
}
@@ -201,20 +182,6 @@ class WoxListItemView extends StatelessWidget {
201182
);
202183
}
203184

204-
if (buildStopwatch != null) {
205-
checkpoint3 = buildStopwatch.elapsedMicroseconds;
206-
buildStopwatch.stop();
207-
final iconTime = checkpointIcon! - checkpoint1!;
208-
final textTime = checkpointText! - checkpointIcon;
209-
final tailsTime = checkpointTails! - checkpointText;
210-
final quickSelectTime = checkpointQuickSelect! - checkpointTails;
211-
final containerTime = checkpoint2! - checkpointQuickSelect;
212-
Logger.instance.debug(
213-
const UuidV4().generate(),
214-
"flutter build metric: list item ${item.title} - total:${buildStopwatch.elapsedMicroseconds}μs, prep:${checkpoint1}μs, icon:${iconTime}μs, text:${textTime}μs, tails:${tailsTime}μs, qs:${quickSelectTime}μs, container:${containerTime}μs, wrap:${checkpoint3! - checkpoint2}μs",
215-
);
216-
}
217-
218185
return content;
219186
}
220187
}

‎wox.ui.flutter/wox/lib/components/wox_list_view.dart‎

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,14 @@ class WoxListView<T> extends StatelessWidget {
3636

3737
@override
3838
Widget build(BuildContext context) {
39-
final Stopwatch? buildStopwatch = LoggerSwitch.enableBuildTimeLog ? (Stopwatch()..start()) : null;
40-
int? cp1, cp2, cp3, cp4;
41-
4239
// Fast path: when showFilter is false, we don't need LayoutBuilder
4340
// because we don't need to measure available space for filter
4441
if (!showFilter) {
45-
if (buildStopwatch != null) cp1 = buildStopwatch.elapsedMicroseconds;
46-
4742
final itemHeight =
4843
listViewType == WoxListViewTypeEnum.WOX_LIST_VIEW_TYPE_ACTION.code || listViewType == WoxListViewTypeEnum.WOX_LIST_VIEW_TYPE_CHAT.code
4944
? WoxThemeUtil.instance.getActionItemHeight()
5045
: WoxThemeUtil.instance.getResultListViewHeightByCount(1);
5146

52-
if (buildStopwatch != null) cp2 = buildStopwatch.elapsedMicroseconds;
53-
5447
final listWidget = ConstrainedBox(
5548
constraints: BoxConstraints(maxHeight: maxHeight),
5649
child: Scrollbar(
@@ -128,26 +121,12 @@ class WoxListView<T> extends StatelessWidget {
128121
),
129122
);
130123

131-
if (buildStopwatch != null) {
132-
cp3 = buildStopwatch.elapsedMicroseconds;
133-
buildStopwatch.stop();
134-
final prepTime = (cp1 ?? 0);
135-
final heightTime = (cp2 ?? 0) - (cp1 ?? 0);
136-
final listTime = (cp3 ?? 0) - (cp2 ?? 0);
137-
Logger.instance.debug(
138-
const UuidV4().generate(),
139-
"flutter build metric: list view (fast) - total:${buildStopwatch.elapsedMicroseconds}μs, prep:${prepTime}μs, height:${heightTime}μs, list:${listTime}μs, items:${controller.items.length}",
140-
);
141-
}
142-
143124
return listWidget;
144125
}
145126

146127
// Slow path: with filter, need LayoutBuilder to measure available space
147128
return LayoutBuilder(
148129
builder: (context, constraints) {
149-
if (buildStopwatch != null) cp1 = buildStopwatch.elapsedMicroseconds;
150-
151130
const filterTopPadding = 6.0;
152131
const filterFieldHeight = 40.0;
153132
final hasBoundedHeight = constraints.hasBoundedHeight;
@@ -164,8 +143,6 @@ class WoxListView<T> extends StatelessWidget {
164143
? WoxThemeUtil.instance.getActionItemHeight()
165144
: WoxThemeUtil.instance.getResultListViewHeightByCount(1);
166145

167-
if (buildStopwatch != null) cp2 = buildStopwatch.elapsedMicroseconds;
168-
169146
// Build the list widget
170147
final listWidget = ConstrainedBox(
171148
constraints: BoxConstraints(maxHeight: listMaxHeight),
@@ -247,8 +224,6 @@ class WoxListView<T> extends StatelessWidget {
247224
),
248225
);
249226

250-
if (buildStopwatch != null) cp3 = buildStopwatch.elapsedMicroseconds;
251-
252227
// Build filter widget if needed
253228
Widget? filterWidget;
254229
if (canShowFilter) {
@@ -347,23 +322,7 @@ class WoxListView<T> extends StatelessWidget {
347322
);
348323
}
349324

350-
if (buildStopwatch != null) cp4 = buildStopwatch.elapsedMicroseconds;
351-
352325
final content = Column(mainAxisSize: MainAxisSize.min, children: [listWidget, if (filterWidget != null) filterWidget]);
353-
354-
if (buildStopwatch != null) {
355-
buildStopwatch.stop();
356-
final layoutTime = cp1 ?? 0;
357-
final prepTime = (cp2 ?? 0) - (cp1 ?? 0);
358-
final listTime = (cp3 ?? 0) - (cp2 ?? 0);
359-
final filterTime = (cp4 ?? 0) - (cp3 ?? 0);
360-
final columnTime = buildStopwatch.elapsedMicroseconds - (cp4 ?? 0);
361-
Logger.instance.debug(
362-
const UuidV4().generate(),
363-
"flutter build metric: list view - total:${buildStopwatch.elapsedMicroseconds}μs, layout:${layoutTime}μs, prep:${prepTime}μs, list:${listTime}μs, filter:${filterTime}μs, column:${columnTime}μs, items:${controller.items.length}",
364-
);
365-
}
366-
367326
return content;
368327
},
369328
);

‎wox.ui.flutter/wox/lib/utils/log.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ class Logger {
6565
class LoggerSwitch {
6666
static bool enablePaintLog = false;
6767
static bool enableSizeAndPositionLog = false;
68-
static bool enableBuildTimeLog = false;
6968
}
7069

7170
class WoxFileOutput extends xlogger.LogOutput {

0 commit comments

Comments
 (0)