Skip to content

Commit f513b39

Browse files
committed
fix: enable macOS notarization and Windows signpath in build workflow
1 parent 299a25e commit f513b39

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

.github/workflows/build-core.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ jobs:
288288
cache: true
289289

290290
- name: Enable Flutter desktop (Windows)
291-
shell: msys2 {0}
291+
shell: pwsh
292292
run: flutter config --enable-windows-desktop
293293

294294
- name: Build

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
build:
1515
uses: ./.github/workflows/build-core.yml
1616
with:
17-
require_macos_notarize: false
18-
require_windows_signpath: false
17+
require_macos_notarize: true
18+
require_windows_signpath: true
1919
artifact_retention_days: 10
2020
secrets: inherit

wox.core/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,7 @@ woxmr-sign:
126126
ifeq ($(PLATFORM),macos)
127127
@if [ -z "$(MACOS_SIGN_IDENTITY)" ]; then \
128128
echo "MACOS_SIGN_IDENTITY is empty; skip signing"; \
129-
exit 0; \
130-
fi
131-
@if [ -f "$(WOXMR_OUT_BUNDLE)" ]; then \
129+
elif [ -f "$(WOXMR_OUT_BUNDLE)" ]; then \
132130
echo "Signing with identity: $(MACOS_SIGN_IDENTITY)"; \
133131
codesign --force --sign "$(MACOS_SIGN_IDENTITY)" --timestamp=none "$(WOXMR_OUT_BUNDLE)"; \
134132
else \

0 commit comments

Comments
 (0)