refactor: change vec to slice inside write function

Signed-off-by: addrian-77 <lunguadrian30@gmail.com>

Author: addrian-77

tockloader-lib/src/command_impl/erase_apps.rs

@@ -7,7 +7,7 @@ use crate::{CommandEraseApps, IO};
 #[async_trait]
 impl CommandEraseApps for TockloaderConnection {
     async fn erase_apps(&mut self) -> Result<(), TockloaderError> {
-        self.write(self.get_settings().start_address, vec![0u8])
+        self.write(self.get_settings().start_address, &[0u8])
             .await
     }
 }

tockloader-lib/src/command_impl/generalized.rs

@@ -15,7 +15,7 @@ impl IO for TockloaderConnection {
         }
     }
 
-    async fn write(&mut self, address: u64, pkt: Vec<u8>) -> Result<(), TockloaderError> {
+    async fn write(&mut self, address: u64, pkt: &[u8]) -> Result<(), TockloaderError> {
         match self {
             TockloaderConnection::ProbeRS(conn) => conn.write(address, pkt).await,
             TockloaderConnection::Serial(conn) => conn.write(address, pkt).await,

tockloader-lib/src/command_impl/install.rs

@@ -20,7 +20,7 @@ impl CommandInstall for TockloaderConnection {
         // obtain the binaries in a vector
         let mut app_binaries: Vec<Vec<u8>> = Vec::new();
 
-        let mut address = self.get_settings().start_address;
+        let mut address = settings.start_address;
         for app in app_attributes_list.iter() {
             app_binaries.push(
                 self.read(address, app.tbf_header.total_size() as usize)
@@ -36,7 +36,7 @@ impl CommandInstall for TockloaderConnection {
         tock_app_list.push(app.clone());
 
         app_binaries.push(
-            tab.extract_binary(self.get_settings().arch.clone().unwrap())
+            tab.extract_binary(settings.arch.clone().unwrap())
                 .unwrap(),
         );
 
@@ -46,7 +46,7 @@ impl CommandInstall for TockloaderConnection {
         let pkt = create_pkt(configuration, app_binaries);
 
         // write the pkt
-        let _ = self.write(self.get_settings().start_address, pkt).await;
+        let _ = self.write(settings.start_address, &pkt).await;
         Ok(())
     }
 }

tockloader-lib/src/command_impl/probers/io.rs

@@ -22,14 +22,14 @@ impl IO for ProbeRSConnection {
         Ok(appdata)
     }
 
-    async fn write(&mut self, address: u64, pkt: Vec<u8>) -> Result<(), TockloaderError> {
+    async fn write(&mut self, address: u64, pkt: &[u8]) -> Result<(), TockloaderError> {
         if !self.is_open() {
             return Err(InternalError::ConnectionNotOpen.into());
         }
         let session = self.session.as_mut().expect("Board must be open");
         let mut loader = session.target().flash_loader();
 
-        loader.add_data(address, &pkt)?;
+        loader.add_data(address, pkt)?;
 
         let mut options = DownloadOptions::default();
         options.keep_unwritten_bytes = true;

tockloader-lib/src/command_impl/serial/io.rs

@@ -36,10 +36,10 @@ impl IO for SerialConnection {
         Ok(appdata)
     }
 
-    async fn write(&mut self, address: u64, pkt: Vec<u8>) -> Result<(), TockloaderError> {
+    async fn write(&mut self, address: u64, pkt: &[u8]) -> Result<(), TockloaderError> {
         let settings = self.get_settings();
         let stream = self.stream.as_mut().expect("Board must be open");
-        let mut binary = pkt.clone();
+        let mut binary = pkt.to_vec();
 
         if !binary.len().is_multiple_of(settings.page_size as usize) {
             binary.extend(vec![

tockloader-lib/src/lib.rs

@@ -59,7 +59,7 @@ pub trait CommandEraseApps {
 pub trait IO: Send {
     async fn read(&mut self, address: u64, size: usize) -> Result<Vec<u8>, TockloaderError>;
 
-    async fn write(&mut self, address: u64, pkt: Vec<u8>) -> Result<(), TockloaderError>;
+    async fn write(&mut self, address: u64, pkt: &[u8]) -> Result<(), TockloaderError>;
 }
 
 #[async_trait]