fix: the program distinguishes padding from app

Signed-off-by: Mohamed Daoudo <mohamed.daoudo@stud.fils.upb.ro>

Author: Joan-DwD

tockloader-lib/src/attributes/app_attributes.rs

@@ -112,11 +112,19 @@ impl AppAttributes {
             // The end of the application binary marks the beginning of the
             // footer.
             //
-            // TODO(george-cosma): This is not always true, `get_binary_end`
+            // Note: This is not always true, `get_binary_end`
             // does not make sense if the application is just padding. This can
             // crash the process.
             let binary_end_offset = header.get_binary_end();
 
+            match &header {
+                TbfHeader::TbfHeaderV2(_hd) => {}
+                _ => {
+                    appaddr += total_size as u64;
+                    continue;
+                }
+            };
+
             let mut footers: Vec<TbfFooter> = vec![];
             let total_footers_size = total_size - binary_end_offset;
             let mut footer_offset = binary_end_offset;
@@ -234,6 +242,14 @@ impl AppAttributes {
                 .map_err(TockError::InvalidAppTbfHeader)?;
             let binary_end_offset = header.get_binary_end();
 
+            match &header {
+                TbfHeader::TbfHeaderV2(_hd) => {}
+                _ => {
+                    appaddr += total_size as u64;
+                    continue;
+                }
+            };
+
             let mut footers: Vec<TbfFooter> = vec![];
             let total_footers_size = total_size - binary_end_offset;
             let mut footer_offset = binary_end_offset;