fix: clippy warnings from update of clippy

Signed-off-by: George Cosma <george.cosma@wyliodrin.com>

Author: George Cosma

tbf-parser/src/types.rs

@@ -94,21 +94,19 @@ impl fmt::Debug for TbfParseError {
         match self {
             TbfParseError::NotEnoughFlash => write!(f, "Buffer too short to parse TBF header"),
             TbfParseError::UnsupportedVersion(version) => {
-                write!(f, "TBF version {} unsupported", version)
+                write!(f, "TBF version {version} unsupported")
             }
             TbfParseError::ChecksumMismatch(app, calc) => write!(
                 f,
-                "Checksum verification failed: app:{:#x}, calc:{:#x}",
-                app, calc
+                "Checksum verification failed: app:{app:#x}, calc:{calc:#x}"
             ),
-            TbfParseError::BadTlvEntry(tipe) => write!(f, "TLV entry type {} is invalid", tipe),
+            TbfParseError::BadTlvEntry(tipe) => write!(f, "TLV entry type {tipe} is invalid"),
             TbfParseError::BadProcessName => write!(f, "Process name not UTF-8"),
             TbfParseError::InternalError => write!(f, "Internal kernel error. This is a bug."),
             TbfParseError::TooManyEntries(tipe) => {
                 write!(
                     f,
-                    "There are too many variable entries of {} for Tock to parse",
-                    tipe
+                    "There are too many variable entries of {tipe} for Tock to parse"
                 )
             }
             TbfParseError::PackageNameTooLong => write!(f, "The package name is too long."),

tock-process-console/src/ui_management/pages/setup_page/setup_page_structure.rs

@@ -207,7 +207,7 @@ impl ComponentRender<()> for SetupPage {
 
         let available_ports = match tokio_serial::available_ports() {
             Ok(ports) => ports,
-            Err(error) => panic!("Error while searching for ports: {}", error),
+            Err(error) => panic!("Error while searching for ports: {error}"),
         };
 
         let mut vec_serial: Vec<Text> = vec![];
@@ -261,7 +261,7 @@ impl ComponentRender<()> for SetupPage {
                         .borders(Borders::ALL)
                         .border_type(BorderType::Rounded)
                         .fg(Color::Yellow)
-                        .title(format!(" Number of boards found: {}  ", boards_found))
+                        .title(format!(" Number of boards found: {boards_found}  "))
                         .title_style(Style::default().fg(Color::Blue)),
                 )
                 .highlight_style(Style::default().add_modifier(Modifier::BOLD))
@@ -275,12 +275,12 @@ impl ComponentRender<()> for SetupPage {
         if self.show_state == ShowState::ShowBoardsOnly {
             match self.probeinfo_sender.send(board_ports) {
                 Ok(data) => data,
-                Err(error) => println!("{}", error),
+                Err(error) => println!("{error}"),
             };
         } else if self.show_state == ShowState::ShowAllSerialPorts {
             match self.probeinfo_sender.send(serial_ports) {
                 Ok(data) => data,
-                Err(error) => println!("{}", error),
+                Err(error) => println!("{error}"),
             };
         }
 
@@ -374,7 +374,7 @@ impl ComponentRender<()> for SetupPage {
         frame.render_widget(help_text, help_text_h);
 
         let error = if let Some(error) = &self.properties.error_message {
-            Text::from(format!("Error: {}", error))
+            Text::from(format!("Error: {error}"))
         } else {
             Text::from("")
         };

tock-process-console/src/ui_management/pages/terminal_page/section/usage.rs

@@ -16,7 +16,7 @@ pub struct UsageInfo {
 }
 
 fn key_to_span<'a>(key: &String) -> Span<'a> {
-    Span::from(format!("( {} )", key)).bold()
+    Span::from(format!("( {key} )")).bold()
 }
 
 pub fn widget_usage_to_text<'a>(usage: UsageInfo) -> Text<'a> {

tockloader-cli/src/display.rs

@@ -5,6 +5,8 @@
 use tockloader_lib::attributes::app_attributes::AppAttributes;
 use tockloader_lib::attributes::system_attributes::SystemAttributes;
 
+// TODO(george-cosma): Fix this
+#[allow(clippy::uninlined_format_args)]
 pub async fn print_list(app_details: &[AppAttributes]) {
     for (i, details) in app_details.iter().enumerate() {
         println!("\n\x1b[0m\x1b[1;35m ┏━━━━━━━━━━━━━━━━┓");
@@ -40,6 +42,8 @@ pub async fn print_list(app_details: &[AppAttributes]) {
     }
 }
 
+// TODO(george-cosma): Fix this
+#[allow(clippy::uninlined_format_args)]
 pub async fn print_info(app_details: &mut [AppAttributes], system_details: &mut SystemAttributes) {
     for (i, details) in app_details.iter().enumerate() {
         println!("\n\x1b[0m\x1b[1;35m ┏━━━━━━━━━━━━━━━━┓");

tockloader-lib/src/command_impl/probers/install.rs

@@ -131,7 +131,7 @@ impl CommandInstall for ProbeRSConnection {
         }
 
         for i in valid_pages {
-            println!("Writing page number {}", i);
+            println!("Writing page number {i}");
             // Create the packet that we send to the bootloader. First four
             // bytes are the address of the page
             let mut pkt = Vec::new();