refactor: remove read_binary

Signed-off-by: addrian-77 <lunguadrian30@gmail.com>

Author: addrian-77

tockloader-lib/src/attributes/app_attributes.rs

@@ -17,7 +17,7 @@ use crate::errors::{TockError, TockloaderError};
 /// All data is stored either within [TbfHeader]s, or [TbfFooter]s.
 ///
 /// See also <https://book.tockos.org/doc/tock_binary_format>
-#[derive(Debug, Clone)]
+#[derive(Debug)]
 pub struct AppAttributes {
     pub address: u64,
     pub tbf_header: TbfHeader,

tockloader-lib/src/command_impl/install.rs

@@ -18,25 +18,28 @@ impl CommandInstall for TockloaderConnection {
         let app_attributes_list: Vec<AppAttributes> = self.list(settings).await.unwrap();
         let mut tock_app_list = app_attributes_list
             .iter()
-            .map(|app| TockApp::from_app_attributes(app, settings))
+            .map(TockApp::from_app_attributes)
             .collect::<Vec<TockApp>>();
 
         // obtain the binaries in a vector
         let mut app_binaries: Vec<Vec<u8>> = Vec::new();
 
-        for app in tock_app_list.iter() {
-            app_binaries.push(app.clone().read_binary(self).await.unwrap())
+        let mut address = settings.start_address;
+        for app in app_attributes_list.iter() {
+            app_binaries.push(
+                self.read(address, app.tbf_header.total_size() as usize)
+                    .await
+                    .unwrap(),
+            );
+            address += app.tbf_header.total_size() as u64;
         }
 
         let mut app = TockApp::from_tab(&tab, settings).unwrap();
 
         app.replace_idx(tock_app_list.len());
         tock_app_list.push(app.clone());
 
-        app_binaries.push(
-            tab.extract_binary(settings.arch.as_ref().unwrap().as_str())
-                .unwrap(),
-        );
+        app_binaries.push(tab.extract_binary(settings.arch.clone().unwrap()).unwrap());
 
         let configuration = reshuffle_apps(settings, tock_app_list).unwrap();