fix: clippy errors

Signed-off-by: addrian-77 <lunguadrian30@gmail.com>

Author: addrian-77

tockloader-cli/src/main.rs

@@ -18,7 +18,8 @@ use tockloader_lib::connection::{
 use tockloader_lib::known_boards::KnownBoard;
 use tockloader_lib::tabs::tab::Tab;
 use tockloader_lib::{
-    list_debug_probes, list_serial_ports, CommandInfo, CommandInstall, CommandList, CommandEraseApps,
+    list_debug_probes, list_serial_ports, CommandEraseApps, CommandInfo, CommandInstall,
+    CommandList,
 };
 
 fn get_serial_target_info(user_options: &ArgMatches) -> SerialTargetInfo {
@@ -235,7 +236,7 @@ async fn main() -> Result<()> {
 
             conn.erase_apps(&settings)
                 .await
-                .context("Failed to erase apps.")?; 
+                .context("Failed to erase apps.")?;
         }
         _ => {
             println!("Could not run the provided subcommand.");

tockloader-lib/src/command_impl/generalized.rs

@@ -6,7 +6,7 @@ use crate::board_settings::BoardSettings;
 use crate::connection::TockloaderConnection;
 use crate::errors::TockloaderError;
 use crate::tabs::tab::Tab;
-use crate::{CommandInfo, CommandInstall, CommandList, CommandEraseApps};
+use crate::{CommandEraseApps, CommandInfo, CommandInstall, CommandList};
 
 #[async_trait]
 impl CommandList for TockloaderConnection {
@@ -50,13 +50,10 @@ impl CommandInstall for TockloaderConnection {
 
 #[async_trait]
 impl CommandEraseApps for TockloaderConnection {
-    async fn erase_apps(
-        &mut self,
-        settings: &BoardSettings,
-    ) -> Result<(), TockloaderError> {
+    async fn erase_apps(&mut self, settings: &BoardSettings) -> Result<(), TockloaderError> {
         match self {
             TockloaderConnection::ProbeRS(conn) => conn.erase_apps(settings).await,
             TockloaderConnection::Serial(_conn) => todo!(),
         }
     }
-}
+}

tockloader-lib/src/command_impl/probers/erase_apps.rs

@@ -1,7 +1,7 @@
 use async_trait::async_trait;
 use probe_rs::flashing::DownloadOptions;
-use probe_rs::{MemoryInterface};
-use tbf_parser::parse::{parse_tbf_header_lengths};
+use probe_rs::MemoryInterface;
+use tbf_parser::parse::parse_tbf_header_lengths;
 
 use crate::board_settings::BoardSettings;
 use crate::connection::{Connection, ProbeRSConnection};
@@ -10,10 +10,7 @@ use crate::CommandEraseApps;
 
 #[async_trait]
 impl CommandEraseApps for ProbeRSConnection {
-    async fn erase_apps(
-        &mut self,
-        settings: &BoardSettings,
-    ) -> Result<(), TockloaderError> {
+    async fn erase_apps(&mut self, settings: &BoardSettings) -> Result<(), TockloaderError> {
         if !self.is_open() {
             return Err(InternalError::ConnectionNotOpen.into());
         }
@@ -29,22 +26,17 @@ impl CommandEraseApps for ProbeRSConnection {
 
             board_core.read(appaddr, &mut appdata)?;
 
-            let app_size: u32;
-
             // The first 8 bytes of the application data contain the TBF header
             // lengths and version.
             //
             // Note on expect: `read` always fills up the entire buffer, which
             // was previously declared as 8 bytes.
-            log::info!("app data? {:?}", appdata);
-            match parse_tbf_header_lengths(
+            let app_size: u32 = match parse_tbf_header_lengths(
                 &appdata
                     .try_into()
                     .expect("Buffer length must be at least 8 bytes long."),
             ) {
-                Ok(data) => {
-                    app_size = data.2;
-                }
+                Ok(data) => data.2,
                 _ => break,
             };
 
@@ -55,18 +47,15 @@ impl CommandEraseApps for ProbeRSConnection {
         let mut loader = session.target().flash_loader();
 
         let address = settings.start_address;
-        // (adi): fill the memory with total_size values of 0xFF
+        // (adi): fill the memory with total_size values of 0x0
         let buffer = [0x0].repeat(total_size as usize);
-        loader.add_data(
-            (address as u32).into(),
-            &buffer
-        )?;
-        
+        loader.add_data((address as u32).into(), &buffer)?;
+
         let mut options = DownloadOptions::default();
         options.keep_unwritten_bytes = true;
-        
+
         // Finally, the data can be programmed
         loader.commit(session, options)?;
         Ok(())
     }
-}
+}

tockloader-lib/src/command_impl/probers/mod.rs

@@ -1,4 +1,4 @@
 pub mod erase_apps;
 pub mod info;
 pub mod install;
-pub mod list;
+pub mod list;

tockloader-lib/src/lib.rs

@@ -62,8 +62,5 @@ pub trait CommandInstall {
 
 #[async_trait]
 pub trait CommandEraseApps {
-    async fn erase_apps(
-        &mut self,
-        settings: &BoardSettings,
-    ) -> Result<(), TockloaderError>;
-}
+    async fn erase_apps(&mut self, settings: &BoardSettings) -> Result<(), TockloaderError>;
+}