Add and send PathFindCloseRequest

Author: DominiqueBlomsma

src/Services/XummOrderService.cs

@@ -188,7 +188,7 @@ public async Task<string> GetRefundRedirectUrlAsync(Guid orderGuid, decimal amou
                     Flags = XrplPaymentFlags.tfNoDirectRipple
                 };
 
-                var pathFindRequest = new PathFindRequest
+                var pathFindRequest = new PathFindCreateRequest
                 {
                     SourceAccount = _xummPaymentSettings.XrplAddress,
                     DestinationAccount = paymentPayload.Response.Account

src/WebSocket/IXrplWebSocket.cs

@@ -8,5 +8,5 @@ namespace Nop.Plugin.Payments.Xumm.WebSocket;
 public interface IXrplWebSocket
 {
     Task<List<AccountTrustLine>> GetAccountTrustLines(string account, bool throwError = false);
-    Task<(decimal?,XrplPaymentPathSpecification[][]?)> GetDestinationAmountAndPathsAsync(PathFindRequest pathFindRequest, bool hasCounterParty);
+    Task<(decimal?,XrplPaymentPathSpecification[][]?)> GetDestinationAmountAndPathsAsync(PathFindCreateRequest pathFindRequest, bool hasCounterParty);
 }

src/WebSocket/Models/PathFindCloseRequest.cs

@@ -0,0 +1,9 @@
+namespace Nop.Plugin.Payments.Xumm.WebSocket.Models;
+
+public class PathFindCloseRequest : BaseRequest
+{
+    public PathFindCloseRequest() : base("path_find")
+    {
+        SubCommand = "close";
+    }
+}

src/WebSocket/Models/PathFindCreateRequest.cs

@@ -0,0 +1,64 @@
+using System.Globalization;
+using System.Text.Json.Serialization;
+using XUMM.NET.SDK.Extensions;
+using XUMM.NET.SDK.Models.Payload.XRPL;
+
+namespace Nop.Plugin.Payments.Xumm.WebSocket.Models;
+
+public class PathFindCreateRequest : BaseRequest
+{
+    public PathFindCreateRequest() : base("path_find")
+    {
+        SubCommand = "create";
+    }
+
+    /// <summary>
+    /// 
+    /// </summary>
+    [JsonPropertyName("source_account")]
+    public string SourceAccount { get; set; }
+
+    /// <summary>
+    /// 
+    /// </summary>
+    [JsonPropertyName("destination_account")]
+    public string DestinationAccount { get; set; }
+
+    /// <summary>
+    /// 
+    /// </summary>
+    [JsonPropertyName("destination_amount")]
+    public object? DestinationAmount { get; set; }
+
+    [JsonPropertyName("send_max")]
+    public object? SendMax { get; set; }
+
+    public void SetDestinationToXrp()
+    {
+        DestinationAmount = "-1";
+    }
+
+    public void SetDestinationAmountToCounterParty(string currency, string issuer)
+    {
+        DestinationAmount = new XrplTransactionCurrencyAmount
+        {
+            Currency = currency,
+            Value = "-1",
+            Issuer = issuer
+        };
+    }
+    public void SetSendMaxAmount(decimal amount)
+    {
+        SendMax = amount.XrpToDropsString();
+    }
+
+    public void SetSendMaxAmount(string currency, decimal amount, string issuer)
+    {
+        SendMax = new XrplTransactionCurrencyAmount
+        {
+            Currency = currency,
+            Value = amount.ToString(CultureInfo.InvariantCulture),
+            Issuer = issuer
+        };
+    }
+}

src/WebSocket/XrplWebSocket.cs

@@ -44,7 +44,7 @@ public XrplWebSocket(ILogger logger)
 
     #region Methods
 
-    public async Task<(decimal?, XrplPaymentPathSpecification[][]?)> GetDestinationAmountAndPathsAsync(PathFindRequest pathFindRequest, bool hasCounterParty)
+    public async Task<(decimal?, XrplPaymentPathSpecification[][]?)> GetDestinationAmountAndPathsAsync(PathFindCreateRequest pathFindRequest, bool hasCounterParty)
     {
         decimal? destinationAmount = null;
         XrplPaymentPathSpecification[][]? paths = null;
@@ -84,7 +84,8 @@ public XrplWebSocket(ILogger logger)
 
                 var jsonElement = JsonSerializer.Deserialize<JsonElement>(ms);
 
-
+                // Wait until we receive the best path for the current ledger
+                // https://xrpl.org/path_find.html#asynchronous-follow-ups
                 if (!jsonElement.TryGetProperty("full_reply", out var fullReplyElement) || !fullReplyElement.GetBoolean() ||
                     !jsonElement.TryGetProperty("alternatives", out var alternativesElement))
                 {
@@ -96,37 +97,41 @@ public XrplWebSocket(ILogger logger)
                     if (alternative.TryGetProperty("paths_computed", out var pathsComputedElement))
                     {
                         paths = pathsComputedElement.Deserialize<XrplPaymentPathSpecification[][]>();
-                        
-                        if (paths != null)
+
+                        if (paths == null)
                         {
-                            if (alternative.TryGetProperty("destination_amount", out var destinationAmountElement))
-                            {
-                                if (hasCounterParty)
-                                {
-                                    var currencyAmount = destinationAmountElement.Deserialize<XrplTransactionCurrencyAmount>();
-                                    destinationAmount = currencyAmount?.Value.XrplStringNumberToDecimal();
-                                }
-                                else
-                                {
-                                    var currencyAmount = destinationAmountElement.GetString();
-                                    if (currencyAmount != null)
-                                    {
-                                        destinationAmount = currencyAmount.XrpDropsToDecimal();
-                                    }
-                                }
-                            }
+                            continue;
+                        }
 
-                            if (destinationAmount == null)
+                        if (alternative.TryGetProperty("destination_amount", out var destinationAmountElement))
+                        {
+                            if (hasCounterParty)
                             {
-                                // Couldn't determine the amount to deliver for the found paths
-                                paths = null;
+                                var currencyAmount = destinationAmountElement.Deserialize<XrplTransactionCurrencyAmount>();
+                                destinationAmount = currencyAmount?.Value.XrplStringNumberToDecimal();
                             }
                             else
                             {
-                                source.Cancel();
-                                break;
+                                var currencyAmount = destinationAmountElement.GetString();
+                                if (currencyAmount != null)
+                                {
+                                    destinationAmount = currencyAmount.XrpDropsToDecimal();
+                                }
                             }
                         }
+
+                        if (destinationAmount == null)
+                        {
+                            // Couldn't determine the amount to deliver for the found paths
+                            paths = null;
+                        }
+                        else
+                        {
+                            await SendMessageAsync(webSocket, new PathFindCloseRequest());
+
+                            source.Cancel();
+                            break;
+                        }
                     }
                 }
             }