Skip to content

Commit 49d82dc

Browse files
committed
respond to comments
1 parent 1f54578 commit 49d82dc

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

scripts/validate_xls_template.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def _validate_subsections(
546546
"Ownership",
547547
"Reserves",
548548
"Deletion",
549-
"RPC Name"
549+
"RPC Name",
550550
}
551551

552552
# For existing transactions, make Transaction Fee optional

templates/AMENDMENT_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ _[If your specification introduces new ledger entry objects, document each entry
4242

4343
_[If your specification introduces new ledger entry common fields, you can have a section called `Transaction: Common Fields` before listing out any specific transactions.]_
4444

45-
_[**Note for existing ledger entries:** If you are documenting changes to an existing ledger entry type that is already deployed on the XRPL mainnet (e.g., AccountRoot, RippleState, Offer, etc.), the following subsections are **optional**: Ownership (2.4), Reserves (2.5), Deletion (2.6), and RPC Name (2.10). You only need to include these subsections if you are making changes to those aspects of the ledger entry.]_
45+
_[**Note for existing ledger entries:** If you are documenting changes to an existing ledger entry type that is already deployed on the XRPL mainnet (e.g., AccountRoot, RippleState, Offer, etc.), the following subsections are **optional**: Object Identifier (2.1), Ownership (2.4), Reserves (2.5), Deletion (2.6), and RPC Name (2.10). You only need to include these subsections if you are making changes to those aspects of the ledger entry.]_
4646

47-
### 2.1. Object Identifier
47+
### 2.1. Object Identifier _(Optional if ledger entry already exists on XRPL)_
4848

4949
**Key Space:** `0x[XXXX]` _[Specify the 16-bit hex value for the key space]_
5050

0 commit comments

Comments
 (0)