Skip to content

Commit d9bf5f2

Browse files
authored
Merge branch 'master' into 68v2
2 parents bf9eba0 + d4fe36f commit d9bf5f2

File tree

2 files changed

+98
-40
lines changed

2 files changed

+98
-40
lines changed

.github/workflows/validate-xls.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
7878
- name: Get changed XLS files
7979
id: changed-files
80-
uses: tj-actions/changed-files@v45
80+
uses: tj-actions/changed-files@v47
8181
with:
8282
files: |
8383
XLS-*/README.md

CONTRIBUTING.md

Lines changed: 97 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,79 +1,137 @@
1-
# CONTRIBUTING
1+
# Contributing to XRPL Standards
22

3-
> [!IMPORTANT]
4-
> This process is in a state of flux right now, and this document is still referring to the old process. Please refer to [XLS-1](./XLS-0001-xls-process/README.md) instead.
3+
> [!NOTE]
4+
> This document summarizes how to contribute new XRP Ledger Standards (XLSes). The authoritative, detailed definition of the process is **[XLS-1: XLS Process and Guidelines](./XLS-0001-xls-process/README.md)**. If anything here conflicts with XLS-1, XLS-1 wins.
55
66
The work of the [XRP Ledger](https://xrpl.org) community is open, collaborative, and welcoming of all contributors participating in good faith. Part of that effort involves standardization, and this document outlines how anyone can contribute to that process.
77

8-
## Licensing
8+
## 1. Licensing
99

1010
Any XRPL Standards document can be referred to interchangeably as an "XLS", "XRPL Standard", or "document". Copyright on all content is subject to the terms of this [license](LICENSE), and all contributors grant everyone a royalty-free license to use their contributions, including the following grants:
1111

12-
- Copyright: a royalty-free license to anyone to use any contributions submitted to this repository.
13-
- Patent: a commitment to license on a royalty-free basis any essential patent claims relating to any contributions in this repository.
12+
- **Copyright**: a royalty-free license to anyone to use any contributions submitted to this repository.
13+
- **Patent**: a commitment to license on a royalty-free basis any essential patent claims relating to any contributions in this repository.
1414

15-
## Specification Process
15+
## 2. Overview of the XLS process (per XLS-1)
1616

17-
### 1. Start a Discussion & Gather Feedback
17+
XLS-1 defines both **categories** of XLSes and their **lifecycle statuses**.
1818

19-
Before opening a PR with any kind of formal proposal, please first gather community input by starting a [Discussion](https://github.com/XRPLF/XRPL-Standards/discussions). Discussions are suitable for early work-in-progress: ask, suggest, add, and make sweeping changes. Collecting such feedback helps to refine your concept, and is required in order to move forward in the specification process.
19+
- **Categories** (`category` field in the XLS preamble):
20+
- `Amendment`: changes that require an XRP Ledger amendment.
21+
- `System`: changes that affect XRPL protocol behavior (RPCs, P2P, etc.) but do not require an amendment.
22+
- `Ecosystem`: off-chain or community standards (metadata, registries, etc.).
23+
- `Meta`: standards about the XLS process itself (like XLS-1).
2024

21-
#### Discussion Title
25+
- **Statuses** (`status` field in the XLS preamble):
26+
- `Idea`: pre-draft, typically discussed only in GitHub Discussions.
27+
- `Proposal`: a fairly fleshed-out proposal, still only in Discussions.
28+
- `Draft`: the first formally tracked stage in this repo; XLS numbers are assigned here by XLS Editors.
29+
- `Final`: the final, stable form of the XLS. Only errata and non-normative clarifications may be added.
30+
- `Living`: a spec intended to be continuously updated (for example, XLS-1 itself).
31+
- `Deprecated`: a `Final` XLS that is no longer recommended.
32+
- `Stagnant`: a `Draft` that has seen no activity for a long period.
33+
- `Withdrawn`: withdrawn by the author(s); cannot be resurrected under the same XLS number.
2234

23-
When creating a new discussion for your idea, the discussion title should follow the naming convention `[{Category} {Idea/Proposal} {Title}]`, where `{Category}` is one of `Amendment`, `System`, `Ecosystem`, or `Meta` (depending on what type of spec it is), `{Idea/Proposal}` is either `Idea` or `Proposal` (depending on how fleshed out the idea is), and `{Title}` is a descriptive title for the proposed document.
35+
The sections below explain how to move through these stages. For all edge cases and full definitions, see [XLS-1 §4: XLS Process](./XLS-0001-xls-process/README.md#4-xls-process).
2436

25-
### 2. Closing a Discussion
37+
## 3. Start with a GitHub Discussion (Idea / Proposal)
2638

27-
When a discussion has produced a well-refined standard, authors should post a comment to the discussion noting that the discussion will be closed in a few days. This allows time (for those engaged with the discussion) to submit final commentary.
39+
Before opening a PR with any kind of formal proposal, **start with a GitHub Discussion**.
2840

29-
Once this waiting period has elapsed, the standard's author may close the discussion from further comment, and then move the discussion to a [**specification pull request**](#3-specification-pull-requests) to add the standard into the repository as a markdown file (see below for specification formats).
41+
1. Go to the [XRPL-Standards Discussions](https://github.com/XRPLF/XRPL-Standards/discussions).
42+
2. Choose a category that matches your intended XLS `category`:
43+
- `Amendment`, `System`, `Ecosystem`, or `Meta`.
44+
3. Use the **status** in your title to indicate maturity:
45+
- For early concepts, treat them as **Ideas**.
46+
- Once the concept is fairly fleshed out, treat it as a **Proposal**.
3047

31-
Next, the discussion author should edit the discussion to include a link to the PR. The last comment on the discussion should also be a link to the PR.
48+
#### 3.1. Discussion titles
3249

33-
The intention of this workflow is that the discussion be closed from further comments, with further comments instead being posted on the PR for fine-tuning and alignment with implementation or adoption, as appropriate.
50+
To make Discussions easier to scan, we recommend titles of the form:
3451

35-
### 3. Specification Pull Requests
52+
```text
53+
[<Category> <Idea|Proposal>: <Short descriptive title>]
54+
```
3655

37-
When opening a specification PR, there are two document types: _Drafts_ and _Candidate Specifications_. The type and status of any particular document has no bearing on the priority of that document. Typically, the further along in the process, the more likely it is that any particular XLS will be implemented or adopted.
56+
For example:
3857

39-
#### Drafts
58+
- `[Amendment Idea: In-ledger governance tokens]`
59+
- `[Ecosystem Proposal: Extended validator TOML metadata]`
4060

41-
A _Draft_ is a document that proposes some new feature, protocol or idea related to the XRP Ledger. The criteria for getting the document merged is minimal: project maintainers will review the document to ensure style conformance and applicability, but will otherwise not require editorial fixes before allowing it to be published.
61+
This keeps the Discussion aligned with the `category` and `status` terminology from XLS-1.
4262

43-
A document does not need to have an implementation in order to become a Draft. A Draft may or may not have implementation(s) available and no code is required prior to the Draft being published.
63+
#### 3.2. Gather feedback and iterate
4464

45-
A Draft is often stable enough for people to experiment with, but has not necessarily been endorsed by the entire community. When there are competing Drafts that address the same problem in different ways, all such Drafts can continue to be refined, promoted, and used independently, without any blocking. Implementors can create software to implement this type of standard into their codebase to explore how it works in a real world setting.
65+
Discussions are the right place for early work-in-progress: ask questions, propose alternatives, and make sweeping changes. Collecting such feedback is required before moving forward in the specification process.
4666

47-
Any, or all, competing Drafts _may_ graduate into a Candidate Specification.
67+
When your idea has converged into a coherent design and has community interest, you are ready to move toward a **Draft XLS** via a PR.
4868

49-
Notice that a Draft is not a [rubber-stamp](https://idioms.thefreedictionary.com/rubber-stamp) of the content in any particular document. Documents can still undergo significant changes and potentially be discarded all together.
69+
#### 3.3. Closing or archiving Discussions
5070

51-
##### Publishing a Draft
71+
XLS-1 defines rules for stale proposals and ideas (see [§4.5](./XLS-0001-xls-process/README.md#45-stale-proposalsideas)). In short:
5272

53-
To publish a new Draft, submit a Pull Request to this repo with a new folder and a new Markdown file. The folder MUST follow the naming convention `XLS-draft-{title}` where `{title}` is a lower case title with spaces replaced by hyphens (`-`). An example draft name is: `XLS-20d-non-fungible-token-support-native`
73+
- Discussions are checked for staleness after 90 days.
74+
- If there is no activity for another 30 days, they may be closed and locked.
75+
- Authors can ask maintainers to reopen stale Discussions later.
5476

55-
The submission must follow the template in [XLS_TEMPLATE.md](./templates/XLS_TEMPLATE.md).
77+
When you open a PR for a Draft XLS, you should:
5678

57-
Assuming there is consensus to publish, one of the project maintainers will review the submission and assign the document's XLS number, after which the author should update the PR to reflect the assigned number with the following naming convention: `XLS-{0000}-{title}`, where `{0000}` is the unique number referencing the XLS. Once at least one other person involved in the spec process for that spec has approved, and the maintainer has ensured that the template and naming conventions are followed, the maintainer will merge the PR.
79+
- Close the original Discussion (if it's still open).
80+
- Link the PR from the original Discussion (for traceability).
81+
- Optionally, add a final comment pointing to the PR so others know where to continue the conversation.
5882

59-
#### Candidate Specifications
83+
## 4. Creating a Draft XLS (Pull Request)
6084

61-
A _Candidate Specification_ is a document that was previously a Draft, but is considered stable enough by the community such that no further changes are required. Once an XLS becomes a Candidate Specification, no further substantive changes are allowed under the same XLS number.
85+
Once there is a clear Proposal with community interest, you can open a PR to add a **Draft** XLS to this repository.
6286

63-
Refinements in detail are still allowed and recommended. For example, you can clarify exact error cases and define the error codes and transaction result codes that occur in those cases.
87+
At a high level this looks like:
6488

65-
##### Publishing a Candidate Specification
89+
1. **Create a new directory for your draft.**
90+
- Use a temporary name such as `XLS-draft-<short-title>` while the number is being assigned.
91+
2. **Copy the template.**
92+
- Base your document on [XLS_TEMPLATE.md](./templates/XLS_TEMPLATE.md).
93+
3. **Fill out the required sections.**
94+
- Follow [XLS-1 §4.3: Format: Drafts and Onward](./XLS-0001-xls-process/README.md#43-format-drafts-and-onward), especially the required preamble and sections.
95+
4. **Open a pull request.**
96+
- Link the associated Discussion in the PR description.
97+
- Make it clear which `category` you are targeting and that this is intended to be a `Draft`.
98+
5. **Work with XLS Editors.**
99+
- Editors review for completeness, formatting, and clarity (see [XLS-1 §7](./XLS-0001-xls-process/README.md#7-xls-editors)).
100+
- Editors assign the official XLS number and update the directory name to `XLS-<NNNN>-<short-title>`.
101+
- The `xls` and `status` fields in the preamble are updated to reflect the assigned number and `Draft` status before merge.
66102

67-
When a Draft is considered stable, there is a call for review from the community to publish the document as a Candidate Specification by making a PR to remove the `d` from the document folder name and update the `type` to `candidate-specification`.
103+
After the PR is merged, your XLS is an officially tracked **Draft** in this repository.
68104

69-
Once published as a Candidate Specification, no further substantive changes are allowed under the same XLS number.
105+
## 5. Moving from Draft to Final (or Living)
70106

71-
For Specifications that require changes or implementation in the XRP Ledger server software and protocol, the Candidate Specification cannot be published until the relevant change has been merged into [the software's `master` branch](https://github.com/XRPLF/rippled/tree/master).
107+
Promotion from `Draft` to `Final` (or `Living`) is governed by XLS-1 (see [§4](./XLS-0001-xls-process/README.md#4-xls-process)). In summary:
72108

73-
#### Errata
109+
- A `Final` XLS is considered the canonical form of the standard.
110+
- Only errata and non-normative clarifications should be added afterward.
111+
- For **Amendment** and **System** XLSes, an XLS cannot be `Final` until the corresponding implementation (for example, in `rippled`) has been merged.
112+
- For **Ecosystem** and **Meta** XLSes, there should be at least one complete implementation or clear adoption before moving to `Final`.
113+
- Some documents (including XLS-1) are explicitly marked `Living` and are expected to evolve over time instead of reaching `Final`.
74114

75-
The community may discover errors in a Candidate Specification. In these circumstances, it is possible to update the document to fix typos or clarify the original meaning of the document.
115+
Requests to move a `Draft` to `Final` (or `Living`) should be made via a PR that updates the `status` field in the preamble and, if applicable, links to implementations.
76116

77-
### Deprecated or Rejected XLSs
117+
## 6. Stagnant, Withdrawn, and Deprecated XLSes
78118

79-
An XLS document may be rejected after public discussion has settled and comments have been made summarizing the rationale for rejection. Similarly, a document may be deprecated when its use should be discouraged. A member of the core maintainer team will move rejected and deprecated proposals to the `/rejected` folder in this repo.
119+
XLS-1 defines additional statuses that describe the long-term state of a spec:
120+
121+
- **Stagnant**: a `Draft` that has had no activity for at least 6 months.
122+
- **Withdrawn**: an XLS that the author(s) have actively withdrawn; this state has finality and the number should not be reused.
123+
- **Deprecated**: a `Final` XLS that is no longer recommended. This is typically chosen when a better alternative exists or when the functionality is being phased out.
124+
125+
The precise rules for these transitions, and how they are recorded, are described in [XLS-1 §4](./XLS-0001-xls-process/README.md#4-xls-process).
126+
127+
## 7. Ownership and Editors
128+
129+
The roles and responsibilities around XLS authorship and editing are defined in [XLS-1 §6–7](./XLS-0001-xls-process/README.md#6-xls-ownership).
130+
131+
- **Authors** own and champion their XLSes, shepherding them through the process and building community consensus.
132+
- **XLS Editors** (maintainers of this repository):
133+
- Help ensure proposals are complete, well-structured, and follow the required format.
134+
- Assign XLS numbers and merge PRs once they meet the bar.
135+
- Do **not** decide which technical direction is “correct” when there are competing proposals; their role is editorial and administrative.
136+
137+
If you are unsure how to proceed at any step, open a Discussion or PR and explicitly ask for help from the XLS Editors; they will guide you according to XLS-1.

0 commit comments

Comments
 (0)