Merge branch 'tapanito/vault-enhanced' into tapanito/vault-block-deposit

Author: Tapanito

.github/scripts/assign_xls_number.py

@@ -63,7 +63,7 @@ def find_draft_xls_files(changed_files: list[str]) -> list[str]:
     Returns:
         List of draft XLS directory names (e.g., ["XLS-draft-my-feature"])
     """
-    draft_pattern = re.compile(r"^(XLS-draft-[^/]+)/README\.md$")
+    draft_pattern = re.compile(r"^((XLS|xls)-draft[^/]+)/README\.md$")
     drafts = []
 
     for file_path in changed_files:
@@ -76,9 +76,15 @@ def find_draft_xls_files(changed_files: list[str]) -> list[str]:
 
 def main():
     """Main entry point for the script."""
-    # Get repository root (parent of .github directory)
-    script_dir = Path(__file__).resolve().parent
-    repo_root = script_dir.parent.parent
+    # Get repository root from environment variable (set by GitHub Actions)
+    # or fall back to calculating from script location
+    repo_root_env = os.environ.get("REPO_ROOT")
+    if repo_root_env:
+        repo_root = Path(repo_root_env)
+    else:
+        # Fallback: parent of .github directory
+        script_dir = Path(__file__).resolve().parent
+        repo_root = script_dir.parent.parent
 
     # Get changed files from command line arguments or environment variable
     if len(sys.argv) > 1:
@@ -121,7 +127,7 @@ def set_github_output(name: str, value: str):
 
     for draft_dir in sorted(draft_dirs):
         assigned_number = next_number
-        new_dir_name = re.sub(r"^XLS-draft-", f"XLS-{assigned_number:04d}-", draft_dir)
+        new_dir_name = re.sub(r"^xls-draft-", f"xls-{assigned_number:04d}-", draft_dir.lower())
         assignments.append({
             "draft": draft_dir,
             "number": assigned_number,
@@ -143,7 +149,7 @@ def set_github_output(name: str, value: str):
 
     # For single draft case, also output individual values for easy access
     if len(assignments) == 1:
-        set_github_output("xls_number", f"{assignments[0]['number']:04d}")
+        set_github_output("xls_number", f"{assignments[0]['number']}")
         set_github_output("draft_dir", assignments[0]['draft'])
         set_github_output("new_dir_name", assignments[0]['new_name'])
 

.github/workflows/assign-xls-number.yml

@@ -1,30 +1,41 @@
 name: Assign XLS Number
 
 on:
-  pull_request:
-    types: [opened, synchronize, reopened]
+  pull_request_target:
+    types: [opened, synchronize, reopened, ready_for_review]
 
 jobs:
   assign-xls-number:
     runs-on: ubuntu-latest
     name: Assign XLS Number to Draft
     permissions:
       pull-requests: write
+      issues: write
       contents: read
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
         with:
           fetch-depth: 0
+          ref: ${{ github.event.pull_request.head.sha }}
+
+      - name: Checkout script from base branch
+        uses: actions/checkout@v6
+        with:
+          ref: ${{ github.event.pull_request.base.ref }}
+          sparse-checkout: |
+            .github/scripts/assign_xls_number.py
+          sparse-checkout-cone-mode: false
+          path: base-repo
 
       - name: Get added files
         id: added-files
         uses: tj-actions/changed-files@v47
         with:
           files: |
-            XLS-draft-*/README.md
-            xls-draft-*/README.md
+            XLS-draft*/README.md
+            xls-draft*/README.md
           # Only look at added files, not modified ones
           include_all_old_new_renamed_files: false
 
@@ -51,9 +62,11 @@ jobs:
       - name: Assign XLS number
         if: steps.check-drafts.outputs.has_drafts == 'true'
         id: assign-number
+        env:
+          REPO_ROOT: ${{ github.workspace }}
         run: |
           echo ${{ steps.check-drafts.outputs.draft_files }}
-          python .github/scripts/assign_xls_number.py ${{ steps.check-drafts.outputs.draft_files }}
+          python base-repo/.github/scripts/assign_xls_number.py ${{ steps.check-drafts.outputs.draft_files }}
 
       - name: Check for existing assignment comment
         if: steps.check-drafts.outputs.has_drafts == 'true'

.github/workflows/discussions.yml

@@ -10,7 +10,7 @@ permissions:
   contents: read # Required to checkout the repository
 
 env:
-  STALE_DAYS: 730 # Number of days without updates to consider a discussion stale (2 years)
+  STALE_DAYS: 550 # Number of days without updates to consider a discussion stale (1.5 years)
   WARNING_DAYS: 30 # Number of days to wait after warning before closing
   WARNING_MESSAGE:
     | # note: the marker is necessary for the script and should not be removed

XLS-0008-tickets/README.md

@@ -6,6 +6,7 @@
   created: 2020-03-01
   proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/23
   status: Withdrawn
+  withdrawal-reason: Superseded by XLS-13
   category: Amendment
 </pre>
 

XLS-0010-non-transferable-tokens/README.md

@@ -1,6 +1,7 @@
 <pre>
     xls: 10
     title: Non-Transferable Token (NTT) standard
+    description: A standard for non-transferable tokens on the XRP Ledger
     author: RichardAH (@RichardAH)
     proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/20
     created: 2020-04-05

XLS-0015-concise-tx-id/README.md

@@ -6,6 +6,7 @@
   created: 2021-03-09
   proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/34
   status: Withdrawn
+  withdrawal-reason: Superseded by XLS-37
   category: System
 </pre>
 

XLS-0016-nft-metadata/README.md

@@ -1,11 +1,12 @@
 <pre>
-    xls: 16
-    title: NFT Metadata
-    author: Hubert Getrouw (@HubertG97)
-    created: 2021-03-17
-    proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/37
-    status: Stagnant
-    category: Ecosystem
+  xls: 16
+  title: NFT Metadata
+  description: Standard for NFT metadata
+  author: Hubert Getrouw (@HubertG97)
+  created: 2021-03-17
+  proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/37
+  status: Stagnant
+  category: Ecosystem
 </pre>
 
 In addition to @WietseWind 's [XLS-14](https://github.com/XRPLF/XRPL-Standards/discussions/30) and @RichardAH 's proposal [XLS-15](../XLS-0015-concise-tx-id/README.md) here is a proposal to create a standard for the creation of metadata for the tokens created with a CTI in the currency code.

XLS-0017-xfl/README.md

@@ -1,7 +1,7 @@
 <pre>
     xls: 17
     title: XFL Developer-friendly representation of XRPL balances
-    descrption: Introduces developer-friendly representation of XRPL balances.
+    description: Introduces developer-friendly representation of XRPL balances.
     author: RichardAH (@RichardAH)
     proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/39
     created: 2021-03-19

XLS-0051-nftoken-escrow/README.md

@@ -1,11 +1,12 @@
 <pre>
   xls: 51
   title: NFToken Escrows
+  description: Extension to Escrow functionality to support escrowing NFTokens
   author: Mayukha Vadari (@mvadari)
-  created: 2023-11-17
   proposal-from: https://github.com/XRPLF/XRPL-Standards/discussions/146
   status: Stagnant
   category: Amendment
+  created: 2023-11-17
 </pre>
 
 # NFToken Escrows