Skip to content

Commit 1a7df37

Browse files
authored
Add vim to all images (#19)
When troubleshooting CI related issues, it is **really** useful to have a text editor handy. We could select something smaller than `vim` (which is 55MB in Debian/Ubuntu 😢) but with a similar user interface, for example `nvi` but then RHEL does not have it, or we could select something smaller than `vim` but wit a non-standard UI like `joe` or `nano`, but if you are troubleshooting build issues you probably also know `vi` or `vim` better than the other two.
1 parent 18801e5 commit 1a7df37

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

docker/debian/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ pkgs+=(ninja-build) # Required build tool.
5050
pkgs+=(pipx) # Package manager for Python applications.
5151
pkgs+=(python3-jinja2) # Required build tool.
5252
pkgs+=(wget) # Required build tool.
53+
pkgs+=(vim) # Text editor.
5354
apt-get update
5455
apt-get install -y --no-install-recommends "${pkgs[@]}"
5556
apt-get clean

docker/rhel/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ pkgs+=(python3-pip) # Package manager for Python applications.
2828
pkgs+=(rpm-build) # Required packaging tool.
2929
pkgs+=(rpmdevtools) # Required packaging tool.
3030
pkgs+=(wget) # Required build tool.
31+
pkgs+=(vim) # Text editor.
3132
dnf install -y --allowerasing --setopt=tsflags=nodocs "${pkgs[@]}"
3233
dnf clean -y all
3334
rm -rf /var/cache/dnf/*

docker/tools-rippled/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ pkgs+=(gpg-agent) # Dependency for tools requiring signing or encrypting/d
3232
pkgs+=(jq) # Pretty printing.
3333
pkgs+=(pipx) # Package manager for Python applications.
3434
pkgs+=(wget) # Required build tool.
35+
pkgs+=(vim) # Text editor.
3536
apt-get update
3637
apt-get install -y --no-install-recommends "${pkgs[@]}"
3738
apt-get clean

docker/ubuntu/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ pkgs+=(ninja-build) # Required build tool.
3939
pkgs+=(pipx) # Package manager for Python applications.
4040
pkgs+=(python3-jinja2) # Required build tool.
4141
pkgs+=(wget) # Required build tool.
42+
pkgs+=(vim) # Text editor.
4243
apt-get update
4344
apt-get install -y --no-install-recommends "${pkgs[@]}"
4445
apt-get clean

0 commit comments

Comments
 (0)