Skip to content

Commit 52d2ae6

Browse files
authored
Enforce ld.gold is installed and show its version (#53)
This does not actually add `ld.gold` to our docker images (since `binutils` is a required dependency and contains gold in all the distros we currently support), however it does make it explicit and shows its version. Might be also useful for the future, if `ld.gold` is no longer installed by default (e.g. Debian Trixie).
1 parent d1496b8 commit 52d2ae6

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

docker/debian/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ EOF
3838
RUN <<EOF
3939
pkgs=()
4040
pkgs+=(ca-certificates) # Enable TLS verification for HTTPS connections by providing trusted root certificates.
41+
pkgs+=(binutils-gold) # Required build tool.
4142
pkgs+=(curl) # Dependency for tools requiring downloading data.
4243
pkgs+=(dpkg-dev) # Required packaging tool.
4344
pkgs+=(debhelper) # Required packaging tool.
@@ -59,6 +60,8 @@ apt-get clean
5960
rm -rf /var/lib/apt/lists/*
6061
EOF
6162

63+
RUN ld.gold --version
64+
6265
# Install Python-based tools and cmake.
6366
ARG CONAN_VERSION
6467
ARG GCOVR_VERSION

docker/rhel/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ ENTRYPOINT ["/bin/bash"]
1212
RUN <<EOF
1313
pkgs=()
1414
pkgs+=(ca-certificates) # Enable TLS verification for HTTPS connections by providing trusted root certificates.
15+
pkgs+=(binutils-gold) # Required build tool.
1516
pkgs+=(file) # Required packaging tool.
1617
pkgs+=(git) # Required build tool.
1718
pkgs+=(gpg) # Dependency for tools requiring signing or encrypting/decrypting.
@@ -52,6 +53,8 @@ mkdir -p /usr/local/lib
5253
ln -sf /usr/lib/python3.12 /usr/local/lib/python3.12
5354
EOF
5455

56+
RUN ld.gold --version
57+
5558
# Install Python-based tools and cmake.
5659
ARG CONAN_VERSION
5760
ARG GCOVR_VERSION

docker/ubuntu/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ EOF
2626
RUN <<EOF
2727
pkgs=()
2828
pkgs+=(ca-certificates) # Enable TLS verification for HTTPS connections by providing trusted root certificates.
29+
pkgs+=(binutils-gold) # Required build tool.
2930
pkgs+=(curl) # Dependency for tools requiring downloading data.
3031
pkgs+=(dpkg-dev) # Required packaging tool.
3132
pkgs+=(file) # Required packaging tool.
@@ -46,6 +47,8 @@ apt-get clean
4647
rm -rf /var/lib/apt/lists/*
4748
EOF
4849

50+
RUN ld.gold --version
51+
4952
# Install Python-based tools and cmake.
5053
ARG CONAN_VERSION
5154
ARG GCOVR_VERSION

0 commit comments

Comments
 (0)