Remove default arg values and disable warning

Author: bthomee

.github/workflows/debian.yml

@@ -11,6 +11,7 @@ env:
   DOCKER_BUILDKIT: 1
   BUILDKIT_PROGRESS: plain
   CONAN_VERSION: 2.17.0
+  NONROOT_USER: ci
 
 jobs:
   # Build the Docker image for Debian using different versions of GCC.
@@ -41,10 +42,13 @@ jobs:
         run: |
           docker build . \
           --target gcc \
-          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
+          --build-arg BUILDKIT_INLINE_CACHE=1 \
+          --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
           --build-arg DEBIAN_VERSION=${{ matrix.version.os }} \
           --build-arg GCC_VERSION=${{ matrix.version.gcc }} \
-          --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
+          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg NONROOT_USER=${{ env.NONROOT_USER }} \
           --tag ${{ env.DOCKER_IMAGE }}
       - name: Push the Docker image
         run: docker push ${{ env.DOCKER_IMAGE }}
@@ -81,10 +85,13 @@ jobs:
         run: |
           docker build . \
           --target clang \
-          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
-          --build-arg DEBIAN_VERSION=${{ matrix.version.os }} \
+          --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
+          --build-arg BUILDKIT_INLINE_CACHE=1 \
           --build-arg CLANG_VERSION=${{ matrix.version.clang }} \
           --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
+          --build-arg DEBIAN_VERSION=${{ matrix.version.os }} \
+          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg NONROOT_USER=${{ env.NONROOT_USER }} \
           --tag ${{ env.DOCKER_IMAGE }}
       - name: Push the Docker image
         run: docker push ${{ env.DOCKER_IMAGE }}

.github/workflows/rhel.yml

@@ -12,6 +12,7 @@ env:
   DOCKER_BUILDKIT: 1
   BUILDKIT_PROGRESS: plain
   CONAN_VERSION: 2.17.0
+  NONROOT_USER: ci
 
 jobs:
   # Build the Docker image for Red Hat Enterprise Linux using different versions
@@ -43,10 +44,13 @@ jobs:
         run: |
           docker build . \
           --target gcc \
-          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
-          --build-arg RHEL_VERSION=${{ matrix.version.os }} \
+          --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
+          --build-arg BUILDKIT_INLINE_CACHE=1 \
           --build-arg GCC_VERSION=${{ matrix.version.gcc }} \
           --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
+          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg NONROOT_USER=${{ env.NONROOT_USER }} \
+          --build-arg RHEL_VERSION=${{ matrix.version.os }} \
           --tag ${{ env.DOCKER_IMAGE }}
       - name: Push the Docker image
         run: docker push ${{ env.DOCKER_IMAGE }}
@@ -78,9 +82,12 @@ jobs:
         run: |
           docker build . \
           --target clang \
+          --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
+          --build-arg BUILDKIT_INLINE_CACHE=1 \
+          --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
           --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg NONROOT_USER=${{ env.NONROOT_USER }} \
           --build-arg RHEL_VERSION=${{ matrix.version.os }} \
-          --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
           --tag ${{ env.DOCKER_IMAGE }}
       - name: Push the Docker image
         run: docker push ${{ env.DOCKER_IMAGE }}

.github/workflows/ubuntu.yml

@@ -11,6 +11,7 @@ env:
   DOCKER_BUILDKIT: 1
   BUILDKIT_PROGRESS: plain
   CONAN_VERSION: 2.17.0
+  NONROOT_USER: ci
 
 jobs:
   # Build the Docker image for Ubuntu using different versions of GCC. See
@@ -42,10 +43,13 @@ jobs:
         run: |
           docker build . \
           --target gcc \
+          --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
+          --build-arg BUILDKIT_INLINE_CACHE=1 \
+          --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
+          --build-arg GCC_VERSION=${{ matrix.version.gcc }} \
           --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg NONROOT_USER=${{ env.NONROOT_USER }} \
           --build-arg UBUNTU_VERSION=${{ matrix.version.os }} \
-          --build-arg GCC_VERSION=${{ matrix.version.gcc }} \
-          --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
           --tag ${{ env.DOCKER_IMAGE }}
       - name: Push the Docker image
         run: docker push ${{ env.DOCKER_IMAGE }}
@@ -81,10 +85,13 @@ jobs:
         run: |
           docker build . \
           --target clang \
-          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
-          --build-arg UBUNTU_VERSION=${{ matrix.version.os }} \
+          --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
+          --build-arg BUILDKIT_INLINE_CACHE=1 \
           --build-arg CLANG_VERSION=${{ matrix.version.clang }} \
           --build-arg CONAN_VERSION=${{ env.CONAN_VERSION }} \
+          --build-arg GITHUB_REPO=${GITHUB_REPOSITORY} \
+          --build-arg NONROOT_USER=${{ env.NONROOT_USER }} \
+          --build-arg UBUNTU_VERSION=${{ matrix.version.os }} \
           --tag ${{ env.DOCKER_IMAGE }}
       - name: Push the Docker image
         run: docker push ${{ env.DOCKER_IMAGE }}

docker/debian/Dockerfile

@@ -3,9 +3,11 @@
 # contain dynamic values supplied via an argument. We are using GCC image rather
 # than the official Debian package to access the latest versions, built by the
 # GCC team specifically for this Debian release. For build images using official
-# distribution packages, see Ubuntu.
-ARG DEBIAN_VERSION=bookworm
-ARG GCC_VERSION=12
+# distribution packages, see Ubuntu. We set the GCC version to "invalid" to
+# satisfy the syntax checker, as it checks if the `FROM` command has a valid
+# image, even though it is not used for Clang.
+ARG DEBIAN_VERSION
+ARG GCC_VERSION=invalid
 FROM gcc:${GCC_VERSION}-${DEBIAN_VERSION} AS gcc-src
 
 # ====================== BASE IMAGE ======================
@@ -16,7 +18,7 @@ SHELL ["/bin/bash", "-c"]
 ENTRYPOINT ["/bin/bash"]
 
 # Associate the image with the repository.
-ARG GITHUB_REPO=XRPLF/ci
+ARG GITHUB_REPO
 LABEL org.opencontainers.image.source=https://github.com/${GITHUB_REPO}
 
 # Ensure any packages installed directly or indirectly via dpkg do not require
@@ -46,14 +48,14 @@ apt install -y "${pkgs[@]}"
 EOF
 
 # Install Conan.
-ARG CONAN_VERSION=2.17.0
+ARG CONAN_VERSION
 RUN PIPX_HOME=/opt/pipx \
     PIPX_BIN_DIR=/usr/bin \
     PIPX_MAN_DIR=/usr/share/man \
     pipx install conan==${CONAN_VERSION}
 
 # Create the user to switch to, once all packages have been installed.
-ARG NONROOT_USER=ci
+ARG NONROOT_USER
 RUN useradd -ms /bin/bash ${NONROOT_USER}
 
 # ====================== GCC IMAGE ======================
@@ -105,7 +107,7 @@ FROM base AS clang
 # must repeat the DEBIAN_VERSION argument here, as it is not inherited from the
 # base image.
 ARG DEBIAN_VERSION
-ARG CLANG_VERSION=16
+ARG CLANG_VERSION
 RUN curl --no-progress-meter https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor -o /etc/apt/keyrings/llvm.gpg && \
     printf "%s\n%s\n" \
       "deb [signed-by=/etc/apt/keyrings/llvm.gpg] https://apt.llvm.org/${DEBIAN_VERSION}/ llvm-toolchain-${DEBIAN_VERSION}-${CLANG_VERSION} main" \

docker/debian/README.md

@@ -37,17 +37,22 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
+GITHUB_REPO=XRPLF/ci
+NONROOT_USER=${USER}
 DEBIAN_VERSION=bookworm
 GCC_VERSION=12
 CONAN_VERSION=2.17.0
 DOCKER_IMAGE=xrplf/ci/debian-${DEBIAN_VERSION}:gcc${GCC_VERSION}
 
 DOCKER_BUILDKIT=1 BUILDKIT_PROGRESS=plain docker build . \
   --target gcc \
+  --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
+  --build-arg CONAN_VERSION=${CONAN_VERSION} \
   --build-arg DEBIAN_VERSION=${DEBIAN_VERSION} \
   --build-arg GCC_VERSION=${GCC_VERSION} \
-  --build-arg CONAN_VERSION=${CONAN_VERSION} \
+  --build-arg GITHUB_REPO=${GITHUB_REPO} \
+  --build-arg NONROOT_USER=${NONROOT_USER} \
   --tag ${CONTAINER_REGISTRY}/${DOCKER_IMAGE} \
   --platform linux/amd64
 ```
@@ -58,17 +63,22 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
+GITHUB_REPO=XRPLF/ci
+NONROOT_USER=${USER}
 DEBIAN_VERSION=bookworm
 CLANG_VERSION=17
 CONAN_VERSION=2.17.0
 DOCKER_IMAGE=xrplf/ci/debian-${DEBIAN_VERSION}:clang${CLANG_VERSION}
 
 DOCKER_BUILDKIT=1 BUILDKIT_PROGRESS=plain docker build . \
   --target clang \
+  --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
-  --build-arg DEBIAN_VERSION=${DEBIAN_VERSION} \
   --build-arg CLANG_VERSION=${CLANG_VERSION} \
   --build-arg CONAN_VERSION=${CONAN_VERSION} \
+  --build-arg DEBIAN_VERSION=${DEBIAN_VERSION} \
+  --build-arg GITHUB_REPO=${GITHUB_REPO} \
+  --build-arg NONROOT_USER=${NONROOT_USER} \
   --tag ${CONTAINER_REGISTRY}/${DOCKER_IMAGE} \
   --platform linux/amd64
 ```

docker/rhel/Dockerfile

@@ -1,5 +1,5 @@
 # ====================== GCC IMAGE ======================
-ARG RHEL_VERSION=9.6
+ARG RHEL_VERSION
 FROM registry.redhat.io/ubi${RHEL_VERSION%.*}/s2i-base:${RHEL_VERSION} AS base
 
 # Change to the root user to install packages.
@@ -10,7 +10,7 @@ SHELL ["/bin/bash", "-c"]
 ENTRYPOINT ["/bin/bash"]
 
 # Associate the image with the repository.
-ARG GITHUB_REPO=XRPLF/ci
+ARG GITHUB_REPO
 LABEL org.opencontainers.image.source=https://github.com/${GITHUB_REPO}
 
 # Install tools that are shared by all stages.
@@ -29,18 +29,18 @@ dnf install -y --setopt=tsflags=nodocs "${pkgs[@]}"
 EOF
 
 # Install Conan.
-ARG CONAN_VERSION=2.17.0
+ARG CONAN_VERSION
 RUN pip install conan==${CONAN_VERSION}
 
 # Create the user to switch to, once all packages have been installed.
-ARG NONROOT_USER=ci
+ARG NONROOT_USER
 RUN useradd -ms /bin/bash ${NONROOT_USER}
 
 # ====================== GCC IMAGE ======================
 FROM base AS gcc
 
 # Install GCC.
-ARG GCC_VERSION=14
+ARG GCC_VERSION
 RUN dnf install -y --setopt=tsflags=nodocs gcc-toolset-${GCC_VERSION}-gcc gcc-toolset-${GCC_VERSION}-gcc-c++
 
 # Switch to the non-root user.

docker/rhel/README.md

@@ -56,17 +56,22 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
+GITHUB_REPO=XRPLF/ci
+NONROOT_USER=${USER}
 RHEL_VERSION=9.6
 GCC_VERSION=13
 CONAN_VERSION=2.17.0
 DOCKER_IMAGE=xrplf/ci/rhel-${RHEL_VERSION}:gcc${GCC_VERSION}
 
 DOCKER_BUILDKIT=1 BUILDKIT_PROGRESS=plain docker build . \
   --target gcc \
+  --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
-  --build-arg RHEL_VERSION=${RHEL_VERSION} \
-  --build-arg GCC_VERSION=${GCC_VERSION} \
   --build-arg CONAN_VERSION=${CONAN_VERSION} \
+  --build-arg GCC_VERSION=${GCC_VERSION} \
+  --build-arg GITHUB_REPO=${GITHUB_REPO} \
+  --build-arg NONROOT_USER=${NONROOT_USER} \
+  --build-arg RHEL_VERSION=${RHEL_VERSION} \
   --tag ${CONTAINER_REGISTRY}/${DOCKER_IMAGE} \
   --platform linux/amd64
 ```
@@ -77,15 +82,20 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
+GITHUB_REPO=XRPLF/ci
+NONROOT_USER=${USER}
 RHEL_VERSION=9.6
 CONAN_VERSION=2.17.0
 DOCKER_IMAGE=xrplf/ci/rhel-${RHEL_VERSION}:clang${CLANG_VERSION}
 
 DOCKER_BUILDKIT=1 BUILDKIT_PROGRESS=plain docker build . \
   --target clang \
+  --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
-  --build-arg RHEL_VERSION=${RHEL_VERSION} \
   --build-arg CONAN_VERSION=${CONAN_VERSION} \
+  --build-arg GITHUB_REPO=${GITHUB_REPO} \
+  --build-arg NONROOT_USER=${NONROOT_USER} \
+  --build-arg RHEL_VERSION=${RHEL_VERSION} \
   --tag ${CONTAINER_REGISTRY}/${DOCKER_IMAGE} \
   --platform linux/amd64
 ```

docker/ubuntu/Dockerfile

@@ -1,13 +1,13 @@
 # ====================== BASE IMAGE ======================
-ARG UBUNTU_VERSION=jammy
+ARG UBUNTU_VERSION
 FROM ubuntu:${UBUNTU_VERSION} AS base
 
 # Use Bash as the default shell for RUN commands and as the entrypoint.
 SHELL ["/bin/bash", "-c"]
 ENTRYPOINT ["/bin/bash"]
 
 # Associate the image with the repository.
-ARG GITHUB_REPO=XRPLF/ci
+ARG GITHUB_REPO
 LABEL org.opencontainers.image.source=https://github.com/${GITHUB_REPO}
 
 # Ensure any packages installed directly or indirectly via dpkg do not require
@@ -37,21 +37,21 @@ apt install -y "${pkgs[@]}"
 EOF
 
 # Install Conan.
-ARG CONAN_VERSION=2.17.0
+ARG CONAN_VERSION
 RUN PIPX_HOME=/opt/pipx \
     PIPX_BIN_DIR=/usr/bin \
     PIPX_MAN_DIR=/usr/share/man \
     pipx install conan==${CONAN_VERSION}
 
 # Create the user to switch to, once all packages have been installed.
-ARG NONROOT_USER=ci
+ARG NONROOT_USER
 RUN useradd -ms /bin/bash ${NONROOT_USER}
 
 # ====================== GCC IMAGE ======================
 FROM base AS gcc
 
 # Install GCC.
-ARG GCC_VERSION=12
+ARG GCC_VERSION
 RUN apt install -y gcc-${GCC_VERSION} g++-${GCC_VERSION}
 ENV CC=/usr/bin/gcc-${GCC_VERSION}
 ENV CXX=/usr/bin/gcc-${GCC_VERSION}
@@ -74,7 +74,7 @@ RUN conan profile show
 FROM base AS clang
 
 # Install Clang.
-ARG CLANG_VERSION=16
+ARG CLANG_VERSION
 RUN apt install -y clang-${CLANG_VERSION} llvm-${CLANG_VERSION}
 ENV CC=/usr/bin/clang-${CLANG_VERSION}
 ENV CXX=/usr/bin/clang++-${CLANG_VERSION}

docker/ubuntu/README.md

@@ -37,17 +37,22 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
+GITHUB_REPO=XRPLF/ci
+NONROOT_USER=${USER}
 UBUNTU_VERSION=noble
 GCC_VERSION=14
 CONAN_VERSION=2.17.0
 DOCKER_IMAGE=xrplf/ci/ubuntu-${UBUNTU_VERSION}:gcc${GCC_VERSION}
 
 DOCKER_BUILDKIT=1 BUILDKIT_PROGRESS=plain docker build . \
   --target gcc \
+  --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
-  --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
-  --build-arg GCC_VERSION=${GCC_VERSION} \
   --build-arg CONAN_VERSION=${CONAN_VERSION} \
+  --build-arg GCC_VERSION=${GCC_VERSION} \
+  --build-arg GITHUB_REPO=${GITHUB_REPO} \
+  --build-arg NONROOT_USER=${NONROOT_USER} \
+  --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
   --tag ${CONTAINER_REGISTRY}/${DOCKER_IMAGE} \
   --platform linux/amd64
 ```
@@ -58,17 +63,22 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
+GITHUB_REPO=XRPLF/ci
+NONROOT_USER=${USER}
 UBUNTU_VERSION=noble
 CLANG_VERSION=18
 CONAN_VERSION=2.17.0
 DOCKER_IMAGE=xrplf/ci/ubuntu-${UBUNTU_VERSION}:clang${CLANG_VERSION}
 
 DOCKER_BUILDKIT=1 BUILDKIT_PROGRESS=plain docker build . \
   --target clang \
+  --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
-  --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
   --build-arg CLANG_VERSION=${CLANG_VERSION} \
   --build-arg CONAN_VERSION=${CONAN_VERSION} \
+  --build-arg GITHUB_REPO=${GITHUB_REPO} \
+  --build-arg NONROOT_USER=${NONROOT_USER} \
+  --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
   --tag ${CONTAINER_REGISTRY}/${DOCKER_IMAGE} \
   --platform linux/amd64
 ```