Add pre-commit to clang-format

For now do not rename the image; it makes more sense after rippled have switched to pre-commit

Author: Bronek

.github/workflows/tools-rippled.yml

@@ -10,6 +10,7 @@ env:
   CONTAINER_REGISTRY: ghcr.io
   BUILDKIT_PROGRESS: plain
   CLANG_FORMAT_VERSION: 18.1.8
+  PRE_COMMIT_VERSION: 4.2.0
   NONROOT_USER: ci
   UBUNTU_VERSION: noble
 
@@ -74,6 +75,7 @@ jobs:
             NONROOT_USER=${{ env.NONROOT_USER }}
             UBUNTU_VERSION=${{ env.UBUNTU_VERSION }}
             CLANG_FORMAT_VERSION=${{ env.CLANG_FORMAT_VERSION }}
+            PRE_COMMIT_VERSION=${{ env.PRE_COMMIT_VERSION }}
           context: docker/tools-rippled
           outputs: type=image,name=${{ env.CONTAINER_IMAGE }},push-by-digest=true,name-canonical=true,push=true
           platforms: ${{ matrix.architecture.platform }}

docker/tools-rippled/Dockerfile

@@ -53,7 +53,9 @@ FROM base AS clang-format
 
 # Install clang-format.
 ARG CLANG_FORMAT_VERSION
-RUN pipx install --pip-args='--no-cache' clang-format==${CLANG_FORMAT_VERSION}
+ARG PRE_COMMIT_VERSION
+RUN pipx install --pip-args='--no-cache' clang-format==${CLANG_FORMAT_VERSION} \
+    pipx install --pip-args='--no-cache' pre-commit==${PRE_COMMIT_VERSION}
 
 # Switch to the non-root user.
 USER ${NONROOT_USER}

docker/tools-rippled/README.md

@@ -29,6 +29,7 @@ Currently this Dockerfile can be used to build one image:
 * `clang-format` with C++ formatting tools. This image requires parameters:
   * `UBUNTU_VERSION` for selection of Ubuntu release (recommended `noble`)
   * `CLANG_FORMAT_VERSION` for [clang-format](http://clang.llvm.org/docs/ClangFormat.html) version
+  * `PRE_COMMIT_VERSION` for [pre-commit](https://pre-commit.com/) version
 
 Run the commands below from the current directory containing the Dockerfile to build an image.
 
@@ -41,13 +42,15 @@ registry.
 NONROOT_USER=${USER}
 UBUNTU_VERSION=noble
 CLANG_FORMAT_VERSION=18.1.8
+PRE_COMMIT_VERSION=4.2.0
 CONTAINER_IMAGE=xrplf/ci/tools-rippled-clang-format:latest
 
 docker buildx build . \
   --target clang-format \
   --build-arg BUILDKIT_DOCKERFILE_CHECK=skip=InvalidDefaultArgInFrom \
   --build-arg BUILDKIT_INLINE_CACHE=1 \
   --build-arg CLANG_FORMAT_VERSION=${CLANG_FORMAT_VERSION} \
+  --build-arg PRE_COMMIT_VERSION=${PRE_COMMIT_VERSION} \
   --build-arg NONROOT_USER=${NONROOT_USER} \
   --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
   --tag ${CONTAINER_REGISTRY}/${CONTAINER_IMAGE}