Review feedback

Author: bthomee

docker/debian/Dockerfile

@@ -3,11 +3,11 @@
 # contain dynamic values supplied via an argument. We are using GCC image rather
 # than the official Debian package to access the latest versions, built by the
 # GCC team specifically for this Debian release. For build images using official
-# distribution packages, see Ubuntu. We set the GCC version to "invalid" to
+# distribution packages, see Ubuntu. We set the GCC version to "undefined" to
 # satisfy the syntax checker, as it checks if the `FROM` command has a valid
 # image, even though it is not used for Clang.
 ARG DEBIAN_VERSION
-ARG GCC_VERSION=invalid
+ARG GCC_VERSION=undefined
 ARG BASE_IMAGE=gcc:${GCC_VERSION}-${DEBIAN_VERSION}
 FROM ${BASE_IMAGE} AS gcc-src
 

docker/tools-rippled/Dockerfile

@@ -1,9 +1,11 @@
 # This argument must be defined before the base image, so it can be used in the
-# prettier image, which does not derive from the base image, below.
-ARG NODE_VERSION
+# prettier image, which does not derive from the base image, below. We set both
+# the Node and Ubuntu versions to "undefined" to satisfy the syntax checker, as
+# it checks if the `FROM` command has a valid image, even when it is not used.
+ARG NODE_VERSION=undefined
+ARG UBUNTU_VERSION=undefined
 
 # ====================== BASE IMAGE ======================
-ARG UBUNTU_VERSION
 FROM ubuntu:${UBUNTU_VERSION} AS base
 
 # Use Bash as the default shell for RUN commands, using the options
@@ -121,7 +123,7 @@ ENV HOME=/root
 WORKDIR ${HOME}
 
 # ====================== PRETTIER IMAGE ======================
-# Note, we do not install a compiler here.
+# Note, this image does not inherit from the base image.
 
 FROM node:${NODE_VERSION}-alpine AS prettier
 

docker/tools-rippled/README.md

@@ -24,12 +24,24 @@ docker login ${CONTAINER_REGISTRY} -u "${GITHUB_USER}" --password-stdin
 
 ### Building and pushing the Docker image
 
-Currently, this Dockerfile can be used to build one image:
+Currently, this Dockerfile can be used to build one the following images:
 
 * `clang-format` with C++ formatting tools. This image requires parameters:
-  * `UBUNTU_VERSION` for selection of Ubuntu release (recommended `noble`)
-  * `CLANG_FORMAT_VERSION` for [clang-format](http://clang.llvm.org/docs/ClangFormat.html) version
-  * `PRE_COMMIT_VERSION` for [pre-commit](https://pre-commit.com/) version
+  * `UBUNTU_VERSION` for selecting the Ubuntu release (recommended `noble`).
+  * `CLANG_FORMAT_VERSION` for the [clang-format](http://clang.llvm.org/docs/ClangFormat.html) version.
+  * `PRE_COMMIT_VERSION` for the [pre-commit](https://pre-commit.com/) version.
+* `documentation` with tools for building the rippled documentation. This image
+  requires parameters:
+  * `UBUNTU_VERSION` for selecting the Ubuntu release (recommended `noble`)
+  * `CMAKE_VERSION` for the [CMake](https://cmake.org/) version.
+  * `DOXYGEN_VERSION` for the [Doxygen](https://www.doxygen.nl/) version.
+  * `GCC_VERSION` for the [GCC](https://gcc.gnu.org/) version.
+  * `GRAPHVIZ_VERSION` for the [Graphviz](https://graphviz.org/) version.
+* `prettier` with tools for formatting JavaScript and TypeScript code. This
+  image requires parameters:
+  * `NODE_VERSION` for the [Node.js](https://nodejs.org/) version.
+  * `NPM_VERSION` for the [npm](https://www.npmjs.com/) version.
+  * `PRETTIER_VERSION` for the [Prettier](https://prettier.io/) version.
 
 In order to build an image, run the commands below from the root directory of
 the repository.
@@ -88,7 +100,6 @@ Ensure you've run the login command above to authenticate with the Docker
 registry.
 
 ```shell
-UBUNTU_VERSION=noble
 NODE_VERSION=24.6.0
 NPM_VERSION=11.5.2
 PRETTIER_VERSION=3.6.2
@@ -102,7 +113,6 @@ docker buildx build . \
   --build-arg NODE_VERSION=${NODE_VERSION} \
   --build-arg NPM_VERSION=${NPM_VERSION} \
   --build-arg PRETTIER_VERSION=${PRETTIER_VERSION} \
-  --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} \
   --tag ${CONTAINER_REGISTRY}/${CONTAINER_IMAGE}
 ```