File tree Expand file tree Collapse file tree 2 files changed +9
-1
lines changed
Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Original file line number Diff line number Diff line change @@ -40,7 +40,12 @@ if (is_appleclang)
4040endif ()
4141
4242if (san)
43- # for the time being we want the builds to succeed and sanitizers to assess our runtime behaviour
43+ # When building with sanitizers some compilers will actually produce extra warnings/errors. We don't want this yet, at
44+ # least not until we have fixed all runtime issues reported by the sanitizers. Once that is done we can start removing
45+ # some of these and trying to fix it in our codebase. We can never remove all of below because most of them are
46+ # reported from deep inside libraries like boost or libxrpl.
47+ #
48+ # TODO: Address in https://github.com/XRPLF/clio/issues/1885
4449 list (
4550 APPEND
4651 COMPILER_FLAGS
Original file line number Diff line number Diff line change @@ -3,5 +3,8 @@ if (Boost_STACKTRACE_FOUND)
33 target_compile_definitions (clio_options INTERFACE BOOST_STACKTRACE_USE_BACKTRACE)
44 find_package (libbacktrace REQUIRED CONFIG)
55else ()
6+ # Some sanitizers (TSAN and ASAN for sure) can't be used with libbacktrace because they have their own backtracing
7+ # capabilities and there are conflicts. In any case, this makes sure Clio code knows that backtrace is not available.
8+ # See relevant conan profiles for sanitizers where we disable stacktrace in Boost explicitly.
69 target_compile_definitions (clio_options INTERFACE CLIO_WITHOUT_STACKTRACE)
710endif ()
You can’t perform that action at this time.
0 commit comments