Skip to content

Commit 054c59c

Browse files
committed
Better docs
1 parent d1ad64e commit 054c59c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/actions/cmake/action.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,12 @@ runs:
5757
STATIC: "${{ inputs.static == 'true' && 'ON' || 'OFF' }}"
5858
TIME_TRACE: "${{ inputs.time_trace == 'true' && 'ON' || 'OFF' }}"
5959
PACKAGE: "${{ inputs.package == 'true' && 'ON' || 'OFF' }}"
60-
# GitHub creates merge commits for PRS, so we:
60+
# GitHub creates a merge commit for a PR
61+
# https://www.kenmuse.com/blog/the-many-shas-of-a-github-pull-request/
62+
#
63+
# We:
6164
# - explicitly provide branch name
62-
# - provide `github.head_ref` to get the actual commit SHA of the PR branch.
65+
# - use `github.head_ref` to get the SHA of last commit in the PR branch
6366
#
6467
# This way it works both for PRs and pushes to branches.
6568
GITHUB_BRANCH_NAME: "${{ github.head_ref || github.ref_name }}"

0 commit comments

Comments
 (0)